drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static
PATCH 1/1 drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static
smatch reports drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
'dcn3_14_soc' was not declared. Should it be static?
This variable is only used in one file so should be static.
Signed-off-by Tom Rix <[email protected]>
--- drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c +1 -1
@@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = { .dcc_supported = true, }; -struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = { +static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {/*TODO: correct dispclk/dppclk voltage level determination*/ .clock_limits = { {
Signature · 1 line
2.27.0
Hamza Mahfooz
AppliedQuoted 7 lines · Tom Rix
smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
'dcn3_14_soc' was not declared. Should it be static?This variable is only used in one file so should be static.
Signed-off-by Tom Rix <[email protected]>
Applied, thanks!
Quoted 17 lines
--- drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c +1
-1@@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = { .dcc_supported = true, }; -struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = { +static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {/*TODO: correct dispclk/dppclk voltage level determination*/ .clock_limits = { {
Signature · 1 line
Hamza