Skip to contentSkip to conversation

rvmet-fcloop: Remove remote port from list when unlinking

PATCH Superseded Daniel Wagner 1 participant 2 messages Apr 11, 2023

Subsystems (3)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rvmet-fcloop: Remove remote port from list when unlinking

The remote port is never removed from fcloop_nports list. During module unloading it's possible to end up an busy loop in fcloop_exit, because the remote port is found in the list and thus we will never progress.

The kernel log will be spammed with

nvme_fcloop: fcloop_exit: Failed deleting remote port
nvme_fcloop: fcloop_exit: Failed deleting target port

---
 drivers/nvme/target/fcloop.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/nvme/target/fcloop.c +2 -0
index 5c16372f3b53..1e53c8fe4b95 100644
@@ -1352,6 +1352,8 @@ __unlink_remote_port(struct fcloop_nport *nport)
 		nport->tport->remoteport = NULL;
 	nport->rport = NULL;
 
+	list_del(&nport->nport_list);
+
 	return rport;
 }
 
Signature · 1 line
2.40.0
#1 lore raw
Quoted 11 lines · Daniel Wagner

The remote port is never removed from fcloop_nports list. During module unloading it's possible to end up an busy loop in fcloop_exit, because the remote port is found in the list and thus we will never progress.

The kernel log will be spammed with

nvme_fcloop: fcloop_exit: Failed deleting remote port
nvme_fcloop: fcloop_exit: Failed deleting target port

---

Found a bunch more problems which need to be addressed. I'll collect all changes and send them as series.