rvmet-fcloop: Remove remote port from list when unlinking
Subsystems (3)
PATCH 1/1 rvmet-fcloop: Remove remote port from list when unlinking
The remote port is never removed from fcloop_nports list. During module unloading it's possible to end up an busy loop in fcloop_exit, because the remote port is found in the list and thus we will never progress.
The kernel log will be spammed with
nvme_fcloop: fcloop_exit: Failed deleting remote port
nvme_fcloop: fcloop_exit: Failed deleting target port
--- drivers/nvme/target/fcloop.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/nvme/target/fcloop.c +2 -0
@@ -1352,6 +1352,8 @@ __unlink_remote_port(struct fcloop_nport *nport) nport->tport->remoteport =NULL ; nport->rport =NULL ; +list_del (&nport->nport_list); +return rport; }
Signature · 1 line
2.40.0
Quoted 11 lines · Daniel Wagner
The remote port is never removed from
fcloop_nportslist. During module unloading it's possible to end up an busy loop infcloop_exit, because the remote port is found in the list and thus we will never progress.The kernel log will be spammed with
nvme_fcloop:fcloop_exit: Failed deleting remote port
nvme_fcloop:fcloop_exit: Failed deleting target portSigned-off-by Daniel Wagner <[email protected]>---
Found a bunch more problems which need to be addressed. I'll collect all changes and send them as series.