Skip to contentSkip to conversation

arm64: dts: ti: k3-j721s2-main: fix msmc node

PATCH In review Udit Kumar 3 participants 5 messages Apr 12, 2023 – Apr 13, 2023

Subsystems (2)
lore
Share & tools
lore

Udit Kumar

author
#0 lore raw

PATCH 1/1 arm64: dts: ti: k3-j721s2-main: fix msmc node

On J721S2 SOC, l3cache-sram size is configured as zero by system firmware.
Also top 64K of msmc_ram (0x703F_0000 to 0x703F_FFFF) is used by system firmware tifs-sram.

This patch removes l3cache-sram node and update range for tifs-sram.

Fixes b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +2 -5
index 2dd7865f7654..cbc784f915a9 100644
@@ -17,13 +17,10 @@ atf-sram@0 {
 			reg = <0x0 0x20000>;
 		};
 
-		tifs-sram@1f0000 {
-			reg = <0x1f0000 0x10000>;
+		tifs-sram@3f0000 {
+			reg = <0x3f0000 0x10000>;
 		};
 
-		l3cache-sram@200000 {
-			reg = <0x200000 0x200000>;
-		};
 	};
 
 	gic500: interrupt-controller@1800000 {
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 37 lines · Udit Kumar

On J721S2 SOC, l3cache-sram size is configured as zero by system firmware.
Also top 64K of msmc_ram (0x703F_0000 to 0x703F_FFFF) is used by system firmware tifs-sram.

This patch removes l3cache-sram node and update range for tifs-sram.

Fixes b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
---
 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +2 -5
index 2dd7865f7654..cbc784f915a9 100644
@@ -17,13 +17,10 @@ atf-sram@0 {
 			reg = <0x0 0x20000>;
 		};
 
-		tifs-sram@1f0000 {
-			reg = <0x1f0000 0x10000>;
+		tifs-sram@3f0000 {
+			reg = <0x3f0000 0x10000>;
 		};
 
-		l3cache-sram@200000 {
-			reg = <0x200000 0x200000>;
-		};
 	};
 
 	gic500: interrupt-controller@1800000 {
Signature · 1 line
2.34.1

Are you saying that j721s2 is incapable of l3 cache? say some level 1 errata?

or is it because, the chip is really capable of l3 cache and we are really setting it to 0?

https://git.ti.com/cgit/k3-image-gen/k3-image-gen/tree/soc/j721s2/evm/board-cfg.c#n71

unless the chip has an errata, you are supposed to fix it up based on configuration by using the API and this patch is a NAK
https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html#tisci-query-msmc

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
author
#2 lore raw

Hi Nishanth,

Quoted 34 lines · Nishanth Menon
Quoted 33 lines · Udit Kumar

On J721S2 SOC, l3cache-sram size is configured as zero by system firmware.
Also top 64K of msmc_ram (0x703F_0000 to 0x703F_FFFF) is used by system firmware tifs-sram.

This patch removes l3cache-sram node and update range for tifs-sram.

Fixes b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
---
  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +2 -5
index 2dd7865f7654..cbc784f915a9 100644
@@ -17,13 +17,10 @@ atf-sram@0 {
  			reg = <0x0 0x20000>;
  		};
 
-		tifs-sram@1f0000 {
-			reg = <0x1f0000 0x10000>;
+		tifs-sram@3f0000 {
+			reg = <0x3f0000 0x10000>;
  		};
 
-		l3cache-sram@200000 {
-			reg = <0x200000 0x200000>;
-		};
  	};
 
Quoted 6 lines
Quoted 4 lines
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +0 -0
  	gic500: interrupt-controller@1800000 {
Signature · 1 line
2.34.1

Are you saying that j721s2 is incapable of l3 cache? say some level 1 errata?

No

Quoted 4 lines

or is it because, the chip is really capable of l3 cache and we are really setting it to 0?

https://git.ti.com/cgit/k3-image-gen/k3-image-gen/tree/soc/j721s2/evm/board-cfg.c#n71

This is because, l3 cache size is set to zero.

Quoted 3 lines

unless the chip has an errata, you are supposed to fix it up based on configuration by using the API and this patch is a NAK
https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html#tisci-query-msmc

ok

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw

Hi Udit,

Quoted 46 lines · Udit Kumar

Hi Nishanth,

Quoted 31 lines · Nishanth Menon
Quoted 30 lines · Udit Kumar

On J721S2 SOC, l3cache-sram size is configured as zero by system firmware.
Also top 64K of msmc_ram (0x703F_0000 to 0x703F_FFFF) is used by system firmware tifs-sram.

This patch removes l3cache-sram node and update range for tifs-sram.

Fixes b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2

SoC")

---
  arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 ++-----

  1 file changed, 2 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +2 -2
index 2dd7865f7654..cbc784f915a9 100644
@@ -17,13 +17,10 @@ atf-sram@0 {
               reg = <0x0 0x20000>;
           };
   -        tifs-sram@1f0000 {
-            reg = <0x1f0000 0x10000>;
+        tifs-sram@3f0000 {
+            reg = <0x3f0000 0x10000>;
           };
   -        l3cache-sram@200000 {
-            reg = <0x200000 0x200000>;
Quoted 8 lines
Quoted 6 lines
arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +0 -1
-        };
       };
         gic500: interrupt-controller@1800000 {

--
2.34.1

Are you saying that j721s2 is incapable of l3 cache? say some level 1 errata?

No

Quoted 3 lines

or is it because, the chip is really capable of l3 cache and we are really setting it to 0?

Quoted 6 lines
Quoted 1 line

https://git.ti.com/cgit/k3-image-gen/k3-image-gen/tree/soc/j721s2/evm/board-cfg.c#n71

This is because, l3 cache size is set to zero.

Quoted 3 lines

unless the chip has an errata, you are supposed to fix it up based on configuration by using the API and this patch is a NAK
https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html#tisci-query-msmc

ok

U-Boot already does this. See fdt_fixup_msmc_ram() at board/ti/j721s2/evm.c

tifs-sram fixup probably is still needed and possible bug in the original patch?

Signature · 2 lines
Regards
Vignesh
author
#4 lore raw

Thanks Raghavendra

Quoted 15 lines · Vignesh Raghavendra

Hi Udit,

Quoted 12 lines · Udit Kumar

Hi Nishanth,

Quoted 4 lines · Nishanth Menon
Quoted 1 line · Udit Kumar

[..]

Are you saying that j721s2 is incapable of l3 cache? say some level 1 errata?

No

Quoted 4 lines

or is it because, the chip is really capable of l3 cache and we are really setting it to 0?

https://git.ti.com/cgit/k3-image-gen/k3-image-gen/tree/soc/j721s2/evm/board-cfg.c#n71

Quoted 8 lines
Quoted 5 lines

This is because, l3 cache size is set to zero.

Quoted 3 lines

unless the chip has an errata, you are supposed to fix it up based on configuration by using the API and this patch is a NAK
https://software-dl.ti.com/tisci/esd/latest/2_tisci_msgs/general/core.html#tisci-query-msmc

ok

U-Boot already does this. See fdt_fixup_msmc_ram() at board/ti/j721s2/evm.c

tifs-sram fixup probably is still needed and possible bug in the original patch?

Let me fix in u-boot

Regards

Udit

Quoted 1 line