arm64: dts: ti: k3-j7200-common-proc-board fixes
Subsystems (2)
v2 cover arm64: dts: ti: k3-j7200-common-proc-board fixes
This patch series fixes the pin mux configuration and enable wkup_i2c0 at board level.
Changes since v1:
https://lore.kernel.org/all/[email protected]/
Pin mux:
- Fixed commit message and author
wkup_i2c:
- Removed Fixes tag in commit message
- Moved wkup_i2c in som instead of common board
- Added eeprom as child device
Keerthy (1):
arm64: dts: ti: k3-j7200: Fix physical address of pin
Udit Kumar (1):
arm64: dts: ti: k3-j7200-som: Enable I2C
.../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 8 ++++++ 2 files changed, 22 insertions(+), 14 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/2 arm64: dts: ti: k3-j7200: Fix physical address of pin
From: Keerthy <[email protected]>
wkup_pmx splits into multiple regions. Like
wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
wkup_pmx1 -> 2 pins (WKUP_PADCONFIG 14 - 15)
wkup_pmx2 -> 59 pins (WKUP_PADCONFIG 26 - 84)
wkup_pmx3 -> 8 pins (WKUP_PADCONFIG 93 - 100)With this split, pin offset needs to be adjusted to match with new pmx for all pins above wkup_pmx0.
Example a pin under wkup_pmx1 should start from 0 instead of old offset(0x38 WKUP_PADCONFIG 14 offset)
J7200 Datasheet (Table 6-106, Section 6.4 Pin Multiplexing) :
https://www.ti.com/lit/ds/symlink/dra821u.pdf
--- .../dts/ti/k3-j7200-common-proc-board.dts | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-)
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts +14 -14
@@ -83,25 +83,25 @@ vdd_sd_dv: gpio-regulator-TLV71033 { &wkup_pmx2 { mcu_cpsw_pins_default: mcu-cpsw-pins-default { pinctrl-single,pins = < - J721E_WKUP_IOPAD(0x0068, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ - J721E_WKUP_IOPAD(0x006c, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ - J721E_WKUP_IOPAD(0x0070, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ - J721E_WKUP_IOPAD(0x0074, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ - J721E_WKUP_IOPAD(0x0078, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ - J721E_WKUP_IOPAD(0x007c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ - J721E_WKUP_IOPAD(0x0088, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ - J721E_WKUP_IOPAD(0x008c, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ - J721E_WKUP_IOPAD(0x0090, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ - J721E_WKUP_IOPAD(0x0094, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ - J721E_WKUP_IOPAD(0x0080, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ - J721E_WKUP_IOPAD(0x0084, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ + J721E_WKUP_IOPAD(0x0000, PIN_OUTPUT, 0) /* MCU_RGMII1_TX_CTL */ + J721E_WKUP_IOPAD(0x0004, PIN_INPUT, 0) /* MCU_RGMII1_RX_CTL */ + J721E_WKUP_IOPAD(0x0008, PIN_OUTPUT, 0) /* MCU_RGMII1_TD3 */ + J721E_WKUP_IOPAD(0x000c, PIN_OUTPUT, 0) /* MCU_RGMII1_TD2 */ + J721E_WKUP_IOPAD(0x0010, PIN_OUTPUT, 0) /* MCU_RGMII1_TD1 */ + J721E_WKUP_IOPAD(0x0014, PIN_OUTPUT, 0) /* MCU_RGMII1_TD0 */ + J721E_WKUP_IOPAD(0x0020, PIN_INPUT, 0) /* MCU_RGMII1_RD3 */ + J721E_WKUP_IOPAD(0x0024, PIN_INPUT, 0) /* MCU_RGMII1_RD2 */ + J721E_WKUP_IOPAD(0x0028, PIN_INPUT, 0) /* MCU_RGMII1_RD1 */ + J721E_WKUP_IOPAD(0x002c, PIN_INPUT, 0) /* MCU_RGMII1_RD0 */ + J721E_WKUP_IOPAD(0x0018, PIN_OUTPUT, 0) /* MCU_RGMII1_TXC */ + J721E_WKUP_IOPAD(0x001c, PIN_INPUT, 0) /* MCU_RGMII1_RXC */ >; }; mcu_mdio_pins_default: mcu-mdio1-pins-default { pinctrl-single,pins = < - J721E_WKUP_IOPAD(0x009c, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ - J721E_WKUP_IOPAD(0x0098, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ + J721E_WKUP_IOPAD(0x0034, PIN_OUTPUT, 0) /* (L1) MCU_MDIO0_MDC */ + J721E_WKUP_IOPAD(0x0030, PIN_INPUT, 0) /* (L4) MCU_MDIO0_MDIO */ >; }; };
Signature · 1 line
2.34.1
PATCH v2 2/2 arm64: dts: ti: k3-j7200-som: Enable I2C
In reply to Udit KumarThis patch enables wkup_i2c0 node in board dts file. and underneath eeprom CAV24C256WE.
J7200 User Guide (Section 4.3, Table 4-2) :
https://www.ti.com/lit/ug/spruiw7a/spruiw7a.pdf
--- arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi +8 -0
@@ -214,6 +214,14 @@ exp_som: gpio@21 { }; }; +&wkup_i2c0 { + status = "okay"; + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; +}; + &ospi0 { pinctrl-names = "default"; pinctrl-0 = <&mcu_fss0_ospi0_pins_default>;
Signature · 1 line
2.34.1
Nishanth Menon
maintainerRe: [PATCH v2 2/2] arm64: dts: ti: k3-j7200-som: Enable I2C
Quoted 16 lines · Udit Kumar
This patch enables
wkup_i2c0node in board dts file. and underneath eeprom CAV24C256WE.J7200 User Guide (Section 4.3, Table 4-2) :
https://www.ti.com/lit/ug/spruiw7a/spruiw7a.pdfSigned-off-by Udit Kumar <[email protected]>--- arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi +0
-0
arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi exp_som: gpio@21 { · line 223
Quoted 10 lines
arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi +7
-0@@ -214,6 +214,14 @@ exp_som: gpio@21 { }; }; +&wkup_i2c0 { + status = "okay"; + eeprom@50 { + compatible = "atmel,24c256"; + reg = <0x50>; + }; +};
pinmux?
speed ?
Quoted 7 lines
arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi +1
-0+ &ospi0 { pinctrl-names = "default"; pinctrl-0 = <&mcu_fss0_ospi0_pins_default>;Signature · 1 line
2.34.1
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v2 2/2] arm64: dts: ti: k3-j7200-som: Enable I2C
Quoted 4 lines · Nishanth Menon
Quoted 1 line · Udit Kumar
[..]
pinmux?
speed ?
I misunderstood your comments in v1.
will fix in v3
Thanks for review