Skip to contentSkip to conversation

Add MAX14526 MUIC driver

PATCH In review Svyatoslav Ryhel 2 participants 5 messages Apr 25, 2023 – May 3, 2023 External connector subsystem (extcon)

lore
Share & tools
lore
#0 lore raw

v4 cover Add MAX14526 MUIC driver

MAX14526 MUIC is used by LG P880/P895 which are currently in the process of merging.

MAX14526 is a powerful extcon device which has the ability to accurately determine plugged devices. In this implementation muic can be configured to represent 3 modes: CP-USB/UART and AP-USB. Unfortunately AP-UART was disabled on P880/P895. Additionally the driver configures some stuff required by the charger.

Extcon class has empty platform struct and ops, all configuration is performed in the probe. Filling of struct and ops is welcomed.

---
Changes from v3:
- fix typo in commit title
- added reviewed-by

Changes from v2:
- created a new simple extcon uclass

Changes from v1:
- used log_* instead of printf
- log messages made simpler
---

Svyatoslav Ryhel (3):
dm: extcon: add an uclass for extcon
test: Add tests for the extcon
extcon: add MAX14526 MUIC support

 arch/sandbox/dts/test.dts        |   4 +
 drivers/Kconfig                  |   2 +
 drivers/Makefile                 |   1 +
 drivers/extcon/Kconfig           |  31 +++++++
 drivers/extcon/Makefile          |   7 ++
 drivers/extcon/extcon-max14526.c | 151 +++++++++++++++++++++++++++++++
 drivers/extcon/extcon-sandbox.c  |  17 ++++
 drivers/extcon/extcon-uclass.c   |  16 ++++
 include/dm/uclass-id.h           |   1 +
 include/extcon.h                 |  19 ++++
 test/dm/Makefile                 |   1 +
 test/dm/extcon.c                 |  21 +++++
 12 files changed, 271 insertions(+)
 create mode 100644 drivers/extcon/Kconfig
 create mode 100644 drivers/extcon/Makefile
 create mode 100644 drivers/extcon/extcon-max14526.c
 create mode 100644 drivers/extcon/extcon-sandbox.c
 create mode 100644 drivers/extcon/extcon-uclass.c
 create mode 100644 include/extcon.h
 create mode 100644 test/dm/extcon.c
Signature · 1 line
2.39.2
#1 lore raw

PATCH v4 1/3 dm: extcon: add an uclass for extcon

Add a new simple uclass for extcon. Currently all setup is done in the probe. Uclass struct and ops are empty for now.

---
 drivers/Kconfig                |  2 ++
 drivers/Makefile               |  1 +
 drivers/extcon/Kconfig         | 15 +++++++++++++++
 drivers/extcon/Makefile        |  5 +++++
 drivers/extcon/extcon-uclass.c | 16 ++++++++++++++++
 include/dm/uclass-id.h         |  1 +
 include/extcon.h               | 19 +++++++++++++++++++
 7 files changed, 59 insertions(+)
 create mode 100644 drivers/extcon/Kconfig
 create mode 100644 drivers/extcon/Makefile
 create mode 100644 drivers/extcon/extcon-uclass.c
 create mode 100644 include/extcon.h
drivers/Kconfig +2 -0
index 9101e538b0..75937fbb6d 100644
@@ -36,6 +36,8 @@ source "drivers/dfu/Kconfig"
 
 source "drivers/dma/Kconfig"
 
+source "drivers/extcon/Kconfig"
+
 source "drivers/fastboot/Kconfig"
 
 source "drivers/firmware/Kconfig"
drivers/Makefile +1 -0
index 58be410135..ed1e71c4d6 100644
@@ -9,6 +9,7 @@ obj-$(CONFIG_$(SPL_TPL_)DM) += core/
 obj-$(CONFIG_$(SPL_TPL_)DMA) += dma/
 obj-$(CONFIG_$(SPL_TPL_)DMA_LEGACY) += dma/
 obj-$(CONFIG_$(SPL_TPL_)DFU) += dfu/
+obj-$(CONFIG_$(SPL_TPL_)EXTCON) += extcon/
 obj-$(CONFIG_$(SPL_TPL_)GPIO) += gpio/
 obj-$(CONFIG_$(SPL_TPL_)DRIVERS_MISC) += misc/
 obj-$(CONFIG_$(SPL_TPL_)SYSRESET) += sysreset/
drivers/extcon/Kconfig new file +15 -0
new file mode 100644
index 0000000000..8a50250d21
@@ -0,0 +1,15 @@
+menu "Extcon Support"
+
+config EXTCON
+	bool "External Connector Class (extcon) support"
+	depends on DM
+	help
+	  Say Y here to enable external connector class (extcon) support.
+	  This allows monitoring external connectors and supports external
+	  connectors with multiple states; i.e., an extcon that may have
+	  multiple cables attached. For example, an external connector
+	  of a device may be used to connect an HDMI cable and a AC adaptor,
+	  and to host USB ports. Many of 30-pin connectors including PDMI
+	  are also good examples.
+
+endmenu
drivers/extcon/Makefile new file +5 -0
new file mode 100644
index 0000000000..2510e91c07
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2023 Svyatoslav Ryhel <[email protected]>
+
+obj-$(CONFIG_EXTCON) += extcon-uclass.o
drivers/extcon/extcon-uclass.c new file +16 -0
new file mode 100644
index 0000000000..9dd22b5762
@@ -0,0 +1,16 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2023 Svyatoslav Ryhel <[email protected]>
+ */
+
+#define LOG_CATEGORY UCLASS_EXTCON
+
+#include <common.h>
+#include <extcon.h>
+#include <dm.h>
+
+UCLASS_DRIVER(extcon) = {
+	.id			= UCLASS_EXTCON,
+	.name			= "extcon",
+	.per_device_plat_auto	= sizeof(struct extcon_uc_plat),
+};
include/dm/uclass-id.h +1 -0
index 576237b954..94ab46c5ba 100644
@@ -56,6 +56,7 @@ enum uclass_id {
 	UCLASS_EFI_MEDIA,	/* Devices provided by UEFI firmware */
 	UCLASS_ETH,		/* Ethernet device */
 	UCLASS_ETH_PHY,		/* Ethernet PHY device */
+	UCLASS_EXTCON,		/* External Connector Class */
 	UCLASS_FIRMWARE,	/* Firmware */
 	UCLASS_FPGA,		/* FPGA device */
 	UCLASS_FUZZING_ENGINE,	/* Fuzzing engine */
include/extcon.h new file +19 -0
new file mode 100644
index 0000000000..d060f5a3c1
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2023 Svyatoslav Ryhel <[email protected]>
+ */
+
+#ifndef __EXTCON_H
+#define __EXTCON_H
+
+struct udevice;
+
+/**
+ * struct extcon_uc_plat - Platform data the uclass stores about each device
+ *
+ * To be filled
+ */
+struct extcon_uc_plat {
+};
+
+#endif
Signature · 1 line
2.39.2
#3 lore raw

PATCH v4 2/3 test: Add tests for the extcon

In reply to Svyatoslav Ryhel

Provide tests to the simple extcon device.

---
 arch/sandbox/dts/test.dts       |  4 ++++
 drivers/extcon/Kconfig          |  7 +++++++
 drivers/extcon/Makefile         |  1 +
 drivers/extcon/extcon-sandbox.c | 17 +++++++++++++++++
 test/dm/Makefile                |  1 +
 test/dm/extcon.c                | 21 +++++++++++++++++++++
 6 files changed, 51 insertions(+)
 create mode 100644 drivers/extcon/extcon-sandbox.c
 create mode 100644 test/dm/extcon.c
arch/sandbox/dts/test.dts +4 -0
index 7c1ee71cb7..731b48459d 100644
@@ -1802,6 +1802,10 @@
 		compatible = "u-boot,fwu-mdata-gpt";
 		fwu-mdata-store = <&mmc0>;
 	};
+
+	extcon {
+		compatible = "sandbox,extcon";
+	};
 };
 
 #include "sandbox_pmic.dtsi"
drivers/extcon/Kconfig +7 -0
index 8a50250d21..6fd3d2b97b 100644
@@ -12,4 +12,11 @@ config EXTCON
 	  and to host USB ports. Many of 30-pin connectors including PDMI
 	  are also good examples.
 
+config EXTCON_SANDBOX
+	bool "Sandbox extcon"
+	depends on EXTCON
+	help
+	  Enable extcon support for sandbox. This is an emulation of a real
+	  extcon. Currectly all configuration is done in the probe.
+
 endmenu
drivers/extcon/Makefile +1 -0
index 2510e91c07..c4223d97d1 100644
@@ -3,3 +3,4 @@
 # Copyright (C) 2023 Svyatoslav Ryhel <[email protected]>
 
 obj-$(CONFIG_EXTCON) += extcon-uclass.o
+obj-$(CONFIG_EXTCON_SANDBOX) += extcon-sandbox.o
drivers/extcon/extcon-sandbox.c new file +17 -0
new file mode 100644
index 0000000000..ab6a6c1cfd
@@ -0,0 +1,17 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (c) 2022 Svyatoslav Ryhel <[email protected]>
+ */
+
+#include <dm.h>
+
+static const struct udevice_id sandbox_extcon_ids[] = {
+	{ .compatible = "sandbox,extcon" },
+	{ /* sentinel */ }
+};
+
+U_BOOT_DRIVER(extcon_sandbox) = {
+	.name		= "extcon_sandbox",
+	.id		= UCLASS_EXTCON,
+	.of_match	= sandbox_extcon_ids,
+};
test/dm/Makefile +1 -0
index e15bdbf04b..5ada659974 100644
@@ -44,6 +44,7 @@ obj-$(CONFIG_DM_DSA) += dsa.o
 obj-$(CONFIG_ECDSA_VERIFY) += ecdsa.o
 obj-$(CONFIG_EFI_MEDIA_SANDBOX) += efi_media.o
 obj-$(CONFIG_DM_ETH) += eth.o
+obj-$(CONFIG_EXTCON) += extcon.o
 ifneq ($(CONFIG_EFI_PARTITION),)
 obj-$(CONFIG_FASTBOOT_FLASH_MMC) += fastboot.o
 endif
test/dm/extcon.c new file +21 -0
new file mode 100644
index 0000000000..6a4e22bfdc
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2023 Svyatoslav Ryhel <[email protected]>
+ */
+
+#include <dm.h>
+#include <dm/test.h>
+#include <extcon.h>
+#include <test/test.h>
+#include <test/ut.h>
+
+static int dm_test_extcon(struct unit_test_state *uts)
+{
+	struct udevice *dev;
+
+	ut_assertok(uclass_get_device_by_name(UCLASS_EXTCON, "extcon", &dev));
+
+	return 0;
+}
+
+DM_TEST(dm_test_extcon, UT_TESTF_SCAN_FDT);
Signature · 1 line
2.39.2
#4 lore raw

PATCH v4 3/3 extcon: add MAX14526 MUIC support

In reply to Svyatoslav Ryhel

MAX14526 is a powerful extcon chip which allows detection of various plugs like usb, mhl, uart, headset etc. This version of driver implements support of AP-usb and CP-usb/uart paths.

---
 drivers/extcon/Kconfig           |   9 ++
 drivers/extcon/Makefile          |   1 +
 drivers/extcon/extcon-max14526.c | 151 +++++++++++++++++++++++++++++++
 3 files changed, 161 insertions(+)
 create mode 100644 drivers/extcon/extcon-max14526.c
drivers/extcon/Kconfig +9 -0
index 6fd3d2b97b..fbb73354aa 100644
@@ -19,4 +19,13 @@ config EXTCON_SANDBOX
 	  Enable extcon support for sandbox. This is an emulation of a real
 	  extcon. Currectly all configuration is done in the probe.
 
+config EXTCON_MAX14526
+	bool "Maxim MAX14526 EXTCON Support"
+	depends on DM_I2C
+	depends on EXTCON
+	help
+	  If you say yes here you get support for the MUIC device of
+	  Maxim MAX14526. The MAX14526 MUIC is a USB port accessory
+	  detector and switch.
+
 endmenu
drivers/extcon/Makefile +1 -0
index c4223d97d1..3309f2aac2 100644
@@ -4,3 +4,4 @@
 
 obj-$(CONFIG_EXTCON) += extcon-uclass.o
 obj-$(CONFIG_EXTCON_SANDBOX) += extcon-sandbox.o
+obj-$(CONFIG_EXTCON_MAX14526) += extcon-max14526.o
drivers/extcon/extcon-max14526.c new file +151 -0

151 lines not on this page · raw message

Signature · 1 line
2.39.2