mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static
Subsystems (2)
PATCH 1/1 mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static
smatch reportsmm/page_alloc.c:247:5: warning: symbol
'sysctl_lowmem_reserve_ratio' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>
--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
@@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order,* TBD: should special case ZONE_DMA32 machines here - in those we normally * don't need any ZONE_NORMAL reservation */ -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES ] = { +static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES ] = { #ifdef CONFIG_ZONE_DMA [ZONE_DMA ] =256 , #endif
Signature · 1 line
2.27.0
Quoted 11 lines · Tom Rix
smatch reports
mm/page_alloc.c:247:5: warning: symbol
'sysctl_lowmem_reserve_ratio' was not declared. Should it be static?This variable is only used in its defining file, so it should be static
Signed-off-by Tom Rix <[email protected]>--- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Missing this one, Reviewed-by: Kefeng Wang <[email protected]>
Quoted 13 lines
mm/page_alloc.c +1
-1@@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order,* TBD: should special case ZONE_DMA32 machines here - in those we normally * don't need any ZONE_NORMAL reservation */ -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES ] = { +static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES ] = { #ifdef CONFIG_ZONE_DMA [ZONE_DMA ] =256 , #endif