Skip to contentSkip to conversation

mm-page_alloc-set-sysctl_lowmem_reserve_ratio-storage-class-specifier-to-static.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Jun 9, 2023

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static
has been removed from the -mm tree. Its filename was
mm-page_alloc-set-sysctl_lowmem_reserve_ratio-storage-class-specifier-to-static.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Tom Rix <[email protected]>
Subject: mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static
Date: Thu, 18 May 2023 10:11:19 -0400

smatch reports
mm/page_alloc.c:247:5: warning: symbol
'sysctl_lowmem_reserve_ratio' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static

---

 mm/page_alloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c renamed from mm/page_alloc.c~mm-page_alloc-set-sysctl_lowmem_reserve_ratio-storage-class-specifier-to-static +1 -1
@@ -244,7 +244,7 @@ static void __free_pages_ok(struct page
  * TBD: should special case ZONE_DMA32 machines here - in those we normally
  * don't need any ZONE_NORMAL reservation
  */
-int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
+static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = {
 #ifdef CONFIG_ZONE_DMA
 	[ZONE_DMA] = 256,
 #endif

_

Patches currently in -mm which might be from [email protected] are

watchdog-delete-old-declarations-for-watchdog_softhardlockup_user_enabled-make-static.patch