spi: soft_spi: Support the recommended soft spi properties
PATCH 1/2 spi: soft_spi: Support the recommended soft spi properties
From: Fabio Estevam <[email protected]>
According to Documentation/devicetree/bindings/spi/spi-gpio.yaml from Linux, the recommended spio-gpio properties are:
sck-gpios, miso-gpios and mosi-gpios.
gpio-sck, gpio-mosi and gpio-miso are considered deprecated.
Currently, U-Boot only supports the deprecated properties.
Allow the soft_spi driver to support both the new and old properties.
--- drivers/spi/soft_spi.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-)
drivers/spi/soft_spi.c +17 -4
@@ -248,19 +248,32 @@ static int soft_spi_probe(struct udevice *dev) cs_flags = (slave && slave->mode &SPI_CS_HIGH ) ?0 :GPIOD_ACTIVE_LOW ; clk_flags = (slave && slave->mode &SPI_CPOL ) ?GPIOD_ACTIVE_LOW :0 ; -if (gpio_request_by_name (dev,"cs-gpios" ,0 , &plat->cs, -GPIOD_IS_OUT | cs_flags) || -gpio_request_by_name (dev,"gpio-sck" ,0 , &plat->sclk, -GPIOD_IS_OUT | clk_flags)) + ret =gpio_request_by_name (dev,"cs-gpios" ,0 , &plat->cs, +GPIOD_IS_OUT | cs_flags); +if (ret) +return -EINVAL ; + + ret =gpio_request_by_name (dev,"gpio-sck" ,0 , &plat->sclk, +GPIOD_IS_OUT | clk_flags); +if (ret) + ret =gpio_request_by_name (dev,"sck-gpios" ,0 , &plat->sclk, +GPIOD_IS_OUT | clk_flags); +if (ret)return -EINVAL ; ret =gpio_request_by_name (dev,"gpio-mosi" ,0 , &plat->mosi,GPIOD_IS_OUT |GPIOD_IS_OUT_ACTIVE ); +if (ret) + ret =gpio_request_by_name (dev,"mosi-gpios" ,0 , &plat->mosi, +GPIOD_IS_OUT |GPIOD_IS_OUT_ACTIVE );if (ret) plat->flags |=SPI_MASTER_NO_TX ; ret =gpio_request_by_name (dev,"gpio-miso" ,0 , &plat->miso,GPIOD_IS_IN ); +if (ret) + ret =gpio_request_by_name (dev,"gpio-miso" ,0 , &plat->miso, +GPIOD_IS_IN );if (ret) plat->flags |=SPI_MASTER_NO_RX ;
Signature · 1 line
2.34.1
PATCH 2/2 doc: bindings: soft-spi: Remove the usage of deprecated properties
From: Fabio Estevam <[email protected]>
According to Documentation/devicetree/bindings/spi/spi-gpio.yaml from Linux, the recommended spio-gpio properties are:
sck-gpios, miso-gpios and mosi-gpios.
gpio-sck, gpio-mosi and gpio-miso are considered deprecated.
Update the bindings to suggest the recommeded properties.
--- doc/device-tree-bindings/spi/soft-spi.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
doc/device-tree-bindings/spi/soft-spi.txt +6 -6
@@ -9,10 +9,10 @@ The soft SPI node requires the following properties: Mandatory properties: compatible: "spi-gpio" cs-gpios: GPIOs to use for SPI chip select (output) -gpio-sck: GPIO to use for SPI clock (output) +sck-gpios: GPIO to use for SPI clock (output) And at least one of: -gpio-mosi: GPIO to use for SPI MOSI line (output) -gpio-miso: GPIO to use for SPI MISO line (input) +mosi-gpios: GPIO to use for SPI MOSI line (output) +miso-gpios: GPIO to use for SPI MISO line (input) Optional propertie: spi-delay-us: Number of microseconds of delay between each CS transition
@@ -27,9 +27,9 @@ Example: soft-spi { compatible = "spi-gpio"; cs-gpios = <&gpio 235 0>; /* Y43 */ - gpio-sck = <&gpio 225 0>; /* Y31 */ - gpio-mosi = <&gpio 227 0>; /* Y33 */ - gpio-miso = <&gpio 224 0>; /* Y30 */ + sck-gpios = <&gpio 225 0>; /* Y31 */ + mosi-gpios = <&gpio 227 0>; /* Y33 */ + miso-gpios = <&gpio 224 0>; /* Y30 */ spi-delay-us = <1>; #address-cells = <1>; #size-cells = <0>;
Signature · 1 line
2.34.1
Re: [PATCH 2/2] doc: bindings: soft-spi: Remove the usage of deprecated properties
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
Documentation/devicetree/bindings/spi/spi-gpio.yamlfrom Linux, the recommended spio-gpio properties are:
Quoted 8 lines
sck-gpios, miso-gpios and mosi-gpios.
gpio-sck, gpio-mosi and gpio-miso are considered deprecated.
Update the bindings to suggest the recommeded properties.
Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-spi/master
Quoted 8 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
According to
Documentation/devicetree/bindings/spi/spi-gpio.yamlfrom Linux, the recommended spio-gpio properties are:sck-gpios, miso-gpios and mosi-gpios.
Quoted 8 lines
gpio-sck, gpio-mosi and gpio-miso are considered deprecated.
Currently, U-Boot only supports the deprecated properties.
Allow the
soft_spidriver to support both the new and old properties.Signed-off-by Fabio Estevam <[email protected]>---
Applied to u-boot-spi/master