Skip to contentSkip to conversation

Bluetooth: btqca: use le32_to_cpu for ver.soc_id

PATCH Applied Min-Hua Chen 3 participants 3 messages May 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Bluetooth: btqca: use le32_to_cpu for ver.soc_id

Use le32_to_cpu for ver.soc_id to fix the following sparse warning.

drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted __le32 degrades to integer

---

Change since v1:
fix the line length > 80 error reported by bluez.test.bot

---
 drivers/bluetooth/btqca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btqca.c +1 -1
index fd0941fe8608..e7e58a956d15 100644
@@ -637,7 +637,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
 		snprintf(config.fwname, sizeof(config.fwname),
 			 "qca/%s", firmware_name);
 	else if (qca_is_wcn399x(soc_type)) {
-		if (ver.soc_id == QCA_WCN3991_SOC_ID) {
+		if (le32_to_cpu(ver.soc_id) == QCA_WCN3991_SOC_ID) {
 			snprintf(config.fwname, sizeof(config.fwname),
 				 "qca/crnv%02xu.bin", rom_ver);
 		} else {
Signature · 1 line
2.34.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=749213

---Test result---

Test Summary:

CheckPatch                    PASS      0.68 seconds
GitLint                       PASS      0.34 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      34.26 seconds
CheckAllWarning               PASS      38.13 seconds
CheckSparse                   PASS      42.86 seconds
CheckSmatch                   PASS      116.41 seconds
BuildKernel32                 PASS      32.57 seconds
TestRunnerSetup               PASS      467.00 seconds
TestRunner_l2cap-tester       PASS      16.88 seconds
TestRunner_iso-tester         PASS      20.97 seconds
TestRunner_bnep-tester        PASS      5.53 seconds
TestRunner_mgmt-tester        PASS      114.93 seconds
TestRunner_rfcomm-tester      PASS      8.66 seconds
TestRunner_sco-tester         PASS      8.07 seconds
TestRunner_ioctl-tester       PASS      9.39 seconds
TestRunner_mesh-tester        PASS      6.96 seconds
TestRunner_smp-tester         PASS      8.03 seconds
TestRunner_userchan-tester    PASS      5.76 seconds
IncrementalBuild              PASS      29.92 seconds

---
Regards,
Linux Bluetooth

#2 lore raw
In reply to Min-Hua Chen
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 9 lines · On Fri, 19 May 2023 18:43:23 +0800 you wrote:

Use le32_to_cpu for ver.soc_id to fix the following sparse warning.

drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted __le32 degrades to integer

[...]

Here is the summary with links:
- [v2] Bluetooth: btqca: use le32_to_cpu for ver.soc_id

    https://git.kernel.org/bluetooth/bluetooth-next/c/0f1e103dc579

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html