Skip to contentSkip to conversation

Bluetooth: btqca: use le32_to_cpu for ver.soc_id

PATCH Superseded Min-Hua Chen 2 participants 2 messages May 19, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: btqca: use le32_to_cpu for ver.soc_id

Use le32_to_cpu for ver.soc_id to fix the following sparse warning.

drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted __le32 degrades to integer

---
 drivers/bluetooth/btqca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bluetooth/btqca.c +1 -1
index fd0941fe8608..e7e58a956d15 100644
@@ -637,7 +637,7 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
 		snprintf(config.fwname, sizeof(config.fwname),
 			 "qca/%s", firmware_name);
 	else if (qca_is_wcn399x(soc_type)) {
-		if (ver.soc_id == QCA_WCN3991_SOC_ID) {
+		if (le32_to_cpu(ver.soc_id) == QCA_WCN3991_SOC_ID) {
 			snprintf(config.fwname, sizeof(config.fwname),
 				 "qca/crnv%02xu.bin", rom_ver);
 		} else {
Signature · 1 line
2.34.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=749075

---Test result---

Test Summary:

CheckPatch                    PASS      0.73 seconds
GitLint                       FAIL      0.58 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      38.18 seconds
CheckAllWarning               PASS      41.17 seconds
CheckSparse                   PASS      46.66 seconds
CheckSmatch                   PASS      126.18 seconds
BuildKernel32                 PASS      36.45 seconds
TestRunnerSetup               PASS      526.26 seconds
TestRunner_l2cap-tester       PASS      19.18 seconds
TestRunner_iso-tester         PASS      24.81 seconds
TestRunner_bnep-tester        PASS      6.70 seconds
TestRunner_mgmt-tester        PASS      132.74 seconds
TestRunner_rfcomm-tester      PASS      10.34 seconds
TestRunner_sco-tester         PASS      9.58 seconds
TestRunner_ioctl-tester       PASS      11.34 seconds
TestRunner_mesh-tester        PASS      8.23 seconds
TestRunner_smp-tester         PASS      9.25 seconds
TestRunner_userchan-tester    PASS      6.77 seconds
IncrementalBuild              PASS      35.08 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
Bluetooth: btqca: use le32_to_cpu for ver.soc_id

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
6: B1 Line exceeds max length (88>80): "drivers/bluetooth/btqca.c:640:24: sparse: warning: restricted __le32 degrades to integer"

---
Regards,
Linux Bluetooth