Skip to contentSkip to conversation

dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

PATCH Superseded Tim Harvey 4 participants 8 messages May 22, 2023 – Jun 12, 2023

Subsystems (3)
lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH v2 1/4 dt-bindings: mfd: gateworks-gsc: remove unnecessary fan-controller nodes

Remove the unnecessary #address-cells and #size-cells nodes from the fan-controller. These are not needed as the fan controller does not have any children.

---
v2:
- udpated commit log to explain why the nodes are unnessesary
- added Krzysztof's rb tag
- added Connor's ab tag

---
 .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
 1 file changed, 10 deletions(-)
Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml +0 -10
index acb9c54942d9..dc379f3ebf24 100644
@@ -122,12 +122,6 @@ patternProperties:
       compatible:
         const: gw,gsc-fan
 
-      "#address-cells":
-        const: 1
-
-      "#size-cells":
-        const: 0
-
       reg:
         description: The fan controller base address
         maxItems: 1
@@ -135,8 +129,6 @@ patternProperties:
     required:
       - compatible
       - reg
-      - "#address-cells"
-      - "#size-cells"
 
 required:
   - compatible
@@ -194,8 +186,6 @@ examples:
             };
 
             fan-controller@2c {
-                #address-cells = <1>;
-                #size-cells = <0>;
                 compatible = "gw,gsc-fan";
                 reg = <0x2c>;
             };
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#1 lore raw

PATCH v2 2/4 arm64: dts: imx8mm-venice-gw700x: remove invalid props from fan-controller

Remove the invalid #address-cells and #size-cells nodes from the fan-controller.

---
v2: update commit log

---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi +0 -2
index 9e7d38872157..72cf250d9b4f 100644
@@ -234,8 +234,6 @@ channel@a2 {
 		};
 
 		fan-controller@0 {
-			#address-cells = <1>;
-			#size-cells = <0>;
 			compatible = "gw,gsc-fan";
 			reg = <0x0a>;
 		};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

Re: [PATCH v2 2/4] arm64: dts: imx8mm-venice-gw700x: remove invalid props from fan-controller

Quoted 4 lines · Tim Harvey

Remove the invalid #address-cells and #size-cells nodes from the fan-controller.

Applied 2/4, 3/4 and 4/4, thanks!

author
#3 lore raw

PATCH v2 3/4 ARM: dts: imx6qdl-gw54xx: remove invalid nodes from fan-controller

In reply to Tim Harvey

Remove the invalid #address-cells and #size-cells nodes from the fan-controller.

---
v2: new patch

---
 arch/arm/boot/dts/imx6qdl-gw54xx.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/imx6qdl-gw54xx.dtsi +0 -2
index 4e20cb97058e..6c487d40a3b7 100644
@@ -349,8 +349,6 @@ channel@26 {
 
 		fan-controller@2c {
 			compatible = "gw,gsc-fan";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			reg = <0x2c>;
 		};
 	};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#4 lore raw

PATCH v2 4/4 ARM: dts: imx6qdl-gw5912: remove invalid nodes from fan-controller

In reply to Tim Harvey

Remove the invalid #address-cells and #size-cells nodes from the fan-controller.

---
v2: new patch

---
 arch/arm/boot/dts/imx6qdl-gw5912.dtsi | 2 --
 1 file changed, 2 deletions(-)
arch/arm/boot/dts/imx6qdl-gw5912.dtsi +0 -2
index 40e235e315cc..de5983cf7810 100644
@@ -243,8 +243,6 @@ channel@23 {
 
 		fan-controller@a {
 			compatible = "gw,gsc-fan";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			reg = <0x0a>;
 		};
 	};
Signature · 7 lines
2.25.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#5 lore raw
In reply to Tim Harvey
Quoted 7 lines · Tim Harvey

Remove the unnecessary #address-cells and #size-cells nodes from the fan-controller. These are not needed as the fan controller does not have any children.

Quoted 8 lines

---
v2:
- udpated commit log to explain why the nodes are unnessesary
- added Krzysztof's rb tag
- added Connor's ab tag

---
 .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
 1 file changed, 10 deletions(-)

This is not going to get applied if you don't send it to Lee.

Quoted 39 lines
Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml +0 -10
index acb9c54942d9..dc379f3ebf24 100644
@@ -122,12 +122,6 @@ patternProperties:
       compatible:
         const: gw,gsc-fan
 
-      "#address-cells":
-        const: 1
-
-      "#size-cells":
-        const: 0
-
       reg:
         description: The fan controller base address
         maxItems: 1
@@ -135,8 +129,6 @@ patternProperties:
     required:
       - compatible
       - reg
-      - "#address-cells"
-      - "#size-cells"
 
 required:
   - compatible
@@ -194,8 +186,6 @@ examples:
             };
 
             fan-controller@2c {
-                #address-cells = <1>;
-                #size-cells = <0>;
                 compatible = "gw,gsc-fan";
                 reg = <0x2c>;
             };
Signature · 1 line
2.25.1
author
#6 lore raw
Quoted 18 lines · Rob Herring
Quoted 7 lines · Tim Harvey

Remove the unnecessary #address-cells and #size-cells nodes from the fan-controller. These are not needed as the fan controller does not have any children.

Quoted 8 lines

---
v2:
- udpated commit log to explain why the nodes are unnessesary
- added Krzysztof's rb tag
- added Connor's ab tag

---
 .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
 1 file changed, 10 deletions(-)
Quoted 1 line

This is not going to get applied if you don't send it to Lee.

Lee,

Sorry, I missed adding you to this thread. Can you pick it up or do you need me to re-send to the list and you?

Best Regards,

Tim

Quoted 40 lines
Quoted 40 lines
Documentation/devicetree/bindings/mfd/gateworks-gsc.yaml +0 -11
index acb9c54942d9..dc379f3ebf24 100644
@@ -122,12 +122,6 @@ patternProperties:
       compatible:
         const: gw,gsc-fan
 
-      "#address-cells":
-        const: 1
-
-      "#size-cells":
-        const: 0
-
       reg:
         description: The fan controller base address
         maxItems: 1
@@ -135,8 +129,6 @@ patternProperties:
     required:
       - compatible
       - reg
-      - "#address-cells"
-      - "#size-cells"
 
 required:
   - compatible
@@ -194,8 +186,6 @@ examples:
             };
 
             fan-controller@2c {
-                #address-cells = <1>;
-                #size-cells = <0>;
                 compatible = "gw,gsc-fan";
                 reg = <0x2c>;
             };
--

2.25.1

maintainer
#7 lore raw
Quoted 19 lines · Tim Harvey
Quoted 18 lines · Rob Herring
Quoted 15 lines · Tim Harvey

Remove the unnecessary #address-cells and #size-cells nodes from the fan-controller. These are not needed as the fan controller does not have any children.

---
v2:
- udpated commit log to explain why the nodes are unnessesary
- added Krzysztof's rb tag
- added Connor's ab tag

---
 .../devicetree/bindings/mfd/gateworks-gsc.yaml         | 10 ----------
 1 file changed, 10 deletions(-)
Quoted 6 lines
Quoted 1 line

This is not going to get applied if you don't send it to Lee.

Lee,

Sorry, I missed adding you to this thread. Can you pick it up or do you need me to re-send to the list and you?

I need you to resend it please.

Signature · 1 line
Lee Jones [李琼斯]