please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line)
Subsystems (2)
Hi,
please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).
Because 'btrfs_assertfail' become macro(inline), we should drop it from objtools.
tools/objtool/check.c +0 -1
@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,"__reiserfs_panic" ,"__stack_chk_fail" ,"__ubsan_handle_builtin_unreachable" , -"btrfs_assertfail" ,"cpu_bringup_and_idle" ,"cpu_startup_entry" , "do_exit",
Best Regards
Wang Yugui ([email protected])
2023/05/28
Quoted 11 lines · Wang Yugui
Hi,
please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).
Because '
btrfs_assertfail' become macro(inline), we should drop it from objtools.tools/objtool/check.c +0
-0
tools/objtool/check.c static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · line 173
Quoted 4 lines
tools/objtool/check.c +0
-1@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,"__reiserfs_panic" ,"__stack_chk_fail" , "__ubsan_handle_builtin_unreachable", - "btrfs_assertfail",
If this is not in objtool, does it produce any warning? I'm not sure if I want to do the change in the same patch and last time I checked objtool was fine with the listed function not existing.
Quoted 8 lines
tools/objtool/check.c +0
-0"cpu_bringup_and_idle" ,"cpu_startup_entry" , "do_exit",Best Regards
Wang Yugui ([email protected])
2023/05/28
Hi,
Quoted 7 lines · Wang Yugui
Quoted 6 lines
Hi,
please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).
Because '
btrfs_assertfail' become macro(inline), we should drop it from objtools.
Quoted 13 lines
tools/objtool/check.c static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · line 173
Quoted 9 lines
tools/objtool/check.c +0
-1@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,"__reiserfs_panic" ,"__stack_chk_fail" , "__ubsan_handle_builtin_unreachable", - "btrfs_assertfail",If this is not in objtool, does it produce any warning? I'm not sure if I want to do the change in the same patch and last time I checked objtool was fine with the listed function not existing.
yes, it produce no warning, but this funciton in here become a noisy.
we need to do this in the same patch, because in this patch, it become from necessary to noisy.
Best Regards
Wang Yugui ([email protected])
2023/05/29
Quoted 23 lines · Wang Yugui
Hi,
Quoted 7 lines · Wang Yugui
Quoted 6 lines
Hi,
please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).
Because '
btrfs_assertfail' become macro(inline), we should drop it from objtools.Quoted 13 lines
tools/objtool/check.c static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · line 173
Quoted 9 lines
tools/objtool/check.c +0
-1@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,"__reiserfs_panic" ,"__stack_chk_fail" , "__ubsan_handle_builtin_unreachable", - "btrfs_assertfail",If this is not in objtool, does it produce any warning? I'm not sure if I want to do the change in the same patch and last time I checked objtool was fine with the listed function not existing.
Quoted 4 lines
yes, it produce no warning, but this funciton in here become a noisy.
we need to do this in the same patch, because in this patch, it become from necessary to noisy.
Ok, I'll update the patch and let Josh know.