Skip to contentSkip to conversation

please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line)

PATCH Wang Yugui 2 participants 4 messages May 27, 2023 – May 30, 2023

Subsystems (2)
lore
Share & tools
lore

Wang Yugui

author
#0 lore raw

Hi,

please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).

Because 'btrfs_assertfail' become macro(inline), we should drop it from objtools.

tools/objtool/check.c +0 -1
index f937be1afe65..060032cfb046 100644
@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
 		"__reiserfs_panic",
 		"__stack_chk_fail",
 		"__ubsan_handle_builtin_unreachable",
-		"btrfs_assertfail",
 		"cpu_bringup_and_idle",
 		"cpu_startup_entry",
 		"do_exit",

Best Regards
Wang Yugui ([email protected])
2023/05/28

#1 lore raw
Quoted 11 lines · Wang Yugui

Hi,

please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).

Because 'btrfs_assertfail' become macro(inline), we should drop it from objtools.

tools/objtool/check.c +0 -0
index f937be1afe65..060032cfb046 100644

tools/objtool/check.c static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · line 173

Quoted 4 lines
tools/objtool/check.c +0 -1
@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
 		"__reiserfs_panic",
 		"__stack_chk_fail",
 		"__ubsan_handle_builtin_unreachable",
-		"btrfs_assertfail",

If this is not in objtool, does it produce any warning? I'm not sure if I want to do the change in the same patch and last time I checked objtool was fine with the listed function not existing.

Quoted 8 lines
tools/objtool/check.c +0 -0
 		"cpu_bringup_and_idle",
 		"cpu_startup_entry",
 		"do_exit",

Best Regards
Wang Yugui ([email protected])
2023/05/28

author
#2 lore raw

Hi,

Quoted 7 lines · Wang Yugui
Quoted 6 lines

Hi,

please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).

Because 'btrfs_assertfail' become macro(inline), we should drop it from objtools.

Quoted 13 lines

tools/objtool/check.c static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · line 173

Quoted 9 lines
tools/objtool/check.c +0 -1
index f937be1afe65..060032cfb046 100644
@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
 		"__reiserfs_panic",
 		"__stack_chk_fail",
 		"__ubsan_handle_builtin_unreachable",
-		"btrfs_assertfail",

If this is not in objtool, does it produce any warning? I'm not sure if I want to do the change in the same patch and last time I checked objtool was fine with the listed function not existing.

yes, it produce no warning, but this funciton in here become a noisy.

we need to do this in the same patch, because in this patch, it become from necessary to noisy.

Best Regards
Wang Yugui ([email protected])
2023/05/29

#3 lore raw
Quoted 23 lines · Wang Yugui

Hi,

Quoted 7 lines · Wang Yugui
Quoted 6 lines

Hi,

please fold some fix into misc-next(btrfs: print assertion failure report and stack trace from the same line).

Because 'btrfs_assertfail' become macro(inline), we should drop it from objtools.

Quoted 13 lines

tools/objtool/check.c static bool __dead_end_function(struct objtool_file *file, struct symbol *func, · line 173

Quoted 9 lines
tools/objtool/check.c +0 -1
index f937be1afe65..060032cfb046 100644
@@ -170,7 +170,6 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
 		"__reiserfs_panic",
 		"__stack_chk_fail",
 		"__ubsan_handle_builtin_unreachable",
-		"btrfs_assertfail",

If this is not in objtool, does it produce any warning? I'm not sure if I want to do the change in the same patch and last time I checked objtool was fine with the listed function not existing.

Quoted 4 lines

yes, it produce no warning, but this funciton in here become a noisy.

we need to do this in the same patch, because in this patch, it become from necessary to noisy.

Ok, I'll update the patch and let Josh know.