Skip to contentSkip to conversation

scsi: ufs: Remove a ufshcd_add_command_trace() call

PATCH Applied Bart Van Assche 4 participants 5 messages May 31, 2023 – Jun 8, 2023

Subsystems (2)
lore
Share & tools
lore

Bart Van Assche

author reviewer
#0 lore raw

PATCH 1/1 scsi: ufs: Remove a ufshcd_add_command_trace() call

ufshcd_add_command_trace() traces SCSI commands. Remove a ufshcd_add_command_trace() call from a code path that is not related to SCSI commands.

---
 drivers/ufs/core/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/ufs/core/ufshcd.c +0 -1
index 0856f01b761d..1f7a4ec211ff 100644
@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
 		   lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
 		if (hba->dev_cmd.complete) {
 			hba->dev_cmd.cqe = cqe;
-			ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
 			complete(hba->dev_cmd.complete);
 			ufshcd_clk_scaling_update_busy(hba);
 		}
author reviewer
#1 lore raw
Quoted 14 lines · Bart Van Assche

ufshcd_add_command_trace() traces SCSI commands. Remove a ufshcd_add_command_trace() call from a code path that is not related to SCSI commands.

---
  drivers/ufs/core/ufshcd.c | 1 -
  1 file changed, 1 deletion(-)
drivers/ufs/core/ufshcd.c +0 -0
index 0856f01b761d..1f7a4ec211ff 100644

drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, · line 5405

Quoted 7 lines
drivers/ufs/core/ufshcd.c +0 -1
@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
  		   lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
  		if (hba->dev_cmd.complete) {
  			hba->dev_cmd.cqe = cqe;
-			ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
  			complete(hba->dev_cmd.complete);
  			ufshcd_clk_scaling_update_busy(hba);
  		}

Can anyone please help with reviewing this patch?

Thanks,

Bart.

reviewer Reviewed-by
#2 lore raw
Quoted 7 lines · Bart Van Assche
Quoted 5 lines

ufshcd_add_command_trace() traces SCSI commands. Remove a ufshcd_add_command_trace() call from a code path that is not related to SCSI commands.

Quoted 23 lines

drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba,

Quoted 9 lines
---
  drivers/ufs/core/ufshcd.c | 1 -
  1 file changed, 1 deletion(-)
drivers/ufs/core/ufshcd.c +0 -0
index 0856f01b761d..1f7a4ec211ff 100644
@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,

int task_tag,

drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, · line 5405

Quoted 7 lines
drivers/ufs/core/ufshcd.c +0 -1
                 lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
              if (hba->dev_cmd.complete) {
                      hba->dev_cmd.cqe = cqe;
-                     ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
                      complete(hba->dev_cmd.complete);
                      ufshcd_clk_scaling_update_busy(hba);
              }

Can anyone please help with reviewing this patch?

Thanks,

Bart.

Reviewed-by on v1 1/1
#3 lore raw
In reply to Bart Van Assche
Quoted 14 lines · Bart Van Assche

ufshcd_add_command_trace() traces SCSI commands. Remove a ufshcd_add_command_trace() call from a code path that is not related to SCSI commands.

---
  drivers/ufs/core/ufshcd.c | 1 -
  1 file changed, 1 deletion(-)
drivers/ufs/core/ufshcd.c +0 -0
index 0856f01b761d..1f7a4ec211ff 100644

drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, · line 5405

Quoted 7 lines
drivers/ufs/core/ufshcd.c +0 -1
@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag,
  		   lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
  		if (hba->dev_cmd.complete) {
  			hba->dev_cmd.cqe = cqe;
-			ufshcd_add_command_trace(hba, task_tag, UFS_DEV_COMP);
  			complete(hba->dev_cmd.complete);
  			ufshcd_clk_scaling_update_busy(hba);
  		}

The tracepoint entry here is of no use, it's never executed, it just returns.

#4 lore raw
In reply to Bart Van Assche

Bart,

Quoted 3 lines

ufshcd_add_command_trace() traces SCSI commands. Remove a ufshcd_add_command_trace() call from a code path that is not related to SCSI commands.

Applied to 6.5/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering