scsi: ufs: Remove a ufshcd_add_command_trace() call
Subsystems (2)
Bart Van Assche
reviewerPATCH 1/1 scsi: ufs: Remove a ufshcd_add_command_trace() call
ufshcd_add_command_trace() traces SCSI commands. Remove a ufshcd_add_command_trace() call from a code path that is not related to SCSI commands.
--- drivers/ufs/core/ufshcd.c | 1 - 1 file changed, 1 deletion(-)
drivers/ufs/core/ufshcd.c +0 -1
@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {if (hba->dev_cmd.complete) { hba->dev_cmd.cqe = cqe; -ufshcd_add_command_trace (hba, task_tag,UFS_DEV_COMP );complete (hba->dev_cmd.complete);ufshcd_clk_scaling_update_busy (hba); }
Bart Van Assche
reviewerQuoted 14 lines · Bart Van Assche
ufshcd_add_command_trace()traces SCSI commands. Remove aufshcd_add_command_trace()call from a code path that is not related to SCSI commands.Signed-off-by Bart Van Assche <[email protected]>--- drivers/ufs/core/ufshcd.c | 1 - 1 file changed, 1 deletion(-)drivers/ufs/core/ufshcd.c +0
-0
drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, · line 5405
Quoted 7 lines
drivers/ufs/core/ufshcd.c +0
-1@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {if (hba->dev_cmd.complete) { hba->dev_cmd.cqe = cqe; -ufshcd_add_command_trace (hba, task_tag,UFS_DEV_COMP );complete (hba->dev_cmd.complete);ufshcd_clk_scaling_update_busy (hba); }
Can anyone please help with reviewing this patch?
Thanks,
Bart.
Quoted 7 lines · Bart Van Assche
Quoted 5 lines
ufshcd_add_command_trace()traces SCSI commands. Remove aufshcd_add_command_trace()call from a code path that is not related to SCSI commands.Signed-off-by Bart Van Assche <[email protected]>
Quoted 23 lines
drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba,
Quoted 9 lines
--- drivers/ufs/core/ufshcd.c | 1 - 1 file changed, 1 deletion(-)drivers/ufs/core/ufshcd.c +0
-0@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba,int
task_tag,drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, · line 5405
Quoted 7 lines
drivers/ufs/core/ufshcd.c +0
-1lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {if (hba->dev_cmd.complete) { hba->dev_cmd.cqe = cqe; -ufshcd_add_command_trace (hba, task_tag,UFS_DEV_COMP );complete (hba->dev_cmd.complete);ufshcd_clk_scaling_update_busy (hba); }Can anyone please help with reviewing this patch?
Thanks,
Bart.
Quoted 14 lines · Bart Van Assche
ufshcd_add_command_trace()traces SCSI commands. Remove aufshcd_add_command_trace()call from a code path that is not related to SCSI commands.Signed-off-by Bart Van Assche <[email protected]>--- drivers/ufs/core/ufshcd.c | 1 - 1 file changed, 1 deletion(-)drivers/ufs/core/ufshcd.c +0
-0
drivers/ufs/core/ufshcd.c void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, · line 5405
Quoted 7 lines
drivers/ufs/core/ufshcd.c +0
-1@@ -5400,7 +5400,6 @@ void ufshcd_compl_one_cqe(struct ufs_hba *hba, int task_tag, lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {if (hba->dev_cmd.complete) { hba->dev_cmd.cqe = cqe; -ufshcd_add_command_trace (hba, task_tag,UFS_DEV_COMP );complete (hba->dev_cmd.complete);ufshcd_clk_scaling_update_busy (hba); }
The tracepoint entry here is of no use, it's never executed, it just returns.
Martin K. Petersen
AppliedBart,
Quoted 3 lines
ufshcd_add_command_trace()traces SCSI commands. Remove aufshcd_add_command_trace()call from a code path that is not related to SCSI commands.
Applied to 6.5/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering