Skip to contentSkip to conversation

dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"

PATCH Applied Rob Herring 2 participants 8 messages Jun 13, 2023 – Jun 15, 2023

Subsystems (3)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"

The "linux,keycode" property is missing a type probably because it was confused with the common property "linux,keycodes".

---
 Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml +1 -0
index 286dffa0671b..6052129bf852 100644
@@ -103,6 +103,7 @@ properties:
       wakeup-source: true
 
       linux,keycode:
+        $ref: /schemas/types.yaml#/definitions/uint32
         default: 116
 
     required:
Signature · 1 line
2.39.2
author maintainer
#1 lore raw

PATCH 2/2 dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.

---
 .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml +5 -0
index 6052129bf852..e879bc0be8e2 100644
@@ -105,6 +105,11 @@ properties:
       linux,keycode:
         $ref: /schemas/types.yaml#/definitions/uint32
         default: 116
+        deprecated: true
+
+      linux,keycodes:
+        maxItems: 1
+        default: 116
 
     required:
       - compatible
Signature · 1 line
2.39.2
#2 lore raw

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

Quoted 3 lines · Rob Herring

The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.

This is actually used in the driver for this device, should the driver not also be updated to use the corrected property?

Quoted 25 lines
---
 .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml +5 -0
index 6052129bf852..e879bc0be8e2 100644
@@ -105,6 +105,11 @@ properties:
       linux,keycode:
         $ref: /schemas/types.yaml#/definitions/uint32
         default: 116
+        deprecated: true
+
+      linux,keycodes:
+        maxItems: 1
+        default: 116
 
     required:
       - compatible
Signature · 1 line
2.39.2
author maintainer
#3 lore raw

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

Quoted 8 lines · Conor Dooley
Quoted 3 lines · Rob Herring

The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.

This is actually used in the driver for this device, should the driver not also be updated to use the corrected property?

Yes, but that doesn't have to be in sync with the binding change. I mainly want to add this so it doesn't get propagated to new users rather than move this case off of linux,keycode. Also, the input subsystem should probably have a common function to read linux,keycodes as right now every driver does it.

Rob

Acked-by
#4 lore raw

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

Quoted 7 lines · Rob Herring
Quoted 6 lines · Conor Dooley
Quoted 3 lines · Rob Herring

The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.

Quoted 8 lines
Quoted 2 lines

This is actually used in the driver for this device, should the driver not also be updated to use the corrected property?

Yes, but that doesn't have to be in sync with the binding change. I mainly want to add this so it doesn't get propagated to new users rather than move this case off of linux,keycode. Also, the input subsystem should probably have a common function to read linux,keycodes as right now every driver does it.

Perhaps one of the nxp folk in the audience should have a crack at that so.

Cheers,
Conor.

author maintainer Applied
#5 lore raw

Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"

In reply to Rob Herring
Quoted 9 lines · Rob Herring

The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.

---
 .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml         | 5 +++++
 1 file changed, 5 insertions(+)

Applied, thanks!

author maintainer Applied
#7 lore raw
In reply to Rob Herring
Quoted 8 lines · Rob Herring

The "linux,keycode" property is missing a type probably because it was confused with the common property "linux,keycodes".

---
 Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks!