dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"
Subsystems (3)
Rob Herring
maintainerPATCH 1/2 dt-bindings: crypto: fsl,sec-v4.0-mon: Add missing type for "linux,keycode"
The "linux,keycode" property is missing a type probably because it was confused with the common property "linux,keycodes".
--- Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml +1 -0
@@ -103,6 +103,7 @@ properties: wakeup-source: true linux,keycode: + $ref: /schemas/types.yaml#/definitions/uint32 default: 116 required:
Signature · 1 line
2.39.2
Rob Herring
maintainerPATCH 2/2 dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.
--- .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml +5 -0
@@ -105,6 +105,11 @@ properties: linux,keycode: $ref: /schemas/types.yaml#/definitions/uint32 default: 116 + deprecated: true + + linux,keycodes: + maxItems: 1 + default: 116 required: - compatible
Signature · 1 line
2.39.2
Quoted 4 lines · Rob Herring
The "linux,keycode" property is missing a type probably because it was confused with the common property "linux,keycodes".
Signed-off-by Rob Herring <[email protected]>
Cheers,
Conor.
Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
In reply to Rob HerringQuoted 3 lines · Rob Herring
The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.
This is actually used in the driver for this device, should the driver not also be updated to use the corrected property?
Quoted 25 lines
Signed-off-by Rob Herring <[email protected]>--- .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml +5
-0@@ -105,6 +105,11 @@ properties: linux,keycode: $ref: /schemas/types.yaml#/definitions/uint32 default: 116 + deprecated: true + + linux,keycodes: + maxItems: 1 + default: 116 required: - compatibleSignature · 1 line
2.39.2
Rob Herring
maintainerRe: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
Quoted 8 lines · Conor Dooley
Quoted 3 lines · Rob Herring
The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.
This is actually used in the driver for this device, should the driver not also be updated to use the corrected property?
Yes, but that doesn't have to be in sync with the binding change. I mainly want to add this so it doesn't get propagated to new users rather than move this case off of linux,keycode. Also, the input subsystem should probably have a common function to read linux,keycodes as right now every driver does it.
Rob
Conor Dooley
Acked-byRe: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
Quoted 7 lines · Rob Herring
Quoted 6 lines · Conor Dooley
Quoted 3 lines · Rob Herring
The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.
Quoted 8 lines
Quoted 2 lines
This is actually used in the driver for this device, should the driver not also be updated to use the corrected property?
Yes, but that doesn't have to be in sync with the binding change. I mainly want to add this so it doesn't get propagated to new users rather than move this case off of linux,keycode. Also, the input subsystem should probably have a common function to read linux,keycodes as right now every driver does it.
Perhaps one of the nxp folk in the audience should have a crack at that so.
Cheers,
Conor.
Quoted 8 lines · Rob Herring
The "linux,keycode" property is missing a type probably because it was confused with the common property "linux,keycodes".
Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 1 + 1 file changed, 1 insertion(+)
Applied, thanks!
Re: [PATCH 2/2] dt-bindings: crypto: fsl,sec-v4.0-mon: Add "linux,keycodes" and deprecate "linux,keycode"
In reply to Rob HerringQuoted 9 lines · Rob Herring
The "linux,keycode" property is non-standard. Add the common property "linux,keycodes" and mark "linux,keycode" deprecated so that the mistake is not propagated.
Signed-off-by Rob Herring <[email protected]>--- .../devicetree/bindings/crypto/fsl,sec-v4.0-mon.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Applied, thanks!