dt-bindings: clock: ast2600: Add I3C and MAC reset definitions
Subsystems (2)
PATCH RESEND v2 1/1 dt-bindings: clock: ast2600: Add I3C and MAC reset definitions
Add reset definitions of AST2600 I3C and MAC controllers.
---
Resend v2 patch through my gmail account as the aspeedtech.com domain is blocked by gmail.com
include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)
include/dt-bindings/clock/ast2600-clock.h +12 -0
@@ -90,7 +90,19 @@/* Only list resets here that are not part of a clock gate + reset pair */ #define ASPEED_RESET_ADC 55#define ASPEED_RESET_JTAG_MASTER2 54 + +#define ASPEED_RESET_MAC4 53 +#define ASPEED_RESET_MAC3 52 + +#define ASPEED_RESET_I3C5 45 +#define ASPEED_RESET_I3C4 44 +#define ASPEED_RESET_I3C3 43 +#define ASPEED_RESET_I3C2 42 +#define ASPEED_RESET_I3C1 41 +#define ASPEED_RESET_I3C0 40 +#define ASPEED_RESET_I3C 39#define ASPEED_RESET_I3C_DMA 39 +#define ASPEED_RESET_PWM 37#define ASPEED_RESET_PECI 36#define ASPEED_RESET_MII 35
Signature · 1 line
2.25.1
Quoted 6 lines · Dylan Hung
Add reset definitions of AST2600 I3C and MAC controllers.
Signed-off-by Dylan Hung <[email protected]>---
Resend v2 patch through my gmail account as the aspeedtech.com domain is blocked by gmail.com
Where is the changelog?
Quoted 14 lines
include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)include/dt-bindings/clock/ast2600-clock.h +2
-0@@ -90,7 +90,19 @@/* Only list resets here that are not part of a clock gate + reset pair */ #define ASPEED_RESET_ADC 55#define ASPEED_RESET_JTAG_MASTER2 54 + +#define ASPEED_RESET_MAC4 53
include/dt-bindings/clock/ast2600-clock.h line 104
Quoted 10 lines
include/dt-bindings/clock/ast2600-clock.h +9
-0+#define ASPEED_RESET_MAC3 52 + +#define ASPEED_RESET_I3C5 45 +#define ASPEED_RESET_I3C4 44 +#define ASPEED_RESET_I3C3 43 +#define ASPEED_RESET_I3C2 42 +#define ASPEED_RESET_I3C1 41 +#define ASPEED_RESET_I3C0 40 +#define ASPEED_RESET_I3C 39#define ASPEED_RESET_I3C_DMA 39
Why adding duplicate ID? Your commit msg or a comment here should explain this.
Best regards,
Krzysztof
Krzysztof Kozlowski <[email protected]> 於 2023年7月17日 週一 下午4:00寫道：
Quoted 11 lines · Dylan Hung
Quoted 6 lines
Add reset definitions of AST2600 I3C and MAC controllers.
Signed-off-by Dylan Hung <[email protected]>---
Resend v2 patch through my gmail account as the aspeedtech.com domain is blocked by gmail.com
Where is the changelog?
Apologies for the oversight. I will ensure to include the changelog in V3.
Quoted 19 lines
Quoted 19 lines
include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++ 1 file changed, 12 insertions(+)include/dt-bindings/clock/ast2600-clock.h +7
-0@@ -90,7 +90,19 @@/* Only list resets here that are not part of a clock gate + reset pair */ #define ASPEED_RESET_ADC 55#define ASPEED_RESET_JTAG_MASTER2 54 + +#define ASPEED_RESET_MAC4 53 +#define ASPEED_RESET_MAC3 52 + +#define ASPEED_RESET_I3C5 45 +#define ASPEED_RESET_I3C4 44 +#define ASPEED_RESET_I3C3 43
Quoted 9 lines
include/dt-bindings/clock/ast2600-clock.h line 104
Quoted 5 lines
include/dt-bindings/clock/ast2600-clock.h +4
-0+#define ASPEED_RESET_I3C2 42 +#define ASPEED_RESET_I3C1 41 +#define ASPEED_RESET_I3C0 40 +#define ASPEED_RESET_I3C 39#define ASPEED_RESET_I3C_DMA 39Why adding duplicate ID? Your commit msg or a comment here should explain this.
There is no reset-line hardware available for ASPEED_RESET_I3C_DMA, so I have added a new macro to provide a better representation of the hardware design. However, since removing the old macro may affect all users, I decide to keep both the old and new macros. I will include the explainaion in the commit message of V3.
Quoted 3 lines
Best regards,
Krzysztof