Skip to contentSkip to conversation

Update AUX invalidation sequence

PATCH Superseded Andi Shyti 5 participants 30 messages Jul 17, 2023 – Jul 18, 2023

Subsystems (2)

v4 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Andi Shyti

author
#0 lore raw

v4 cover Update AUX invalidation sequence

Hi,

as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence.

In this version we support all the engines affected by this change.

The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

Thanks a lot Nirmoy for your review and for the fruitful discussions!

Thanks,
Andi

Changelog:
=========
v3 -> v4
- A trivial patch 3 is added to rename the flags with bit_group_{0,1} to align with the datasheet naming.
- Patch 4 fixes a confusion I made where the CCS flag was applied to the wrong bit group.

v2 -> v3
- added r-b from Nirmoy in patch 1 and 4.
- added patch 3 which enables the ccs_flush in the control pipe for mtl+ compute and render engines.
- added redundant checks in patch 2 for enabling the EMIT_FLUSH flag.

v1 -> v2
- add a clean up preliminary patch for the existing registers
- add support for more engines
- add the Fixes tag

Andi Shyti (4):
drm/i915/gt: Cleanup aux invalidation registers drm/i915/gt: Rename flags with bit_group_X according to the datasheet drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control drm/i915/gt: Support aux invalidation on all engines

Jonathan Cavitt (2):
drm/i915/gt: Ensure memory quiesced before invalidation drm/i915/gt: Poll aux invalidation register bit on invalidation

 drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 127 +++++++++++++------
 drivers/gpu/drm/i915/gt/gen8_engine_cs.h     |   3 +-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |   1 +
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |   2 +
 drivers/gpu/drm/i915/gt/intel_gt_regs.h      |  14 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c          |  17 +--
 6 files changed, 98 insertions(+), 66 deletions(-)
Signature · 1 line
2.40.1
author
#1 lore raw

PATCH v4 1/6 drm/i915/gt: Cleanup aux invalidation registers

Fix the 'NV' definition postfix that is supposed to be INV.

Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers.

Remove also VD1, VD3 and VE1 registers that don't exist.

---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c |  8 ++++----
 drivers/gpu/drm/i915/gt/intel_gt_regs.h  | 14 ++++++--------
 drivers/gpu/drm/i915/gt/intel_lrc.c      |  6 +++---
 3 files changed, 13 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -4
index 23857cc08eca1..563efee055602 100644
@@ -287,8 +287,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 		if (!HAS_FLAT_CCS(rq->engine->i915)) {
 			/* hsdes: 1809175790 */
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_GFX_CCS_AUX_NV);
+			cs = gen12_emit_aux_table_inv(rq->engine->gt, cs,
+						      GEN12_CCS_AUX_INV);
 		}
 
 		*cs++ = preparser_disable(false);
@@ -348,10 +348,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 	if (aux_inv) { /* hsdes: 1809175790 */
 		if (rq->engine->class == VIDEO_DECODE_CLASS)
 			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VD0_AUX_NV);
+						      cs, GEN12_VD0_AUX_INV);
 		else
 			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VE0_AUX_NV);
+						      cs, GEN12_VE0_AUX_INV);
 	}
 
 	if (mode & EMIT_INVALIDATE)
drivers/gpu/drm/i915/gt/intel_gt_regs.h +6 -8
index 718cb2c80f79e..78b67a5336afc 100644
@@ -332,9 +332,10 @@
 #define GEN8_PRIVATE_PAT_HI			_MMIO(0x40e0 + 4)
 #define GEN10_PAT_INDEX(index)			_MMIO(0x40e0 + (index) * 4)
 #define BSD_HWS_PGA_GEN7			_MMIO(0x4180)
-#define GEN12_GFX_CCS_AUX_NV			_MMIO(0x4208)
-#define GEN12_VD0_AUX_NV			_MMIO(0x4218)
-#define GEN12_VD1_AUX_NV			_MMIO(0x4228)
+
+#define GEN12_CCS_AUX_INV			_MMIO(0x4208)
+#define GEN12_VD0_AUX_INV			_MMIO(0x4218)
+#define GEN12_VE0_AUX_INV			_MMIO(0x4238)
 
 #define GEN8_RTCR				_MMIO(0x4260)
 #define GEN8_M1TCR				_MMIO(0x4264)
@@ -342,14 +343,11 @@
 #define GEN8_BTCR				_MMIO(0x426c)
 #define GEN8_VTCR				_MMIO(0x4270)
 
-#define GEN12_VD2_AUX_NV			_MMIO(0x4298)
-#define GEN12_VD3_AUX_NV			_MMIO(0x42a8)
-#define GEN12_VE0_AUX_NV			_MMIO(0x4238)
-
 #define BLT_HWS_PGA_GEN7			_MMIO(0x4280)
 
-#define GEN12_VE1_AUX_NV			_MMIO(0x42b8)
+#define GEN12_VD2_AUX_INV			_MMIO(0x4298)
 #define   AUX_INV				REG_BIT(0)
+
 #define VEBOX_HWS_PGA_GEN7			_MMIO(0x4380)
 
 #define GEN12_AUX_ERR_DBG			_MMIO(0x43f4)
drivers/gpu/drm/i915/gt/intel_lrc.c +3 -3
index 1b710102390bf..235f3fab60a98 100644
@@ -1374,7 +1374,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
 	/* hsdes: 1809175790 */
 	if (!HAS_FLAT_CCS(ce->engine->i915))
 		cs = gen12_emit_aux_table_inv(ce->engine->gt,
-					      cs, GEN12_GFX_CCS_AUX_NV);
+					      cs, GEN12_CCS_AUX_INV);
 
 	/* Wa_16014892111 */
 	if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||
@@ -1403,10 +1403,10 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)
 	if (!HAS_FLAT_CCS(ce->engine->i915)) {
 		if (ce->engine->class == VIDEO_DECODE_CLASS)
 			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VD0_AUX_NV);
+						      cs, GEN12_VD0_AUX_INV);
 		else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS)
 			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VE0_AUX_NV);
+						      cs, GEN12_VE0_AUX_INV);
 	}
 
 	return cs;
Signature · 1 line
2.40.1
author
#2 lore raw

PATCH v4 2/6 drm/i915/gt: Ensure memory quiesced before invalidation

In reply to Andi Shyti

From: Jonathan Cavitt <[email protected]>

All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +7 -0
index 563efee055602..bee3b7dc595cf 100644
@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 {
 	struct intel_engine_cs *engine = rq->engine;
 
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))
+		mode |= EMIT_FLUSH;
+
 	if (mode & EMIT_FLUSH) {
 		u32 flags = 0;
 		int err;
Signature · 1 line
2.40.1
#3 lore raw

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

Quoted 18 lines · Andi Shyti

From: Jonathan Cavitt <[email protected]>

All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index 563efee055602..bee3b7dc595cf 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 209

Quoted 8 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -0
@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 {
 	struct intel_engine_cs *engine = rq->engine;
 
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))

It's a pre-existing mistake in drm-tip at the moment, but we shouldn't assume !flatccs always implies auxccs. PVC has neither, and there may be other similar platforms in the future. We should probably add a helper function for AuxCCS, similar to what we added to the Xe driver recently:

https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

Matt

Quoted 8 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -0
+		mode |= EMIT_FLUSH;
+
 	if (mode & EMIT_FLUSH) {
 		u32 flags = 0;
 		int err;
Signature · 1 line
2.40.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
#4 lore raw

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

Quoted 34 lines · Matt Roper
Quoted 18 lines · Andi Shyti

From: Jonathan Cavitt <[email protected]>

All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index 563efee055602..bee3b7dc595cf 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 209

Quoted 8 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -0
@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 {
 	struct intel_engine_cs *engine = rq->engine;
 
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))

It's a pre-existing mistake in drm-tip at the moment, but we shouldn't assume !flatccs always implies auxccs. PVC has neither, and there may be other similar platforms in the future. We should probably add a helper function for AuxCCS, similar to what we added to the Xe driver recently:

Quoted 2 lines

https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

BTW, since this patch didn't handle it I was expecting to see another patch in the series that quiesces memory for the non-RCS/CCS engines, but it looks like there isn't one yet. So we should probably add the necessary MI_FLUSH_DW logic for the other engines to this patch as well.

Matt

Quoted 18 lines

Matt

Quoted 8 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -0
+		mode |= EMIT_FLUSH;
+
 	if (mode & EMIT_FLUSH) {
 		u32 flags = 0;
 		int err;
Signature · 1 line
2.40.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#5 lore raw

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

Hi Matt,

Quoted 35 lines · Matt Roper
Quoted 34 lines · Matt Roper
Quoted 18 lines · Andi Shyti

From: Jonathan Cavitt <[email protected]>

All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index 563efee055602..bee3b7dc595cf 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 209

Quoted 8 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -0
@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 {
 	struct intel_engine_cs *engine = rq->engine;
 
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))

It's a pre-existing mistake in drm-tip at the moment, but we shouldn't assume !flatccs always implies auxccs. PVC has neither, and there may be other similar platforms in the future. We should probably add a helper function for AuxCCS, similar to what we added to the Xe driver recently:

Quoted 1 line
Quoted 1 line

https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

Currently that is done in patch 6...

Quoted 4 lines

BTW, since this patch didn't handle it I was expecting to see another patch in the series that quiesces memory for the non-RCS/CCS engines, but it looks like there isn't one yet. So we should probably add the necessary MI_FLUSH_DW logic for the other engines to this patch as well.

... where also other engines are handles as well. I left this patch as it is in order to preserve the authorship and it's original form.

Maybe in patch 6 I can add the extra check for PVC as you did for XE.

Thanks,
Andi

#6 lore raw

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

Quoted 38 lines · Andi Shyti

Hi Matt,

Quoted 35 lines · Matt Roper
Quoted 34 lines · Matt Roper
Quoted 18 lines · Andi Shyti

From: Jonathan Cavitt <[email protected]>

All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index 563efee055602..bee3b7dc595cf 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 209

Quoted 8 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -0
@@ -202,6 +202,13 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 {
 	struct intel_engine_cs *engine = rq->engine;
 
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))

It's a pre-existing mistake in drm-tip at the moment, but we shouldn't assume !flatccs always implies auxccs. PVC has neither, and there may be other similar platforms in the future. We should probably add a helper function for AuxCCS, similar to what we added to the Xe driver recently:

Quoted 3 lines
Quoted 1 line
Quoted 1 line

https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

Currently that is done in patch 6...

Are you sure? Patch #6 consolidates things a bit, but is still incorrectly assuming flatccs = !auxccs:

       if (HAS_FLAT_CCS(engine->i915))                                                                                                            
               return _MMIO(0);                                                                                                                   
Quoted 9 lines
Quoted 5 lines

BTW, since this patch didn't handle it I was expecting to see another patch in the series that quiesces memory for the non-RCS/CCS engines, but it looks like there isn't one yet. So we should probably add the necessary MI_FLUSH_DW logic for the other engines to this patch as well.

... where also other engines are handles as well. I left this patch as it is in order to preserve the authorship and it's original form.

I don't see it being handled in patch #6. That performs invalidation on more engines than we were before, but it doesn't add the missing quiesce logic as far as I can see.

Matt

Quoted 6 lines

Maybe in patch 6 I can add the extra check for PVC as you did for XE.

Thanks,
Andi

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#7 lore raw

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

Hi Matt,

Quoted 14 lines
Quoted 14 lines
Quoted 13 lines
Quoted 13 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 209

Quoted 5 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -0
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))

It's a pre-existing mistake in drm-tip at the moment, but we shouldn't assume !flatccs always implies auxccs. PVC has neither, and there may be other similar platforms in the future. We should probably add a helper function for AuxCCS, similar to what we added to the Xe driver recently:

https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

Quoted 7 lines
Quoted 1 line

Currently that is done in patch 6...

Are you sure? Patch #6 consolidates things a bit, but is still incorrectly assuming flatccs = !auxccs:

       if (HAS_FLAT_CCS(engine->i915))                                                                                                            
               return _MMIO(0);                                                                                                                   

But isn't it the same the patch you linked is doing?

	return !xe->info.has_flat_ccs;

And

#8 lore raw

Re: [PATCH v4 2/6] drm/i915/gt: Ensure memory quiesced before invalidation

Quoted 21 lines · Andi Shyti

Hi Matt,

Quoted 19 lines
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 209

Quoted 5 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -0
+	/*
+	 * Aux invalidations on Aux CCS platforms require
+	 * memory traffic is quiesced prior.
+	 */
+	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))

It's a pre-existing mistake in drm-tip at the moment, but we shouldn't assume !flatccs always implies auxccs. PVC has neither, and there may be other similar platforms in the future. We should probably add a helper function for AuxCCS, similar to what we added to the Xe driver recently:

Quoted 3 lines
Quoted 1 line
Quoted 1 line

https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

Currently that is done in patch 6...

Are you sure? Patch #6 consolidates things a bit, but is still incorrectly assuming flatccs = !auxccs:

Quoted 6 lines
Quoted 2 lines
       if (HAS_FLAT_CCS(engine->i915))                                                                                                            
               return _MMIO(0);                                                                                                                   

But isn't it the same the patch you linked is doing?

	return !xe->info.has_flat_ccs;

No, that's just the end of the function. The important platform-specific checks come before that point (at the moment we only have PVC, but we expect more platforms to be added there very soon too).

Matt

Quoted 2 lines

And

Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#9 lore raw

PATCH v4 3/6 drm/i915/gt: Rename flags with bit_group_X according to the datasheet

In reply to Andi Shyti

In preparation of the next patch allign with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 +++++++++++++-----------
 1 file changed, 18 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +18 -16
index bee3b7dc595cf..3c935d6b68bf0 100644
@@ -210,7 +210,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		mode |= EMIT_FLUSH;
 
 	if (mode & EMIT_FLUSH) {
-		u32 flags = 0;
+		u32 bit_group_0 = 0;
+		u32 bit_group_1 = 0;
 		int err;
 		u32 *cs;
 
@@ -218,32 +219,33 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		if (err)
 			return err;
 
-		flags |= PIPE_CONTROL_TILE_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_FLUSH_L3;
-		flags |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
+		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
+
+		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
+		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
 		/* Wa_1409600907:tgl,adl-p */
-		flags |= PIPE_CONTROL_DEPTH_STALL;
-		flags |= PIPE_CONTROL_DC_FLUSH_ENABLE;
-		flags |= PIPE_CONTROL_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_STALL;
+		bit_group_1 |= PIPE_CONTROL_DC_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_ENABLE;
 
-		flags |= PIPE_CONTROL_STORE_DATA_INDEX;
-		flags |= PIPE_CONTROL_QW_WRITE;
+		bit_group_1 |= PIPE_CONTROL_STORE_DATA_INDEX;
+		bit_group_1 |= PIPE_CONTROL_QW_WRITE;
 
-		flags |= PIPE_CONTROL_CS_STALL;
+		bit_group_1 |= PIPE_CONTROL_CS_STALL;
 
 		if (!HAS_3D_PIPELINE(engine->i915))
-			flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
 		else if (engine->class == COMPUTE_CLASS)
-			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
 		cs = intel_ring_begin(rq, 6);
 		if (IS_ERR(cs))
 			return PTR_ERR(cs);
 
-		cs = gen12_emit_pipe_control(cs,
-					     PIPE_CONTROL0_HDC_PIPELINE_FLUSH,
-					     flags, LRC_PPHWSP_SCRATCH_ADDR);
+		cs = gen12_emit_pipe_control(cs, bit_group_0, bit_group_1,
+					     LRC_PPHWSP_SCRATCH_ADDR);
 		intel_ring_advance(rq, cs);
 	}
 
Signature · 1 line
2.40.1
author
#10 lore raw

Re: [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

Hi,

Quoted 19 lines · Andi Shyti

In preparation of the next patch allign with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 +++++++++++++-----------
 1 file changed, 18 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index bee3b7dc595cf..3c935d6b68bf0 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 214

Quoted 6 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
@@ -210,7 +210,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		mode |= EMIT_FLUSH;
 
 	if (mode & EMIT_FLUSH) {
-		u32 flags = 0;
+		u32 bit_group_0 = 0;
+		u32 bit_group_1 = 0;

I could eventually add here a comment to explain better the meaning of these two bit_group_{0,1}.

Andi

Reviewed-by on v4 3/6
#11 lore raw

Re: [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

In reply to Andi Shyti
Quoted 1 line · Andi Shyti

In preparation of the next patch allign with the datasheet (BSPEC

s/allign/align/

Otherwise,

Quoted 79 lines

47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 +++++++++++++-----------
 1 file changed, 18 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +18 -16
index bee3b7dc595cf..3c935d6b68bf0 100644
@@ -210,7 +210,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		mode |= EMIT_FLUSH;
 
 	if (mode & EMIT_FLUSH) {
-		u32 flags = 0;
+		u32 bit_group_0 = 0;
+		u32 bit_group_1 = 0;
 		int err;
 		u32 *cs;
 
@@ -218,32 +219,33 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		if (err)
 			return err;
 
-		flags |= PIPE_CONTROL_TILE_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_FLUSH_L3;
-		flags |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
+		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
+
+		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
+		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
 		/* Wa_1409600907:tgl,adl-p */
-		flags |= PIPE_CONTROL_DEPTH_STALL;
-		flags |= PIPE_CONTROL_DC_FLUSH_ENABLE;
-		flags |= PIPE_CONTROL_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_STALL;
+		bit_group_1 |= PIPE_CONTROL_DC_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_ENABLE;
 
-		flags |= PIPE_CONTROL_STORE_DATA_INDEX;
-		flags |= PIPE_CONTROL_QW_WRITE;
+		bit_group_1 |= PIPE_CONTROL_STORE_DATA_INDEX;
+		bit_group_1 |= PIPE_CONTROL_QW_WRITE;
 
-		flags |= PIPE_CONTROL_CS_STALL;
+		bit_group_1 |= PIPE_CONTROL_CS_STALL;
 
 		if (!HAS_3D_PIPELINE(engine->i915))
-			flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
 		else if (engine->class == COMPUTE_CLASS)
-			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
 		cs = intel_ring_begin(rq, 6);
 		if (IS_ERR(cs))
 			return PTR_ERR(cs);
 
-		cs = gen12_emit_pipe_control(cs,
-					     PIPE_CONTROL0_HDC_PIPELINE_FLUSH,
-					     flags, LRC_PPHWSP_SCRATCH_ADDR);
+		cs = gen12_emit_pipe_control(cs, bit_group_0, bit_group_1,
+					     LRC_PPHWSP_SCRATCH_ADDR);
 		intel_ring_advance(rq, cs);
 	}
 
Signature · 1 line
2.40.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
Reviewed-by on v4 3/6
#12 lore raw

Re: [Intel-gfx] [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

In reply to Andi Shyti
Quoted 19 lines · Andi Shyti

In preparation of the next patch allign with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 +++++++++++++-----------
  1 file changed, 18 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index bee3b7dc595cf..3c935d6b68bf0 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 214

Quoted 6 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
@@ -210,7 +210,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  		mode |= EMIT_FLUSH;
 
  	if (mode & EMIT_FLUSH) {
-		u32 flags = 0;
+		u32 bit_group_0 = 0;
+		u32 bit_group_1 = 0;

For me flags0 and flags1 seems more readable as in *gen8_emit_pipe_control(batch, flags0, flags1, offset), but no strong feelings, but if bit_group is chosen arguments of *gen8_emit_pipe_control could be changed as well.

Regards
Andrzej

Quoted 52 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +16 -15
  		int err;
  		u32 *cs;
 
@@ -218,32 +219,33 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  		if (err)
  			return err;
 
-		flags |= PIPE_CONTROL_TILE_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_FLUSH_L3;
-		flags |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
+		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
+
+		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
+		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
  		/* Wa_1409600907:tgl,adl-p */
-		flags |= PIPE_CONTROL_DEPTH_STALL;
-		flags |= PIPE_CONTROL_DC_FLUSH_ENABLE;
-		flags |= PIPE_CONTROL_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_STALL;
+		bit_group_1 |= PIPE_CONTROL_DC_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_ENABLE;
 
-		flags |= PIPE_CONTROL_STORE_DATA_INDEX;
-		flags |= PIPE_CONTROL_QW_WRITE;
+		bit_group_1 |= PIPE_CONTROL_STORE_DATA_INDEX;
+		bit_group_1 |= PIPE_CONTROL_QW_WRITE;
 
-		flags |= PIPE_CONTROL_CS_STALL;
+		bit_group_1 |= PIPE_CONTROL_CS_STALL;
 
  		if (!HAS_3D_PIPELINE(engine->i915))
-			flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
  		else if (engine->class == COMPUTE_CLASS)
-			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
  		cs = intel_ring_begin(rq, 6);
  		if (IS_ERR(cs))
  			return PTR_ERR(cs);
 
-		cs = gen12_emit_pipe_control(cs,
-					     PIPE_CONTROL0_HDC_PIPELINE_FLUSH,
-					     flags, LRC_PPHWSP_SCRATCH_ADDR);
+		cs = gen12_emit_pipe_control(cs, bit_group_0, bit_group_1,
+					     LRC_PPHWSP_SCRATCH_ADDR);
  		intel_ring_advance(rq, cs);
  	}
 
author
#13 lore raw

Re: [Intel-gfx] [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

Hi Andrzej,

Quoted 15 lines · Andrzej Hajda
Quoted 14 lines · Andi Shyti

In preparation of the next patch allign with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 +++++++++++++-----------
  1 file changed, 18 insertions(+), 16 deletions(-)
Quoted 15 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 213

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
index bee3b7dc595cf..3c935d6b68bf0 100644
@@ -210,7 +210,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  		mode |= EMIT_FLUSH;
  	if (mode & EMIT_FLUSH) {
-		u32 flags = 0;
+		u32 bit_group_0 = 0;
+		u32 bit_group_1 = 0;

For me flags0 and flags1 seems more readable as in *gen8_emit_pipe_control(batch, flags0, flags1, offset), but no strong feelings, but if bit_group is chosen arguments of *gen8_emit_pipe_control could be changed as well.

yes, I thought to update all of them, as well for consistency. I like the name bit_group_0/1 because it's similar to the datasheet.

I had some confusion about it earlier and I think this can help to improve readability.

Will update all the other functions, as well.

Quoted 1 line

Thanks!

Andi

Reviewed-by on v4 3/6
#14 lore raw

Re: [PATCH v4 3/6] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

In reply to Andi Shyti

Thanks for cleaning this.

With Matt's suggestion, this is

Quoted 77 lines · Andi Shyti

In preparation of the next patch allign with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1.

Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTROL0_HDC_PIPELINE_FLUSH bit is set.

---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 34 +++++++++++++-----------
  1 file changed, 18 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +18 -16
index bee3b7dc595cf..3c935d6b68bf0 100644
@@ -210,7 +210,8 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  		mode |= EMIT_FLUSH;
 
  	if (mode & EMIT_FLUSH) {
-		u32 flags = 0;
+		u32 bit_group_0 = 0;
+		u32 bit_group_1 = 0;
  		int err;
  		u32 *cs;
 
@@ -218,32 +219,33 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  		if (err)
  			return err;
 
-		flags |= PIPE_CONTROL_TILE_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_FLUSH_L3;
-		flags |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
-		flags |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
+		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
+
+		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
+		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_CACHE_FLUSH;
  		/* Wa_1409600907:tgl,adl-p */
-		flags |= PIPE_CONTROL_DEPTH_STALL;
-		flags |= PIPE_CONTROL_DC_FLUSH_ENABLE;
-		flags |= PIPE_CONTROL_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_DEPTH_STALL;
+		bit_group_1 |= PIPE_CONTROL_DC_FLUSH_ENABLE;
+		bit_group_1 |= PIPE_CONTROL_FLUSH_ENABLE;
 
-		flags |= PIPE_CONTROL_STORE_DATA_INDEX;
-		flags |= PIPE_CONTROL_QW_WRITE;
+		bit_group_1 |= PIPE_CONTROL_STORE_DATA_INDEX;
+		bit_group_1 |= PIPE_CONTROL_QW_WRITE;
 
-		flags |= PIPE_CONTROL_CS_STALL;
+		bit_group_1 |= PIPE_CONTROL_CS_STALL;
 
  		if (!HAS_3D_PIPELINE(engine->i915))
-			flags &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ARCH_FLAGS;
  		else if (engine->class == COMPUTE_CLASS)
-			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
+			bit_group_1 &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
  		cs = intel_ring_begin(rq, 6);
  		if (IS_ERR(cs))
  			return PTR_ERR(cs);
 
-		cs = gen12_emit_pipe_control(cs,
-					     PIPE_CONTROL0_HDC_PIPELINE_FLUSH,
-					     flags, LRC_PPHWSP_SCRATCH_ADDR);
+		cs = gen12_emit_pipe_control(cs, bit_group_0, bit_group_1,
+					     LRC_PPHWSP_SCRATCH_ADDR);
  		intel_ring_advance(rq, cs);
  	}
 
author
#15 lore raw

PATCH v4 4/6 drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

In reply to Andi Shyti

Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112).

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc Jonathan Cavitt <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 10 +++++++++-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  1 +
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
 3 files changed, 11 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +9 -1
index 3c935d6b68bf0..aa2fb9d72745a 100644
@@ -207,7 +207,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 	 * memory traffic is quiesced prior.
 	 */
 	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))
-		mode |= EMIT_FLUSH;
+		mode |= EMIT_FLUSH | EMIT_CCS_FLUSH;
 
 	if (mode & EMIT_FLUSH) {
 		u32 bit_group_0 = 0;
@@ -221,6 +221,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
 
+		/*
+		 * When required, in MTL+ platforms we need to
+		 * set the CCS_FLUSH bit in the pipe control
+		 */
+		if (mode & EMIT_CCS_FLUSH &&
+		    GRAPHICS_VER_FULL(rq->i915) >= IP_VER(12, 70))
+			bit_group_0 |= PIPE_CONTROL_CCS_FLUSH;
+
 		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
 		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
 		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
drivers/gpu/drm/i915/gt/intel_engine_types.h +1 -0
index e99a6fa03d453..e2cae9d02bd62 100644
@@ -514,6 +514,7 @@ struct intel_engine_cs {
 	int		(*emit_flush)(struct i915_request *request, u32 mode);
 #define EMIT_INVALIDATE	BIT(0)
 #define EMIT_FLUSH	BIT(1)
+#define EMIT_CCS_FLUSH	BIT(2) /* MTL+ */
 #define EMIT_BARRIER	(EMIT_INVALIDATE | EMIT_FLUSH)
 	int		(*emit_bb_start)(struct i915_request *rq,
 					 u64 offset, u32 length,
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index 5d143e2a8db03..5df7cce23197c 100644
@@ -299,6 +299,7 @@
 #define   PIPE_CONTROL_QW_WRITE				(1<<14)
 #define   PIPE_CONTROL_POST_SYNC_OP_MASK                (3<<14)
 #define   PIPE_CONTROL_DEPTH_STALL			(1<<13)
+#define   PIPE_CONTROL_CCS_FLUSH			(1<<13) /* MTL+ */
 #define   PIPE_CONTROL_WRITE_FLUSH			(1<<12)
 #define   PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH	(1<<12) /* gen6+ */
 #define   PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE	(1<<11) /* MBZ on ILK */
Signature · 1 line
2.40.1
Reviewed-by on v4 4/6
#16 lore raw

Re: [Intel-gfx] [PATCH v4 4/6] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

Quoted 9 lines · Andi Shyti

Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112).

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc Jonathan Cavitt <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc <[email protected]> # v5.8+

Regards
Andrzej

Quoted 58 lines
---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 10 +++++++++-
  drivers/gpu/drm/i915/gt/intel_engine_types.h |  1 +
  drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
  3 files changed, 11 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +9 -1
index 3c935d6b68bf0..aa2fb9d72745a 100644
@@ -207,7 +207,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  	 * memory traffic is quiesced prior.
  	 */
  	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))
-		mode |= EMIT_FLUSH;
+		mode |= EMIT_FLUSH | EMIT_CCS_FLUSH;
 
  	if (mode & EMIT_FLUSH) {
  		u32 bit_group_0 = 0;
@@ -221,6 +221,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
  		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
 
+		/*
+		 * When required, in MTL+ platforms we need to
+		 * set the CCS_FLUSH bit in the pipe control
+		 */
+		if (mode & EMIT_CCS_FLUSH &&
+		    GRAPHICS_VER_FULL(rq->i915) >= IP_VER(12, 70))
+			bit_group_0 |= PIPE_CONTROL_CCS_FLUSH;
+
  		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
  		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
  		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
drivers/gpu/drm/i915/gt/intel_engine_types.h +1 -0
index e99a6fa03d453..e2cae9d02bd62 100644
@@ -514,6 +514,7 @@ struct intel_engine_cs {
  	int		(*emit_flush)(struct i915_request *request, u32 mode);
  #define EMIT_INVALIDATE	BIT(0)
  #define EMIT_FLUSH	BIT(1)
+#define EMIT_CCS_FLUSH	BIT(2) /* MTL+ */
  #define EMIT_BARRIER	(EMIT_INVALIDATE | EMIT_FLUSH)
  	int		(*emit_bb_start)(struct i915_request *rq,
  					 u64 offset, u32 length,
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index 5d143e2a8db03..5df7cce23197c 100644
@@ -299,6 +299,7 @@
  #define   PIPE_CONTROL_QW_WRITE				(1<<14)
  #define   PIPE_CONTROL_POST_SYNC_OP_MASK                (3<<14)
  #define   PIPE_CONTROL_DEPTH_STALL			(1<<13)
+#define   PIPE_CONTROL_CCS_FLUSH			(1<<13) /* MTL+ */
  #define   PIPE_CONTROL_WRITE_FLUSH			(1<<12)
  #define   PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH	(1<<12) /* gen6+ */
  #define   PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE	(1<<11) /* MBZ on ILK */
Reviewed-by on v4 4/6
#17 lore raw

Re: [PATCH v4 4/6] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

In reply to Andi Shyti
Quoted 20 lines · Andi Shyti

Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112).

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc Jonathan Cavitt <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 10 +++++++++-
 drivers/gpu/drm/i915/gt/intel_engine_types.h |  1 +
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
 3 files changed, 11 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index 3c935d6b68bf0..aa2fb9d72745a 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 210

Quoted 5 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1 -1
@@ -207,7 +207,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 	 * memory traffic is quiesced prior.
 	 */
 	if ((mode & EMIT_INVALIDATE) && !HAS_FLAT_CCS(engine->i915))
-		mode |= EMIT_FLUSH;
+		mode |= EMIT_FLUSH | EMIT_CCS_FLUSH;

Do we even really need the extra EMIT_* flag? It seems like just doing the CCS flush on graphics 12.70 and beyond would probably be fine since EMIT_FLUSH is only used in two places on those platforms: an EMIT_BARRIER in intel_engine_emit_ctx_wa (which happens during device init, before we've had an opportunity to use CCS for anything) and the new flush we're adding here in aux invalidation. All other uses of EMIT_FLUSH in the driver are specific to non-GuC execlist submission or to the old ringbuffer-based submission on pre-gen8 platforms.

Anyway, adding the extra condition shouldn't really hurt anything either, so up to you whether you want to drop it or not.

Quoted 45 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +8 -0
 	if (mode & EMIT_FLUSH) {
 		u32 bit_group_0 = 0;
@@ -221,6 +221,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 		bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH;
 
+		/*
+		 * When required, in MTL+ platforms we need to
+		 * set the CCS_FLUSH bit in the pipe control
+		 */
+		if (mode & EMIT_CCS_FLUSH &&
+		    GRAPHICS_VER_FULL(rq->i915) >= IP_VER(12, 70))
+			bit_group_0 |= PIPE_CONTROL_CCS_FLUSH;
+
 		bit_group_1 |= PIPE_CONTROL_TILE_CACHE_FLUSH;
 		bit_group_1 |= PIPE_CONTROL_FLUSH_L3;
 		bit_group_1 |= PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH;
drivers/gpu/drm/i915/gt/intel_engine_types.h +1 -0
index e99a6fa03d453..e2cae9d02bd62 100644
@@ -514,6 +514,7 @@ struct intel_engine_cs {
 	int		(*emit_flush)(struct i915_request *request, u32 mode);
 #define EMIT_INVALIDATE	BIT(0)
 #define EMIT_FLUSH	BIT(1)
+#define EMIT_CCS_FLUSH	BIT(2) /* MTL+ */
 #define EMIT_BARRIER	(EMIT_INVALIDATE | EMIT_FLUSH)
 	int		(*emit_bb_start)(struct i915_request *rq,
 					 u64 offset, u32 length,
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index 5d143e2a8db03..5df7cce23197c 100644
@@ -299,6 +299,7 @@
 #define   PIPE_CONTROL_QW_WRITE				(1<<14)
 #define   PIPE_CONTROL_POST_SYNC_OP_MASK                (3<<14)
 #define   PIPE_CONTROL_DEPTH_STALL			(1<<13)
+#define   PIPE_CONTROL_CCS_FLUSH			(1<<13) /* MTL+ */
 #define   PIPE_CONTROL_WRITE_FLUSH			(1<<12)
 #define   PIPE_CONTROL_RENDER_TARGET_CACHE_FLUSH	(1<<12) /* gen6+ */
 #define   PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE	(1<<11) /* MBZ on ILK */
Signature · 1 line
2.40.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#18 lore raw

PATCH v4 5/6 drm/i915/gt: Poll aux invalidation register bit on invalidation

In reply to Andi Shyti

From: Jonathan Cavitt <[email protected]>

For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 17 +++++++++++++----
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
 2 files changed, 14 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +13 -4
index aa2fb9d72745a..fbc70f3b7f2fd 100644
@@ -174,6 +174,16 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
 	*cs++ = AUX_INV;
 	*cs++ = MI_NOOP;
 
+	*cs++ = MI_SEMAPHORE_WAIT_TOKEN |
+		MI_SEMAPHORE_REGISTER_POLL |
+		MI_SEMAPHORE_POLL |
+		MI_SEMAPHORE_SAD_EQ_SDD;
+	*cs++ = 0;
+	*cs++ = i915_mmio_reg_offset(inv_reg) + gsi_offset;
+	*cs++ = 0;
+	*cs++ = 0;
+	*cs++ = MI_NOOP;
+
 	return cs;
 }
 
@@ -284,10 +294,9 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		else if (engine->class == COMPUTE_CLASS)
 			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
+		count = 8;
 		if (!HAS_FLAT_CCS(rq->engine->i915))
-			count = 8 + 4;
-		else
-			count = 8;
+			count += 10;
 
 		cs = intel_ring_begin(rq, count);
 		if (IS_ERR(cs))
@@ -330,7 +339,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 			aux_inv = rq->engine->mask &
 				~GENMASK(_BCS(I915_MAX_BCS - 1), BCS0);
 			if (aux_inv)
-				cmd += 4;
+				cmd += 10;
 		}
 	}
 
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index 5df7cce23197c..2bd8d98d21102 100644
@@ -121,6 +121,7 @@
 #define   MI_SEMAPHORE_TARGET(engine)	((engine)<<15)
 #define MI_SEMAPHORE_WAIT	MI_INSTR(0x1c, 2) /* GEN8+ */
 #define MI_SEMAPHORE_WAIT_TOKEN	MI_INSTR(0x1c, 3) /* GEN12+ */
+#define   MI_SEMAPHORE_REGISTER_POLL	(1 << 16)
 #define   MI_SEMAPHORE_POLL		(1 << 15)
 #define   MI_SEMAPHORE_SAD_GT_SDD	(0 << 12)
 #define   MI_SEMAPHORE_SAD_GTE_SDD	(1 << 12)
Signature · 1 line
2.40.1
Reviewed-by on v4 5/6
#19 lore raw

Re: [Intel-gfx] [PATCH v4 5/6] drm/i915/gt: Poll aux invalidation register bit on invalidation

Quoted 11 lines · Andi Shyti

From: Jonathan Cavitt <[email protected]>

For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+

Regards
Andrzej

Quoted 60 lines
---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 17 +++++++++++++----
  drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
  2 files changed, 14 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +13 -4
index aa2fb9d72745a..fbc70f3b7f2fd 100644
@@ -174,6 +174,16 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
  	*cs++ = AUX_INV;
  	*cs++ = MI_NOOP;
 
+	*cs++ = MI_SEMAPHORE_WAIT_TOKEN |
+		MI_SEMAPHORE_REGISTER_POLL |
+		MI_SEMAPHORE_POLL |
+		MI_SEMAPHORE_SAD_EQ_SDD;
+	*cs++ = 0;
+	*cs++ = i915_mmio_reg_offset(inv_reg) + gsi_offset;
+	*cs++ = 0;
+	*cs++ = 0;
+	*cs++ = MI_NOOP;
+
  	return cs;
  }
 
@@ -284,10 +294,9 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
  		else if (engine->class == COMPUTE_CLASS)
  			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
+		count = 8;
  		if (!HAS_FLAT_CCS(rq->engine->i915))
-			count = 8 + 4;
-		else
-			count = 8;
+			count += 10;
 
  		cs = intel_ring_begin(rq, count);
  		if (IS_ERR(cs))
@@ -330,7 +339,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
  			aux_inv = rq->engine->mask &
  				~GENMASK(_BCS(I915_MAX_BCS - 1), BCS0);
  			if (aux_inv)
-				cmd += 4;
+				cmd += 10;
  		}
  	}
 
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index 5df7cce23197c..2bd8d98d21102 100644
@@ -121,6 +121,7 @@
  #define   MI_SEMAPHORE_TARGET(engine)	((engine)<<15)
  #define MI_SEMAPHORE_WAIT	MI_INSTR(0x1c, 2) /* GEN8+ */
  #define MI_SEMAPHORE_WAIT_TOKEN	MI_INSTR(0x1c, 3) /* GEN12+ */
+#define   MI_SEMAPHORE_REGISTER_POLL	(1 << 16)
  #define   MI_SEMAPHORE_POLL		(1 << 15)
  #define   MI_SEMAPHORE_SAD_GT_SDD	(0 << 12)
  #define   MI_SEMAPHORE_SAD_GTE_SDD	(1 << 12)
Reviewed-by on v4 5/6
#20 lore raw

Re: [PATCH v4 5/6] drm/i915/gt: Poll aux invalidation register bit on invalidation

In reply to Andi Shyti
Quoted 21 lines · Andi Shyti

From: Jonathan Cavitt <[email protected]>

For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 17 +++++++++++++----
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
 2 files changed, 14 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
index aa2fb9d72745a..fbc70f3b7f2fd 100644

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 175

Quoted 2 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
@@ -174,6 +174,16 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
 	*cs++ = AUX_INV;
 	*cs++ = MI_NOOP;

We only need qword alignment for sequences of commands, not each individual command, right? So technically we could drop this noop...

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 185

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +9 -0
+	*cs++ = MI_SEMAPHORE_WAIT_TOKEN |
+		MI_SEMAPHORE_REGISTER_POLL |
+		MI_SEMAPHORE_POLL |
+		MI_SEMAPHORE_SAD_EQ_SDD;
+	*cs++ = 0;
+	*cs++ = i915_mmio_reg_offset(inv_reg) + gsi_offset;
+	*cs++ = 0;
+	*cs++ = 0;
+	*cs++ = MI_NOOP;

...and then we wouldn't need an extra one here.

If we drop the pair of noops, that would also change the # of dwords farther down too.

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode) · line 298

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -0
+
 	return cs;
 }
 
@@ -284,10 +294,9 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 		else if (engine->class == COMPUTE_CLASS)
 			flags &= ~PIPE_CONTROL_3D_ENGINE_FLAGS;
 
+		count = 8;
 		if (!HAS_FLAT_CCS(rq->engine->i915))

As noted on the earlier patch, we should probably make this check that the platform actually has AuxCCS.

Anyway, up to you whether you want to make that change or not. The extra noops don't actually hurt anything.

Quoted 31 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -4
-			count = 8 + 4;
-		else
-			count = 8;
+			count += 10;
 
 		cs = intel_ring_begin(rq, count);
 		if (IS_ERR(cs))
@@ -330,7 +339,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 			aux_inv = rq->engine->mask &
 				~GENMASK(_BCS(I915_MAX_BCS - 1), BCS0);
 			if (aux_inv)
-				cmd += 4;
+				cmd += 10;
 		}
 	}
 
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index 5df7cce23197c..2bd8d98d21102 100644
@@ -121,6 +121,7 @@
 #define   MI_SEMAPHORE_TARGET(engine)	((engine)<<15)
 #define MI_SEMAPHORE_WAIT	MI_INSTR(0x1c, 2) /* GEN8+ */
 #define MI_SEMAPHORE_WAIT_TOKEN	MI_INSTR(0x1c, 3) /* GEN12+ */
+#define   MI_SEMAPHORE_REGISTER_POLL	(1 << 16)
 #define   MI_SEMAPHORE_POLL		(1 << 15)
 #define   MI_SEMAPHORE_SAD_GT_SDD	(0 << 12)
 #define   MI_SEMAPHORE_SAD_GTE_SDD	(1 << 12)
Signature · 1 line
2.40.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#21 lore raw

PATCH v4 6/6 drm/i915/gt: Support aux invalidation on all engines

In reply to Andi Shyti

Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.

With this refactoring add more engines where the invalidation should be performed.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++---------
 drivers/gpu/drm/i915/gt/gen8_engine_cs.h |  3 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c      | 17 +------
 3 files changed, 44 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +40 -23
index fbc70f3b7f2fd..6d21a1ac06e73 100644
@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)
 	return MI_ARB_CHECK | 1 << 8 | state;
 }
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg)
+static u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs,
+				     const i915_reg_t inv_reg)
 {
 	u32 gsi_offset = gt->uncore->gsi_offset;
 
@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
 	return cs;
 }
 
+static i915_reg_t intel_get_aux_inv_reg(struct intel_engine_cs *engine)
+{
+	if (HAS_FLAT_CCS(engine->i915))
+		return _MMIO(0);
+
+	switch (engine->id) {
+	case RCS0:
+		return GEN12_CCS_AUX_INV;
+	case VCS0:
+		return GEN12_VD0_AUX_INV;
+	case VCS2:
+		return GEN12_VD2_AUX_INV;
+	case VECS0:
+		return GEN12_VE0_AUX_INV;
+	default:
+		return _MMIO(0);
+	}
+}
+
+static bool intel_engine_has_aux_inv(struct intel_engine_cs *engine)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+
+	return !!reg.reg;
+}
+
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+	struct intel_gt *gt = engine->gt;
+
+	return reg.reg ? gen12_emit_aux_table_inv(gt, cs, reg) : cs;
+}
+
 static int mtl_dummy_pipe_control(struct i915_request *rq)
 {
 	/* Wa_14016712196 */
@@ -311,11 +346,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 		cs = gen8_emit_pipe_control(cs, flags, LRC_PPHWSP_SCRATCH_ADDR);
 
-		if (!HAS_FLAT_CCS(rq->engine->i915)) {
-			/* hsdes: 1809175790 */
-			cs = gen12_emit_aux_table_inv(rq->engine->gt, cs,
-						      GEN12_CCS_AUX_INV);
-		}
+		cs = intel_emit_aux_table_inv(engine, cs);
 
 		*cs++ = preparser_disable(false);
 		intel_ring_advance(rq, cs);
@@ -326,21 +357,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 {
-	intel_engine_mask_t aux_inv = 0;
 	u32 cmd, *cs;
 
 	cmd = 4;
 	if (mode & EMIT_INVALIDATE) {
 		cmd += 2;
 
-		if (!HAS_FLAT_CCS(rq->engine->i915) &&
-		    (rq->engine->class == VIDEO_DECODE_CLASS ||
-		     rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) {
-			aux_inv = rq->engine->mask &
-				~GENMASK(_BCS(I915_MAX_BCS - 1), BCS0);
-			if (aux_inv)
-				cmd += 10;
-		}
+		if (intel_engine_has_aux_inv(rq->engine))
+			cmd += 10;
 	}
 
 	cs = intel_ring_begin(rq, cmd);
@@ -371,14 +395,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 	*cs++ = 0; /* upper addr */
 	*cs++ = 0; /* value */
 
-	if (aux_inv) { /* hsdes: 1809175790 */
-		if (rq->engine->class == VIDEO_DECODE_CLASS)
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VD0_AUX_INV);
-		else
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VE0_AUX_INV);
-	}
+	cs = intel_emit_aux_table_inv(rq->engine, cs);
 
 	if (mode & EMIT_INVALIDATE)
 		*cs++ = preparser_disable(false);
drivers/gpu/drm/i915/gt/gen8_engine_cs.h +2 -1
index 655e5c00ddc27..d938c94524510 100644
@@ -13,6 +13,7 @@
 #include "intel_gt_regs.h"
 #include "intel_gpu_commands.h"
 
+struct intel_engine_cs;
 struct intel_gt;
 struct i915_request;
 
@@ -46,7 +47,7 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg);
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs);
 
 static inline u32 *
 __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)
drivers/gpu/drm/i915/gt/intel_lrc.c +2 -15
index 235f3fab60a98..70054767c88c3 100644
@@ -1371,10 +1371,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
 	    IS_DG2_G11(ce->engine->i915))
 		cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0);
 
-	/* hsdes: 1809175790 */
-	if (!HAS_FLAT_CCS(ce->engine->i915))
-		cs = gen12_emit_aux_table_inv(ce->engine->gt,
-					      cs, GEN12_CCS_AUX_INV);
+	cs = intel_emit_aux_table_inv(ce->engine, cs);
 
 	/* Wa_16014892111 */
 	if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||
@@ -1399,17 +1396,7 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)
 						    PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE,
 						    0);
 
-	/* hsdes: 1809175790 */
-	if (!HAS_FLAT_CCS(ce->engine->i915)) {
-		if (ce->engine->class == VIDEO_DECODE_CLASS)
-			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VD0_AUX_INV);
-		else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS)
-			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VE0_AUX_INV);
-	}
-
-	return cs;
+	return intel_emit_aux_table_inv(ce->engine, cs);
 }
 
 static void
Signature · 1 line
2.40.1
#22 lore raw

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915/gt: Support aux invalidation on all engines

Quoted 31 lines · Andi Shyti

Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.

With this refactoring add more engines where the invalidation should be performed.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++---------
  drivers/gpu/drm/i915/gt/gen8_engine_cs.h |  3 +-
  drivers/gpu/drm/i915/gt/intel_lrc.c      | 17 +------
  3 files changed, 44 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
index fbc70f3b7f2fd..6d21a1ac06e73 100644
@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)
  	return MI_ARB_CHECK | 1 << 8 | state;
  }
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg)
+static u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs,
+				     const i915_reg_t inv_reg)
  {
  	u32 gsi_offset = gt->uncore->gsi_offset;
 

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 194

Quoted 7 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -0
@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
  	return cs;
  }
 
+static i915_reg_t intel_get_aux_inv_reg(struct intel_engine_cs *engine)
+{
+	if (HAS_FLAT_CCS(engine->i915))
+		return _MMIO(0);

Why not INVALID_MMIO_REG ? Here and below.

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+
+	switch (engine->id) {
+	case RCS0:
+		return GEN12_CCS_AUX_INV;
+	case VCS0:
+		return GEN12_VD0_AUX_INV;
+	case VCS2:
+		return GEN12_VD2_AUX_INV;
+	case VECS0:
+		return GEN12_VE0_AUX_INV;

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 214

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+	default:
+		return _MMIO(0);
+	}
+}
+
+static bool intel_engine_has_aux_inv(struct intel_engine_cs *engine)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+
+	return !!reg.reg;

return i915_mmio_reg_valid(intel_get_aux_inv_reg(engine));

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 224

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+}
+
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+	struct intel_gt *gt = engine->gt;
+
+	return reg.reg ? gen12_emit_aux_table_inv(gt, cs, reg) : cs;
+}
+

I am not sure about prefixes, IMHO gen12_ instead of intel_ is more adequate as this is only gen12 feature, works only on gen12, and is called from gen12 context, up to you. In any case we can squash intel_emit_aux_table_inv and gen12_emit_aux_table_inv into one function, am I right?

Regards
Andrzej

Quoted 112 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -22
  static int mtl_dummy_pipe_control(struct i915_request *rq)
  {
  	/* Wa_14016712196 */
@@ -311,11 +346,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
  		cs = gen8_emit_pipe_control(cs, flags, LRC_PPHWSP_SCRATCH_ADDR);
 
-		if (!HAS_FLAT_CCS(rq->engine->i915)) {
-			/* hsdes: 1809175790 */
-			cs = gen12_emit_aux_table_inv(rq->engine->gt, cs,
-						      GEN12_CCS_AUX_INV);
-		}
+		cs = intel_emit_aux_table_inv(engine, cs);
 
  		*cs++ = preparser_disable(false);
  		intel_ring_advance(rq, cs);
@@ -326,21 +357,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
  int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
  {
-	intel_engine_mask_t aux_inv = 0;
  	u32 cmd, *cs;
 
  	cmd = 4;
  	if (mode & EMIT_INVALIDATE) {
  		cmd += 2;
 
-		if (!HAS_FLAT_CCS(rq->engine->i915) &&
-		    (rq->engine->class == VIDEO_DECODE_CLASS ||
-		     rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) {
-			aux_inv = rq->engine->mask &
-				~GENMASK(_BCS(I915_MAX_BCS - 1), BCS0);
-			if (aux_inv)
-				cmd += 10;
-		}
+		if (intel_engine_has_aux_inv(rq->engine))
+			cmd += 10;
  	}
 
  	cs = intel_ring_begin(rq, cmd);
@@ -371,14 +395,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
  	*cs++ = 0; /* upper addr */
  	*cs++ = 0; /* value */
 
-	if (aux_inv) { /* hsdes: 1809175790 */
-		if (rq->engine->class == VIDEO_DECODE_CLASS)
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VD0_AUX_INV);
-		else
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VE0_AUX_INV);
-	}
+	cs = intel_emit_aux_table_inv(rq->engine, cs);
 
  	if (mode & EMIT_INVALIDATE)
  		*cs++ = preparser_disable(false);
drivers/gpu/drm/i915/gt/gen8_engine_cs.h +2 -1
index 655e5c00ddc27..d938c94524510 100644
@@ -13,6 +13,7 @@
  #include "intel_gt_regs.h"
  #include "intel_gpu_commands.h"
 
+struct intel_engine_cs;
  struct intel_gt;
  struct i915_request;
 
@@ -46,7 +47,7 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
  u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
  u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg);
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs);
 
  static inline u32 *
  __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)
drivers/gpu/drm/i915/gt/intel_lrc.c +2 -15
index 235f3fab60a98..70054767c88c3 100644
@@ -1371,10 +1371,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
  	    IS_DG2_G11(ce->engine->i915))
  		cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0);
 
-	/* hsdes: 1809175790 */
-	if (!HAS_FLAT_CCS(ce->engine->i915))
-		cs = gen12_emit_aux_table_inv(ce->engine->gt,
-					      cs, GEN12_CCS_AUX_INV);
+	cs = intel_emit_aux_table_inv(ce->engine, cs);
 
  	/* Wa_16014892111 */
  	if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||
@@ -1399,17 +1396,7 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)
  						    PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE,
  						    0);
 
-	/* hsdes: 1809175790 */
-	if (!HAS_FLAT_CCS(ce->engine->i915)) {
-		if (ce->engine->class == VIDEO_DECODE_CLASS)
-			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VD0_AUX_INV);
-		else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS)
-			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VE0_AUX_INV);
-	}
-
-	return cs;
+	return intel_emit_aux_table_inv(ce->engine, cs);
  }
 
  static void
author
#23 lore raw

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915/gt: Support aux invalidation on all engines

Hi Andrzej,

Quoted 62 lines · Andrzej Hajda
Quoted 29 lines · Andi Shyti

Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.

With this refactoring add more engines where the invalidation should be performed.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++---------
  drivers/gpu/drm/i915/gt/gen8_engine_cs.h |  3 +-
  drivers/gpu/drm/i915/gt/intel_lrc.c      | 17 +------
  3 files changed, 44 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
index fbc70f3b7f2fd..6d21a1ac06e73 100644
@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)
  	return MI_ARB_CHECK | 1 << 8 | state;
  }
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg)
+static u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs,
+				     const i915_reg_t inv_reg)
  {
  	u32 gsi_offset = gt->uncore->gsi_offset;

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 193

Quoted 6 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -0
@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
  	return cs;
  }
+static i915_reg_t intel_get_aux_inv_reg(struct intel_engine_cs *engine)
+{
+	if (HAS_FLAT_CCS(engine->i915))
+		return _MMIO(0);

Why not INVALID_MMIO_REG ? Here and below.

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+
+	switch (engine->id) {
+	case RCS0:
+		return GEN12_CCS_AUX_INV;
+	case VCS0:
+		return GEN12_VD0_AUX_INV;
+	case VCS2:
+		return GEN12_VD2_AUX_INV;
+	case VECS0:
+		return GEN12_VE0_AUX_INV;

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 214

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+	default:
+		return _MMIO(0);
+	}
+}
+
+static bool intel_engine_has_aux_inv(struct intel_engine_cs *engine)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+
+	return !!reg.reg;

return i915_mmio_reg_valid(intel_get_aux_inv_reg(engine));

Quoted 15 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 224

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+}
+
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+	struct intel_gt *gt = engine->gt;
+
+	return reg.reg ? gen12_emit_aux_table_inv(gt, cs, reg) : cs;
+}
+

I am not sure about prefixes, IMHO gen12_ instead of intel_ is more adequate as this is only gen12 feature, works only on gen12, and is called from gen12 context, up to you. In any case we can squash intel_emit_aux_table_inv and gen12_emit_aux_table_inv into one function, am I right?

you and Matt have made exactly the same comments... will fix them, Thank you!

Andi

#24 lore raw

Re: [PATCH v4 6/6] drm/i915/gt: Support aux invalidation on all engines

In reply to Andi Shyti
Quoted 31 lines · Andi Shyti

Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.

With this refactoring add more engines where the invalidation should be performed.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++---------
 drivers/gpu/drm/i915/gt/gen8_engine_cs.h |  3 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c      | 17 +------
 3 files changed, 44 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
index fbc70f3b7f2fd..6d21a1ac06e73 100644
@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)
 	return MI_ARB_CHECK | 1 << 8 | state;
 }
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg)
+static u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs,
+				     const i915_reg_t inv_reg)
 {
 	u32 gsi_offset = gt->uncore->gsi_offset;
 

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 191

Quoted 4 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1 -0
@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
 	return cs;
 }
 
+static i915_reg_t intel_get_aux_inv_reg(struct intel_engine_cs *engine)

Generally we try to avoid putting "intel_" and "i915_" prefixes on static functions.

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 204

Quoted 13 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +13 -0
+{
+	if (HAS_FLAT_CCS(engine->i915))
+		return _MMIO(0);
+
+	switch (engine->id) {
+	case RCS0:
+		return GEN12_CCS_AUX_INV;
+	case VCS0:
+		return GEN12_VD0_AUX_INV;
+	case VCS2:
+		return GEN12_VD2_AUX_INV;
+	case VECS0:
+		return GEN12_VE0_AUX_INV;

We need CCS0 here (0x42c0). And on graphics versions 12.70 and beyond we also need BCS0 too (0x4248) since the blitter gained the ability to interpret CCS compression.

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 206

Quoted 2 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -0
+	default:
+		return _MMIO(0);

It might be cleaner to use INVALID_MMIO_REG here (and then check for i915_mmio_reg_valid() below).

Quoted 7 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +7 -0
+	}
+}
+
+static bool intel_engine_has_aux_inv(struct intel_engine_cs *engine)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 223

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+	return !!reg.reg;
+}
+
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+	struct intel_gt *gt = engine->gt;
+
+	return reg.reg ? gen12_emit_aux_table_inv(gt, cs, reg) : cs;
+}

Rather than adding this new wrapper function, can we just do the register lookup at the top of gen12_emit_aux_table_inv() (and bail out of that function early if there isn't a valid register)?

Keeping the non-static function as the one with "gen12" in the name also helps reduce confusion about whether this is something that older platforms should have been calling as well.

Matt

Quoted 116 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -22
+
 static int mtl_dummy_pipe_control(struct i915_request *rq)
 {
 	/* Wa_14016712196 */
@@ -311,11 +346,7 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 		cs = gen8_emit_pipe_control(cs, flags, LRC_PPHWSP_SCRATCH_ADDR);
 
-		if (!HAS_FLAT_CCS(rq->engine->i915)) {
-			/* hsdes: 1809175790 */
-			cs = gen12_emit_aux_table_inv(rq->engine->gt, cs,
-						      GEN12_CCS_AUX_INV);
-		}
+		cs = intel_emit_aux_table_inv(engine, cs);
 
 		*cs++ = preparser_disable(false);
 		intel_ring_advance(rq, cs);
@@ -326,21 +357,14 @@ int gen12_emit_flush_rcs(struct i915_request *rq, u32 mode)
 
 int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 {
-	intel_engine_mask_t aux_inv = 0;
 	u32 cmd, *cs;
 
 	cmd = 4;
 	if (mode & EMIT_INVALIDATE) {
 		cmd += 2;
 
-		if (!HAS_FLAT_CCS(rq->engine->i915) &&
-		    (rq->engine->class == VIDEO_DECODE_CLASS ||
-		     rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) {
-			aux_inv = rq->engine->mask &
-				~GENMASK(_BCS(I915_MAX_BCS - 1), BCS0);
-			if (aux_inv)
-				cmd += 10;
-		}
+		if (intel_engine_has_aux_inv(rq->engine))
+			cmd += 10;
 	}
 
 	cs = intel_ring_begin(rq, cmd);
@@ -371,14 +395,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 	*cs++ = 0; /* upper addr */
 	*cs++ = 0; /* value */
 
-	if (aux_inv) { /* hsdes: 1809175790 */
-		if (rq->engine->class == VIDEO_DECODE_CLASS)
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VD0_AUX_INV);
-		else
-			cs = gen12_emit_aux_table_inv(rq->engine->gt,
-						      cs, GEN12_VE0_AUX_INV);
-	}
+	cs = intel_emit_aux_table_inv(rq->engine, cs);
 
 	if (mode & EMIT_INVALIDATE)
 		*cs++ = preparser_disable(false);
drivers/gpu/drm/i915/gt/gen8_engine_cs.h +2 -1
index 655e5c00ddc27..d938c94524510 100644
@@ -13,6 +13,7 @@
 #include "intel_gt_regs.h"
 #include "intel_gpu_commands.h"
 
+struct intel_engine_cs;
 struct intel_gt;
 struct i915_request;
 
@@ -46,7 +47,7 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg);
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs);
 
 static inline u32 *
 __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)
drivers/gpu/drm/i915/gt/intel_lrc.c +2 -15
index 235f3fab60a98..70054767c88c3 100644
@@ -1371,10 +1371,7 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
 	    IS_DG2_G11(ce->engine->i915))
 		cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0);
 
-	/* hsdes: 1809175790 */
-	if (!HAS_FLAT_CCS(ce->engine->i915))
-		cs = gen12_emit_aux_table_inv(ce->engine->gt,
-					      cs, GEN12_CCS_AUX_INV);
+	cs = intel_emit_aux_table_inv(ce->engine, cs);
 
 	/* Wa_16014892111 */
 	if (IS_MTL_GRAPHICS_STEP(ce->engine->i915, M, STEP_A0, STEP_B0) ||
@@ -1399,17 +1396,7 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)
 						    PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE,
 						    0);
 
-	/* hsdes: 1809175790 */
-	if (!HAS_FLAT_CCS(ce->engine->i915)) {
-		if (ce->engine->class == VIDEO_DECODE_CLASS)
-			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VD0_AUX_INV);
-		else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS)
-			cs = gen12_emit_aux_table_inv(ce->engine->gt,
-						      cs, GEN12_VE0_AUX_INV);
-	}
-
-	return cs;
+	return intel_emit_aux_table_inv(ce->engine, cs);
 }
 
 static void
Signature · 1 line
2.40.1
Signature · 4 lines
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation
author
#25 lore raw

Re: [PATCH v4 6/6] drm/i915/gt: Support aux invalidation on all engines

Hi Matt,

Quoted 49 lines · Matt Roper
Quoted 31 lines · Andi Shyti

Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation.

With this refactoring add more engines where the invalidation should be performed.

Fixes 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines")
Cc <[email protected]> # v5.8+
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 63 +++++++++++++++---------
 drivers/gpu/drm/i915/gt/gen8_engine_cs.h |  3 +-
 drivers/gpu/drm/i915/gt/intel_lrc.c      | 17 +------
 3 files changed, 44 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -1
index fbc70f3b7f2fd..6d21a1ac06e73 100644
@@ -165,7 +165,8 @@ static u32 preparser_disable(bool state)
 	return MI_ARB_CHECK | 1 << 8 | state;
 }
 
-u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv_reg)
+static u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs,
+				     const i915_reg_t inv_reg)
 {
 	u32 gsi_offset = gt->uncore->gsi_offset;
 

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 191

Quoted 4 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1 -0
@@ -187,6 +188,40 @@ u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv
 	return cs;
 }
 
+static i915_reg_t intel_get_aux_inv_reg(struct intel_engine_cs *engine)

Generally we try to avoid putting "intel_" and "i915_" prefixes on static functions.

Quoted 9 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +9 -0
+{
+	if (HAS_FLAT_CCS(engine->i915))
+		return _MMIO(0);
+
+	switch (engine->id) {
+	case RCS0:
+		return GEN12_CCS_AUX_INV;
+	case VCS0:
+		return GEN12_VD0_AUX_INV;
Quoted 8 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 204

Quoted 4 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -0
+	case VCS2:
+		return GEN12_VD2_AUX_INV;
+	case VECS0:
+		return GEN12_VE0_AUX_INV;

We need CCS0 here (0x42c0). And on graphics versions 12.70 and beyond we also need BCS0 too (0x4248) since the blitter gained the ability to interpret CCS compression.

Thanks, will add.

Quoted 28 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 206

Quoted 2 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +2 -0
+	default:
+		return _MMIO(0);

It might be cleaner to use INVALID_MMIO_REG here (and then check for i915_mmio_reg_valid() below).

Quoted 7 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +7 -0
+	}
+}
+
+static bool intel_engine_has_aux_inv(struct intel_engine_cs *engine)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+

drivers/gpu/drm/i915/gt/gen8_engine_cs.c u32 *gen12_emit_aux_table_inv(struct intel_gt *gt, u32 *cs, const i915_reg_t inv · line 223

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -0
+	return !!reg.reg;
+}
+
+u32 *intel_emit_aux_table_inv(struct intel_engine_cs *engine, u32 *cs)
+{
+	i915_reg_t reg = intel_get_aux_inv_reg(engine);
+	struct intel_gt *gt = engine->gt;
+
+	return reg.reg ? gen12_emit_aux_table_inv(gt, cs, reg) : cs;
+}

Rather than adding this new wrapper function, can we just do the register lookup at the top of gen12_emit_aux_table_inv() (and bail out of that function early if there isn't a valid register)?

Quoted 3 lines

Keeping the non-static function as the one with "gen12" in the name also helps reduce confusion about whether this is something that older platforms should have been calling as well.

You and Andrzej have made the same comments, will fix them.

BTW, this set of functions are doing more or less a similar thing to what you have done here[*]. I will add the PVC flag.

Thank you!
Andi

[*] https://patchwork.freedesktop.org/patch/539304/?series=118334&rev=1

#26 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Update AUX invalidation sequence (rev4)

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: Update AUX invalidation sequence (rev4)
URL : https://patchwork.freedesktop.org/series/119798/
State : warning

== Summary ==

Error: dim checkpatch failed
ab8c9adb02af drm/i915/gt: Cleanup aux invalidation registers 3c567ec2d453 drm/i915/gt: Ensure memory quiesced before invalidation a6eeea6d59a0 drm/i915/gt: Rename flags with bit_group_X according to the datasheet -:7: WARNING:TYPO_SPELLING: 'allign' may be misspelled - perhaps 'align'? #7:
In preparation of the next patch allign with the datasheet (BSPEC

                                 ^^^^^^

total: 0 errors, 1 warnings, 0 checks, 57 lines checked b4d0e00cb97c drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control -:66: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #66: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:302:
+#define PIPE_CONTROL_CCS_FLUSH (1<<13) /* MTL+ */

                                 			  ^

total: 0 errors, 0 warnings, 1 checks, 36 lines checked 61c0d8597e59 drm/i915/gt: Poll aux invalidation register bit on invalidation 2293a4e3f5da drm/i915/gt: Support aux invalidation on all engines

#28 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for Update AUX invalidation sequence (rev4)

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: Update AUX invalidation sequence (rev4)
URL : https://patchwork.freedesktop.org/series/119798/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13392 -> Patchwork_119798v4
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/index.html

Participating hosts (43 -> 43)
------------------------------

Additional (1): bat-rpls-2
Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in Patchwork_119798v4 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@fbdev@info:
- bat-rpls-2: NOTRUN -> [SKIP][2] ([i915#1849] / [i915#2582])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#2582]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#3282])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@gem_tiled_pread_basic.html

* igt@i915_module_load@load:
- bat-mtlp-6: [PASS][6] -> [ABORT][7] ([i915#8141])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-6/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-mtlp-6/igt@[email protected]
- bat-mtlp-8: [PASS][8] -> [ABORT][9] ([i915#8141])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-8/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-mtlp-8/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][10] ([i915#7561])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- fi-cfl-guc: [PASS][11] -> [FAIL][12] ([i915#7940])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-cfl-guc/igt@[email protected]
- fi-cfl-8700k: [PASS][13] -> [FAIL][14] ([i915#7940])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-8700k/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-cfl-8700k/igt@[email protected]
- bat-adlp-9: [PASS][15] -> [ABORT][16] ([i915#7977] / [i915#8668])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-adlp-9/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-adlp-9/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [PASS][17] -> [FAIL][18] ([i915#7940])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-skl-guc/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-skl-guc/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][19] ([i915#6621])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][20] ([i915#4258] / [i915#7913])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@i915_selftest@live@gt_pm.html

* igt@i915_selftest@live@hangcheck:
- fi-skl-guc: [PASS][21] -> [DMESG-FAIL][22] ([i915#8723])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-skl-guc/igt@i915_selftest@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-skl-guc/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][23] -> [ABORT][24] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rpls-1/igt@i915_selftest@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-1/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][25] ([i915#6367])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][26] ([i915#1845]) +15 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][27] ([i915#7828]) +8 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][28] ([i915#3637]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][29] ([fdo#109285])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][30] ([i915#1849])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: NOTRUN -> [ABORT][31] ([i915#8434] / [i915#8442] / [i915#8668])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html

* igt@kms_psr@primary_page_flip:
- bat-rplp-1: NOTRUN -> [SKIP][32] ([i915#1072]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rplp-1/igt@kms_psr@primary_page_flip.html

* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][33] ([i915#1072]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html

* igt@kms_setmode@basic-clone-single-crtc:
- bat-rpls-2: NOTRUN -> [SKIP][34] ([i915#3555])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][35] ([fdo#109295] / [i915#1845] / [i915#3708])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-rpls-2: NOTRUN -> [SKIP][36] ([fdo#109295] / [i915#3708]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rpls-2/igt@[email protected]

#### Possible fixes ####

* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [FAIL][37] ([i915#7940]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-8109u/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-cfl-8109u/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [FAIL][39] ([i915#7940]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-rkl-11600/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-rkl-11600/igt@[email protected]
- fi-kbl-7567u: [FAIL][41] ([i915#7940]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-kbl-7567u/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-kbl-7567u/igt@[email protected]
- fi-tgl-1115g4: [FAIL][43] ([i915#7940]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-tgl-1115g4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-tgl-1115g4/igt@[email protected]

* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][45] ([i915#7699]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-11/igt@i915_selftest@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-dg2-11/igt@i915_selftest@[email protected]

* igt@kms_chamelium_frames@dp-crc-fast:
- {bat-dg2-13}: [DMESG-WARN][47] ([Intel XE#485]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-13/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-dg2-13/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][49] ([i915#8442] / [i915#8668]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]

#### Warnings ####

* igt@i915_module_load@load:
- bat-adlp-11: [DMESG-WARN][51] ([i915#4423]) -> [ABORT][52] ([i915#4423])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-adlp-11/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/bat-adlp-11/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [FAIL][53] ([i915#7940]) -> [SKIP][54] ([fdo#109271])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-kbl-guc/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/fi-kbl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#485]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/485
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
[i915#8141]: https://gitlab.freedesktop.org/drm/intel/issues/8141
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8723]: https://gitlab.freedesktop.org/drm/intel/issues/8723

Build changes
-------------

* Linux: CI_DRM_13392 -> Patchwork_119798v4

CI-20190529: 20190529
CI_DRM_13392: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_119798v4: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

12cb457e12f2 drm/i915/gt: Support aux invalidation on all engines 89b1766492ac drm/i915/gt: Poll aux invalidation register bit on invalidation 446aebccf072 drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control 742ae10b5f0a drm/i915/gt: Rename flags with bit_group_X according to the datasheet 181599349c9e drm/i915/gt: Ensure memory quiesced before invalidation 84192e22b302 drm/i915/gt: Cleanup aux invalidation registers

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/index.html

#29 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for Update AUX invalidation sequence (rev4)

In reply to Andi Shyti
== Series Details ==

== Series Details ==

Series: Update AUX invalidation sequence (rev4)
URL : https://patchwork.freedesktop.org/series/119798/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13392_full -> Patchwork_119798v4_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_119798v4_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_119798v4_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (10 -> 11)
------------------------------

Additional (1): shard-rkl0

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_119798v4_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_vblank@pipe-a-accuracy-idle:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk6/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk4/igt@[email protected]

* igt@perf@stress-open-close@0-rcs0:
- shard-glk: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk8/igt@perf@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk1/igt@perf@[email protected]

Known issues
------------

Here are the changes found in Patchwork_119798v4_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@api_intel_bb@object-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][5] ([i915#8411])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_basic@multigpu-create-close:
- shard-dg2: NOTRUN -> [SKIP][6] ([i915#7697])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][7] -> [FAIL][8] ([i915#6268])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-1/igt@[email protected]

* igt@gem_ctx_persistence@processes:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-snb5/igt@[email protected]

* igt@gem_eio@hibernate:
- shard-dg2: NOTRUN -> [ABORT][10] ([i915#7975] / [i915#8213])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-rkl: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-1/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fence@submit67:
- shard-dg2: NOTRUN -> [SKIP][13] ([i915#4812])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-dg2: NOTRUN -> [SKIP][14] ([i915#3539] / [i915#4852])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_mmap_gtt@ptrace:
- shard-dg2: NOTRUN -> [SKIP][15] ([i915#4077]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_render_copy@yf-tiled-ccs-to-linear:
- shard-dg2: NOTRUN -> [SKIP][16] ([i915#5190])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-dg2: NOTRUN -> [SKIP][17] ([i915#4079])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@i915_pm_dc@dc5-psr:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#658])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@i915_pm_rpm@cursor-dpms:
- shard-tglu: [PASS][19] -> [FAIL][20] ([i915#7940]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-tglu-2/igt@[email protected]

* igt@i915_pm_rpm@i2c:
- shard-dg2: [PASS][21] -> [FAIL][22] ([i915#8717])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-12/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-2/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp:
- shard-rkl: [PASS][23] -> [SKIP][24] ([i915#1397])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-1/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [PASS][25] -> [SKIP][26] ([i915#1397]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-10/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][27] -> [DMESG-FAIL][28] ([i915#5334])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-apl3/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_suspend@fence-restore-untiled:
- shard-snb: NOTRUN -> [DMESG-WARN][29] ([i915#8841])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-snb5/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglu: [PASS][30] -> [FAIL][31] ([i915#3743])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-tglu-2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-rkl: [PASS][32] -> [FAIL][33] ([i915#3743])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#4538] / [i915#5190])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][35] ([i915#3689] / [i915#3886] / [i915#5354])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#3689] / [i915#5354]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html

* igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#4087]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-7/igt@kms_cdclk@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-dg2: NOTRUN -> [SKIP][38] ([i915#7118]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-3/igt@[email protected]

* igt@kms_content_protection@srm@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][39] ([i915#7173])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#3359])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- shard-dg2: NOTRUN -> [SKIP][41] ([i915#3555])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][42] -> [FAIL][43] ([i915#79])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk2/igt@kms_flip@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][44] -> [FAIL][45] ([i915#2122])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk9/igt@kms_flip@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk9/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-dg2: [PASS][46] -> [FAIL][47] ([i915#6880])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][48] ([i915#5354]) +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271]) +97 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-snb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#3458]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-dg2: NOTRUN -> [SKIP][51] ([fdo#109274] / [i915#5354])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-2:
- shard-dg2: NOTRUN -> [FAIL][52] ([i915#8292])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-12/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-dp-2:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#5176]) +11 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-12/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#5176]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][55] ([i915#5235]) +5 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#5235]) +19 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-10/igt@kms_plane_scaling@[email protected]

* igt@kms_rotation_crc@primary-rotation-90:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#4235])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@[email protected]

* igt@kms_vblank@pipe-c-ts-continuation-dpms-suspend:
- shard-dg2: [PASS][58] -> [FAIL][59] ([fdo#103375])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-3/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-5/igt@[email protected]

* igt@runner@aborted:
- shard-mtlp: NOTRUN -> ([FAIL][60], [FAIL][61], [FAIL][62], [FAIL][63], [FAIL][64], [FAIL][65], [FAIL][66], [FAIL][67], [FAIL][68], [FAIL][69], [FAIL][70], [FAIL][71], [FAIL][72], [FAIL][73], [FAIL][74], [FAIL][75], [FAIL][76], [FAIL][77], [FAIL][78], [FAIL][79], [FAIL][80], [FAIL][81], [FAIL][82], [FAIL][83], [FAIL][84]) ([i915#7812])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-3/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-8/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-6/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-8/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-5/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-1/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-4/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-8/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-6/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-5/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-4/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-7/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-5/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-7/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-7/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-5/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-mtlp-1/igt@[email protected]

* igt@vc4/vc4_tiling@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#7711]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-6/igt@vc4/[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][86] ([i915#7742]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-1/igt@drm_fdinfo@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-6/igt@drm_fdinfo@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-rkl: [FAIL][88] ([i915#2842]) -> [PASS][89] +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@gem_exec_fair@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s3@lmem0:
- shard-dg2: [FAIL][90] ([fdo#103375]) -> [PASS][91] +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-2/igt@gem_exec_suspend@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-7/igt@gem_exec_suspend@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-dg2: [SKIP][92] ([i915#1937]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-11/igt@i915_pm_lpsp@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-12/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rpm@dpms-lpsp:
- shard-rkl: [SKIP][94] ([i915#1397]) -> [PASS][95] +2 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-6/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-7/igt@[email protected]

* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [SKIP][96] ([i915#1397]) -> [PASS][97] +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-12/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-2/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-tglu: [FAIL][98] ([i915#7940]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-6/igt@i915_pm_rpm@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-tglu-8/igt@i915_pm_rpm@[email protected]

* igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: [SKIP][100] ([i915#1397]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg1-18/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg1-19/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][102] ([i915#2346]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk4/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk8/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][104] ([i915#79]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk2/igt@kms_flip@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [FAIL][106] ([i915#2122]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk3/igt@kms_flip@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3:
- shard-dg2: [FAIL][108] ([i915#79]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-5/igt@kms_flip@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-1/igt@kms_flip@[email protected]

* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][110] ([i915#7484]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-1/igt@perf@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-12/igt@perf@[email protected]

#### Warnings ####

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglu: [FAIL][112] ([i915#2842]) -> [FAIL][113] ([i915#2876])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-4/igt@gem_exec_fair@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-tglu-5/igt@gem_exec_fair@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- shard-rkl: [SKIP][114] ([fdo#109285]) -> [SKIP][115] ([fdo#109285] / [i915#4098])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-7/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-rkl-1/igt@[email protected]

* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [INCOMPLETE][116] ([i915#5493]) -> [CRASH][117] ([i915#7331])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-3/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/shard-dg2-5/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8717]: https://gitlab.freedesktop.org/drm/intel/issues/8717
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841

Build changes
-------------

* Linux: CI_DRM_13392 -> Patchwork_119798v4

CI-20190529: 20190529
CI_DRM_13392: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_119798v4: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119798v4/index.html