Skip to contentSkip to conversation

dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA

PATCH Applied Dinh Nguyen 3 participants 3 messages Jul 19, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA

The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA platforms, thus it not required for all platforms.

While at it, update my email address.

---
v2: remove the need for else statement since "altr,modrst-offset" is
already allowed

---
 .../devicetree/bindings/reset/altr,rst-mgr.yaml      | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml +10 -2
index 4379cec6b35a..761c70cf9ddf 100644
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Altera SOCFPGA Reset Manager
 
 maintainers:
-  - Dinh Nguyen <[email protected]>
+  - Dinh Nguyen <[email protected]>
 
 properties:
   compatible:
@@ -32,9 +32,17 @@ properties:
 required:
   - compatible
   - reg
-  - altr,modrst-offset
   - '#reset-cells'
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: altr,stratix10-rst-mgr
+then:
+  properties:
+    altr,modrst-offset: false
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.25.1
Acked-by on v2 1/1
#1 lore raw
Quoted 6 lines · Dinh Nguyen

The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA platforms, thus it not required for all platforms.

While at it, update my email address.

Thanks,
Conor.

Quoted 42 lines

---
v2: remove the need for else statement since "altr,modrst-offset" is
already allowed

---
 .../devicetree/bindings/reset/altr,rst-mgr.yaml      | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml +10 -2
index 4379cec6b35a..761c70cf9ddf 100644
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Altera SOCFPGA Reset Manager
 
 maintainers:
-  - Dinh Nguyen <[email protected]>
+  - Dinh Nguyen <[email protected]>
 
 properties:
   compatible:
@@ -32,9 +32,17 @@ properties:
 required:
   - compatible
   - reg
-  - altr,modrst-offset
   - '#reset-cells'
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: altr,stratix10-rst-mgr
+then:
+  properties:
+    altr,modrst-offset: false
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.25.1
maintainer Applied
#2 lore raw
In reply to Dinh Nguyen
Quoted 5 lines · Dinh Nguyen

The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA platforms, thus it not required for all platforms.

While at it, update my email address.

Quoted 8 lines

---
v2: remove the need for else statement since "altr,modrst-offset" is
already allowed

---
 .../devicetree/bindings/reset/altr,rst-mgr.yaml      | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Applied, thanks!