Skip to contentSkip to conversation

dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA

PATCH Superseded Dinh Nguyen 2 participants 2 messages Jul 18, 2023

Subsystems (2)
Device tree bindings Reset controller framework

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Dinh Nguyen

author
#0 lore raw

PATCH 1/1 dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA

The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA platforms, thus it not required for all platforms.

While at it, update my email address.

Signed-off-by Dinh Nguyen <[email protected]>
---
 .../devicetree/bindings/reset/altr,rst-mgr.yaml   | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml +13 -2
index 4379cec6b35a..7796408d2545 100644
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Altera SOCFPGA Reset Manager
 
 maintainers:
-  - Dinh Nguyen <[email protected]>
+  - Dinh Nguyen <[email protected]>
 
 properties:
   compatible:

@@ -32,9 +32,20 @@ properties:
 required:
   - compatible
   - reg
-  - altr,modrst-offset
   - '#reset-cells'
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: altr,stratix10-rst-mgr
+then:
+  properties:
+    altr,modrst-offset: false
+else:
+  properties:
+    altr,modrst-offset: true
+
 additionalProperties: false
 
 examples:
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 31 lines · Dinh Nguyen

The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA platforms, thus it not required for all platforms.

While at it, update my email address.

Signed-off-by Dinh Nguyen <[email protected]>
---
 .../devicetree/bindings/reset/altr,rst-mgr.yaml   | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml +2 -2
index 4379cec6b35a..7796408d2545 100644
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
 title: Altera SOCFPGA Reset Manager
 
 maintainers:
-  - Dinh Nguyen <[email protected]>
+  - Dinh Nguyen <[email protected]>
 
 properties:
   compatible:

@@ -32,9 +32,20 @@ properties:
 required:
   - compatible
   - reg
-  - altr,modrst-offset
   - '#reset-cells'
 
+if:

Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml properties: · line 47

Quoted 10 lines
Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml +10 -0
+  properties:
+    compatible:
+      contains:
+        const: altr,stratix10-rst-mgr
+then:
+  properties:
+    altr,modrst-offset: false
+else:
+  properties:
+    altr,modrst-offset: true

You don't need the else clause. "altr,modrst-offset" is already allowed by default.

Rob