Skip to contentSkip to conversation

board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity

PATCH Superseded Mihai Sain 2 participants 4 messages Jul 20, 2023 – Jul 24, 2023

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Mihai Sain

author
#0 lore raw

PATCH 1/1 board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity

Add initial support for sama5d29_curiosity board.

Hardware:
SoC: SAMA5D29 500 MHz
DRAM: LPDDR2 512 MiB
PMIC: MCP16502
Debug: UART0
Flash: QSPI NOR 8 MiB
RGB LCD connector
Mikrobus connectors x 2
SD-Card connectors x 2
USB 2.0 x 2

---
 arch/arm/dts/Makefile                         |   3 +
 .../dts/at91-sama5d29_curiosity-u-boot.dtsi   |  55 +++++
 arch/arm/dts/at91-sama5d29_curiosity.dts      | 219 ++++++++++++++++++
 arch/arm/mach-at91/Kconfig                    |  12 +
 board/atmel/sama5d29_curiosity/Kconfig        |  15 ++
 board/atmel/sama5d29_curiosity/MAINTAINERS    |   8 +
 board/atmel/sama5d29_curiosity/Makefile       |   7 +
 .../sama5d29_curiosity/sama5d29_curiosity.c   |  86 +++++++
 configs/sama5d29_curiosity_mmc1_defconfig     | 122 ++++++++++
 configs/sama5d29_curiosity_mmc_defconfig      | 121 ++++++++++
 .../sama5d29_curiosity_qspiflash_defconfig    | 121 ++++++++++
 include/configs/sama5d29_curiosity.h          |  20 ++
 12 files changed, 789 insertions(+)
 create mode 100644 arch/arm/dts/at91-sama5d29_curiosity-u-boot.dtsi
 create mode 100644 arch/arm/dts/at91-sama5d29_curiosity.dts
 create mode 100644 board/atmel/sama5d29_curiosity/Kconfig
 create mode 100644 board/atmel/sama5d29_curiosity/MAINTAINERS
 create mode 100644 board/atmel/sama5d29_curiosity/Makefile
 create mode 100644 board/atmel/sama5d29_curiosity/sama5d29_curiosity.c
 create mode 100644 configs/sama5d29_curiosity_mmc1_defconfig
 create mode 100644 configs/sama5d29_curiosity_mmc_defconfig
 create mode 100644 configs/sama5d29_curiosity_qspiflash_defconfig
 create mode 100644 include/configs/sama5d29_curiosity.h
arch/arm/dts/Makefile +3 -0
index 07b26df275..bf0dc876d4 100644
@@ -1169,6 +1169,9 @@ dtb-$(CONFIG_TARGET_SAMA5D27_WLSOM1_EK) += \
 dtb-$(CONFIG_TARGET_SAMA5D2_ICP) += \
 	at91-sama5d2_icp.dtb
 
+dtb-$(CONFIG_TARGET_SAMA5D29_CURIOSITY) += \
+	at91-sama5d29_curiosity.dtb
+
 dtb-$(CONFIG_TARGET_SAMA5D3XEK) += \
 	sama5d31ek.dtb \
 	sama5d33ek.dtb \
arch/arm/dts/at91-sama5d29_curiosity-u-boot.dtsi new file +55 -0

55 lines not on this page · raw message

arch/arm/dts/at91-sama5d29_curiosity.dts new file +219 -0

219 lines not on this page · raw message

arch/arm/mach-at91/Kconfig +12 -0
index 7c2e4ebbdb..4c65fc0dbd 100644
@@ -215,6 +215,17 @@ config TARGET_SAMA5D2_ICP
 	  a 64Mbit QSPI flash, 3xMikrobus connectors, 4xUSB ,
 	  EtherCat and WILC3000 devices on board.
 
+config TARGET_SAMA5D29_CURIOSITY
+	bool "SAMA5D29 CURIOSITY board"
+	select SAMA5D2
+	select BOARD_EARLY_INIT_F
+	select BOARD_LATE_INIT
+	select CPU_V7A
+	help
+	  The SAMA5D29 Curiosity embeds SAMA5D29 SoC with 4 Gbit LPDDR2-SDRAM,
+	  a 64Mbit QSPI flash with Mac-address, MCP16502 PMIC, RGB LCD connector,
+	  2 x Mikrobus connectors, 2 x SD-Card connectors, 2 x USB
+
 config TARGET_SAMA5D3_XPLAINED
 	bool "SAMA5D3 Xplained board"
 	select BOARD_EARLY_INIT_F
@@ -346,6 +357,7 @@ source "board/atmel/sama5d2_xplained/Kconfig"
 source "board/atmel/sama5d27_som1_ek/Kconfig"
 source "board/atmel/sama5d27_wlsom1_ek/Kconfig"
 source "board/atmel/sama5d2_icp/Kconfig"
+source "board/atmel/sama5d29_curiosity/Kconfig"
 source "board/atmel/sama5d3_xplained/Kconfig"
 source "board/atmel/sama5d3xek/Kconfig"
 source "board/atmel/sama5d4_xplained/Kconfig"
board/atmel/sama5d29_curiosity/Kconfig new file +15 -0
new file mode 100644
index 0000000000..64ca237697
@@ -0,0 +1,15 @@
+if TARGET_SAMA5D29_CURIOSITY
+
+config SYS_BOARD
+	default "sama5d29_curiosity"
+
+config SYS_VENDOR
+	default "atmel"
+
+config SYS_SOC
+	default "at91"
+
+config SYS_CONFIG_NAME
+	default "sama5d29_curiosity"
+
+endif
board/atmel/sama5d29_curiosity/MAINTAINERS new file +8 -0
new file mode 100644
index 0000000000..110c3d2874
@@ -0,0 +1,8 @@
+SAMA5D29 CURIOSITY BOARD
+M:     Mihai Sain <[email protected]>
+S:     Maintained
+F:     board/atmel/sama5d29_curiosity.c
+F:     include/configs/sama5d29_curiosity.h
+F:     configs/sama5d29_curiosity_mmc_defconfig
+F:     configs/sama5d29_curiosity_mmc1_defconfig
+F:     configs/sama5d29_curiosity_qspiflash_defconfig
board/atmel/sama5d29_curiosity/Makefile new file +7 -0
new file mode 100644
index 0000000000..848e1ce149
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries
+#
+# Author: Mihai Sain <[email protected]>
+
+obj-y += sama5d29_curiosity.o
board/atmel/sama5d29_curiosity/sama5d29_curiosity.c new file +86 -0

86 lines not on this page · raw message

configs/sama5d29_curiosity_mmc1_defconfig new file +122 -0

122 lines not on this page · raw message

configs/sama5d29_curiosity_mmc_defconfig new file +121 -0

121 lines not on this page · raw message

configs/sama5d29_curiosity_qspiflash_defconfig new file +121 -0

121 lines not on this page · raw message

include/configs/sama5d29_curiosity.h new file +20 -0
new file mode 100644
index 0000000000..a3be919824
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Configuration file for the SAMA5D29 CURIOSITY board.
+ *
+ * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries
+ *
+ * Author: Mihai Sain <[email protected]>
+ *
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define CFG_SYS_AT91_SLOW_CLOCK		32768
+#define CFG_SYS_AT91_MAIN_CLOCK		24000000
+
+#define CONFIG_SYS_SDRAM_BASE		0x20000000
+#define CONFIG_SYS_SDRAM_SIZE		0x20000000
+
+#endif
Signature · 1 line
2.41.0
#1 lore raw

Hello Mihai,

Thank you for the patch.

However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. There is a pending patch that fixes it, but it has not been tested.
Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) :

https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads

Once this is tested you can reply with a Tested-by: tag, and we can move along.
Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled.

One small nitpick below, and I am looking forward for your reply,

Eugen

Quoted 13 lines · Mihai Sain

Add initial support for sama5d29_curiosity board.

Hardware:
SoC: SAMA5D29 500 MHz
DRAM: LPDDR2 512 MiB
PMIC: MCP16502
Debug: UART0
Flash: QSPI NOR 8 MiB
RGB LCD connector
Mikrobus connectors x 2
SD-Card connectors x 2
USB 2.0 x 2

Quoted 4 lines

---

+CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ "

Can you remove this. It looks like a Linux prompt and might be confusing for people

(and everywhere below)

#2 lore raw

Hello Eugen,

Thank you for applying the patch.

For this board we don't want to use SPL.
I will send v2 patch to remove the custom prompt.
Thanks.

Best regards,
Mihai Sain

-----Original Message-----
From: Eugen Hristev <[email protected]>
Sent: Monday, July 24, 2023 11:13 AM
To: Mihai Sain - M19926 <[email protected]>; [email protected]
Cc: Cristian Birsan - M91496 <[email protected]>
Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hello Mihai,

Thank you for the patch.

However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. There is a pending patch that fixes it, but it has not been tested.
Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) :

https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads

Once this is tested you can reply with a Tested-by: tag, and we can move along.
Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled.

One small nitpick below, and I am looking forward for your reply,

Eugen

Quoted 13 lines · Mihai Sain

Add initial support for sama5d29_curiosity board.

Hardware:
SoC: SAMA5D29 500 MHz
DRAM: LPDDR2 512 MiB
PMIC: MCP16502
Debug: UART0
Flash: QSPI NOR 8 MiB
RGB LCD connector
Mikrobus connectors x 2
SD-Card connectors x 2
USB 2.0 x 2

Quoted 4 lines

---

+CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ "

Can you remove this. It looks like a Linux prompt and might be confusing for people

(and everywhere below)

#3 lore raw
Quoted 7 lines · On 7/24/23 11:49, [email protected] wrote:

Hello Eugen,

Thank you for applying the patch.

For this board we don't want to use SPL.
I will send v2 patch to remove the custom prompt.
Thanks.

As I said, I won't be applying any patches to at91 tree unless someone helps with the testing below. SPL for this board has nothing to do with my request.

These also have to be removed:

+
+#define CONFIG_SYS_SDRAM_BASE 0x20000000
+#define CONFIG_SYS_SDRAM_SIZE 0x20000000

as they are forbidden to set in the config file and appear to be unused anyway.

Eugen

Quoted 53 lines

Best regards,
Mihai Sain

-----Original Message-----
From: Eugen Hristev <[email protected]>
Sent: Monday, July 24, 2023 11:13 AM
To: Mihai Sain - M19926 <[email protected]>; [email protected]
Cc: Cristian Birsan - M91496 <[email protected]>
Subject: Re: [u-boot][PATCH] board: at91: sama5d29_curiosity: add initial support for sama5d29_curiosity

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hello Mihai,

Thank you for the patch.

However, the at91 maintainer tree nowadays has a big problem, I cannot apply patches because the size of the SPL will overflow. There is a pending patch that fixes it, but it has not been tested.
Here you can help, and test this integration branch (at least on sama5d2 ICP, but if you can test on multiple boards, it's even better) :

https://source.denx.de/u-boot/custodians/u-boot-at91/-/tree/testing?ref_type=heads

Once this is tested you can reply with a Tested-by: tag, and we can move along.
Without testing the patch that fixes the size restraint (it's the CONFIG_LTO patch), the tree is stalled.

One small nitpick below, and I am looking forward for your reply,

Eugen

Quoted 13 lines · Mihai Sain

Add initial support for sama5d29_curiosity board.

Hardware:
SoC: SAMA5D29 500 MHz
DRAM: LPDDR2 512 MiB
PMIC: MCP16502
Debug: UART0
Flash: QSPI NOR 8 MiB
RGB LCD connector
Mikrobus connectors x 2
SD-Card connectors x 2
USB 2.0 x 2

Quoted 4 lines

---

+CONFIG_SYS_PROMPT="[root@sama5d29 ~]$ "

Can you remove this. It looks like a Linux prompt and might be confusing for people

(and everywhere below)