Skip to contentSkip to conversation

target/riscv: add missing riscv,isa strings

PATCH Applied Daniel Henrique Barboza 3 participants 10 messages Jul 20, 2023 – Jul 24, 2023 RISC-V

lore
Share & tools
lore
#0 lore raw

cover target/riscv: add missing riscv,isa strings

Hi,

Found these 2 instances while working in more 8.2 material.

I believe both are safe for freeze but I won't lose my sleep if we decide to postpone it.

Daniel Henrique Barboza (2):
target/riscv/cpu.c: add zmmul isa string
target/riscv/cpu.c: add smepmp isa string

 target/riscv/cpu.c | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.41.0
#1 lore raw

PATCH 1/2 target/riscv/cpu.c: add zmmul isa string

zmmul was promoted from experimental to ratified in commit 6d00ffad4e95. Add a riscv,isa string for it.

Fixes 6d00ffad4e95 ("target/riscv: move zmmul out of the experimental properties")
---
 target/riscv/cpu.c | 1 +
 1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -0
index 9339c0241d..d64ac07558 100644
@@ -88,6 +88,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
     ISA_EXT_DATA_ENTRY(zicsr, PRIV_VERSION_1_10_0, ext_icsr),
     ISA_EXT_DATA_ENTRY(zifencei, PRIV_VERSION_1_10_0, ext_ifencei),
     ISA_EXT_DATA_ENTRY(zihintpause, PRIV_VERSION_1_10_0, ext_zihintpause),
+    ISA_EXT_DATA_ENTRY(zmmul, PRIV_VERSION_1_12_0, ext_zmmul),
     ISA_EXT_DATA_ENTRY(zawrs, PRIV_VERSION_1_12_0, ext_zawrs),
     ISA_EXT_DATA_ENTRY(zfa, PRIV_VERSION_1_12_0, ext_zfa),
     ISA_EXT_DATA_ENTRY(zfbfmin, PRIV_VERSION_1_12_0, ext_zfbfmin),
Signature · 1 line
2.41.0
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] target/riscv/cpu.c: add zmmul isa string

Quoted 6 lines · Daniel Henrique Barboza

zmmul was promoted from experimental to ratified in commit 6d00ffad4e95. Add a riscv,isa string for it.

Fixes 6d00ffad4e95 ("target/riscv: move zmmul out of the experimental properties")

---

Weiwei Li

Quoted 15 lines
  target/riscv/cpu.c | 1 +
  1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -0
index 9339c0241d..d64ac07558 100644
@@ -88,6 +88,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
      ISA_EXT_DATA_ENTRY(zicsr, PRIV_VERSION_1_10_0, ext_icsr),
      ISA_EXT_DATA_ENTRY(zifencei, PRIV_VERSION_1_10_0, ext_ifencei),
      ISA_EXT_DATA_ENTRY(zihintpause, PRIV_VERSION_1_10_0, ext_zihintpause),
+    ISA_EXT_DATA_ENTRY(zmmul, PRIV_VERSION_1_12_0, ext_zmmul),
      ISA_EXT_DATA_ENTRY(zawrs, PRIV_VERSION_1_12_0, ext_zawrs),
      ISA_EXT_DATA_ENTRY(zfa, PRIV_VERSION_1_12_0, ext_zfa),
      ISA_EXT_DATA_ENTRY(zfbfmin, PRIV_VERSION_1_12_0, ext_zfbfmin),
Reviewed-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] target/riscv/cpu.c: add zmmul isa string

In reply to Daniel Henrique Barboza
Quoted 6 lines · Daniel Henrique Barboza

zmmul was promoted from experimental to ratified in commit 6d00ffad4e95. Add a riscv,isa string for it.

Fixes 6d00ffad4e95 ("target/riscv: move zmmul out of the experimental properties")

Alistair

Quoted 20 lines
---
 target/riscv/cpu.c | 1 +
 1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -1
index 9339c0241d..d64ac07558 100644
@@ -88,6 +88,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
     ISA_EXT_DATA_ENTRY(zicsr, PRIV_VERSION_1_10_0, ext_icsr),
     ISA_EXT_DATA_ENTRY(zifencei, PRIV_VERSION_1_10_0, ext_ifencei),
     ISA_EXT_DATA_ENTRY(zihintpause, PRIV_VERSION_1_10_0, ext_zihintpause),
+    ISA_EXT_DATA_ENTRY(zmmul, PRIV_VERSION_1_12_0, ext_zmmul),
     ISA_EXT_DATA_ENTRY(zawrs, PRIV_VERSION_1_12_0, ext_zawrs),
     ISA_EXT_DATA_ENTRY(zfa, PRIV_VERSION_1_12_0, ext_zfa),
     ISA_EXT_DATA_ENTRY(zfbfmin, PRIV_VERSION_1_12_0, ext_zfbfmin),
--

2.41.0

#4 lore raw

PATCH 2/2 target/riscv/cpu.c: add smepmp isa string

In reply to Daniel Henrique Barboza

The cpu->cfg.epmp extension is still experimental, but it already has a 'smepmp' riscv,isa string. Add it.

---
 target/riscv/cpu.c | 1 +
 1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -0
index d64ac07558..8c9acadd3b 100644
@@ -130,6 +130,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
     ISA_EXT_DATA_ENTRY(zhinx, PRIV_VERSION_1_12_0, ext_zhinx),
     ISA_EXT_DATA_ENTRY(zhinxmin, PRIV_VERSION_1_12_0, ext_zhinxmin),
     ISA_EXT_DATA_ENTRY(smaia, PRIV_VERSION_1_12_0, ext_smaia),
+    ISA_EXT_DATA_ENTRY(smepmp, PRIV_VERSION_1_12_0, epmp),
     ISA_EXT_DATA_ENTRY(smstateen, PRIV_VERSION_1_12_0, ext_smstateen),
     ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia),
     ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf),
Signature · 1 line
2.41.0
Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] target/riscv/cpu.c: add smepmp isa string

Quoted 5 lines · Daniel Henrique Barboza

The cpu->cfg.epmp extension is still experimental, but it already has a 'smepmp' riscv,isa string. Add it.

---

Weiwei Li

Quoted 15 lines
  target/riscv/cpu.c | 1 +
  1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -0
index d64ac07558..8c9acadd3b 100644
@@ -130,6 +130,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
      ISA_EXT_DATA_ENTRY(zhinx, PRIV_VERSION_1_12_0, ext_zhinx),
      ISA_EXT_DATA_ENTRY(zhinxmin, PRIV_VERSION_1_12_0, ext_zhinxmin),
      ISA_EXT_DATA_ENTRY(smaia, PRIV_VERSION_1_12_0, ext_smaia),
+    ISA_EXT_DATA_ENTRY(smepmp, PRIV_VERSION_1_12_0, epmp),
      ISA_EXT_DATA_ENTRY(smstateen, PRIV_VERSION_1_12_0, ext_smstateen),
      ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia),
      ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf),
Reviewed-by on v1 2/2
#6 lore raw

Re: [PATCH 2/2] target/riscv/cpu.c: add smepmp isa string

In reply to Daniel Henrique Barboza
Quoted 5 lines · Daniel Henrique Barboza

The cpu->cfg.epmp extension is still experimental, but it already has a 'smepmp' riscv,isa string. Add it.

Alistair

Quoted 20 lines
---
 target/riscv/cpu.c | 1 +
 1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -1
index d64ac07558..8c9acadd3b 100644
@@ -130,6 +130,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
     ISA_EXT_DATA_ENTRY(zhinx, PRIV_VERSION_1_12_0, ext_zhinx),
     ISA_EXT_DATA_ENTRY(zhinxmin, PRIV_VERSION_1_12_0, ext_zhinxmin),
     ISA_EXT_DATA_ENTRY(smaia, PRIV_VERSION_1_12_0, ext_smaia),
+    ISA_EXT_DATA_ENTRY(smepmp, PRIV_VERSION_1_12_0, epmp),
     ISA_EXT_DATA_ENTRY(smstateen, PRIV_VERSION_1_12_0, ext_smstateen),
     ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia),
     ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf),
--

2.41.0

#7 lore raw

Re: [PATCH 2/2] target/riscv/cpu.c: add smepmp isa string

In reply to Daniel Henrique Barboza
Quoted 5 lines · Daniel Henrique Barboza

The cpu->cfg.epmp extension is still experimental, but it already has a 'smepmp' riscv,isa string. Add it.

Thanks!

Applied to riscv-to-apply.next

Alistair

Quoted 20 lines
---
 target/riscv/cpu.c | 1 +
 1 file changed, 1 insertion(+)
target/riscv/cpu.c +1 -1
index d64ac07558..8c9acadd3b 100644
@@ -130,6 +130,7 @@ static const struct isa_ext_data isa_edata_arr[] = {
     ISA_EXT_DATA_ENTRY(zhinx, PRIV_VERSION_1_12_0, ext_zhinx),
     ISA_EXT_DATA_ENTRY(zhinxmin, PRIV_VERSION_1_12_0, ext_zhinxmin),
     ISA_EXT_DATA_ENTRY(smaia, PRIV_VERSION_1_12_0, ext_smaia),
+    ISA_EXT_DATA_ENTRY(smepmp, PRIV_VERSION_1_12_0, epmp),
     ISA_EXT_DATA_ENTRY(smstateen, PRIV_VERSION_1_12_0, ext_smstateen),
     ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia),
     ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf),
--

2.41.0

#8 lore raw
In reply to Daniel Henrique Barboza
Quoted 7 lines · Daniel Henrique Barboza

Hi,

Found these 2 instances while working in more 8.2 material.

I believe both are safe for freeze but I won't lose my sleep if we decide to postpone it.

I wasn't going to squeeze them into the freeze

Quoted 4 lines

Daniel Henrique Barboza (2):
target/riscv/cpu.c: add zmmul isa string
target/riscv/cpu.c: add smepmp isa string

Do you mind rebasing :)
https://github.com/alistair23/qemu/tree/riscv-to-apply.next

Alistair

Quoted 8 lines
 target/riscv/cpu.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.41.0

#9 lore raw
Quoted 13 lines · Alistair Francis
Quoted 7 lines · Daniel Henrique Barboza

Hi,

Found these 2 instances while working in more 8.2 material.

I believe both are safe for freeze but I won't lose my sleep if we decide to postpone it.

I wasn't going to squeeze them into the freeze

Quoted 1 line
Quoted 6 lines
Quoted 3 lines

Daniel Henrique Barboza (2):
target/riscv/cpu.c: add zmmul isa string
target/riscv/cpu.c: add smepmp isa string

Do you mind rebasing :)
https://github.com/alistair23/qemu/tree/riscv-to-apply.next

:)

Thanks!

Daniel

Quoted 11 lines

Alistair

Quoted 8 lines
  target/riscv/cpu.c | 2 ++
  1 file changed, 2 insertions(+)

--
2.41.0