Skip to contentSkip to conversation

powerpc: Explicitly include correct DT includes

PATCH Applied Rob Herring 2 participants 2 messages Jul 24, 2023 – Aug 10, 2023

Subsystems (6)
PowerPC Linux for power macintosh Cell broadband engine architecture Linux for PowerPC embedded PPC85XX +2 more subsystems
lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH v3 1/1 powerpc: Explicitly include correct DT includes

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

Signed-off-by Rob Herring <[email protected]>

---
v3:
- Add 83xx/mpc832x_rdb.c, 85xx/common.c, 86xx/common.c v2:
- Fix double include of of.h

---
 arch/powerpc/include/asm/ibmebus.h              | 2 ++
 arch/powerpc/include/asm/macio.h                | 3 ++-
 arch/powerpc/kernel/legacy_serial.c             | 2 +-
 arch/powerpc/kernel/of_platform.c               | 4 +---
 arch/powerpc/kernel/setup-common.c              | 4 ++--
 arch/powerpc/kexec/file_load_64.c               | 2 +-
 arch/powerpc/kexec/ranges.c                     | 2 +-
 arch/powerpc/platforms/4xx/cpm.c                | 2 +-
 arch/powerpc/platforms/4xx/hsta_msi.c           | 2 +-
 arch/powerpc/platforms/4xx/soc.c                | 2 +-
 arch/powerpc/platforms/512x/mpc5121_ads.c       | 2 +-
 arch/powerpc/platforms/512x/mpc512x_generic.c   | 2 +-
 arch/powerpc/platforms/512x/mpc512x_lpbfifo.c   | 2 +-
 arch/powerpc/platforms/512x/pdm360ng.c          | 3 ++-
 arch/powerpc/platforms/52xx/mpc52xx_gpt.c       | 3 +--
 arch/powerpc/platforms/82xx/ep8248e.c           | 1 +
 arch/powerpc/platforms/83xx/km83xx.c            | 4 ++--
 arch/powerpc/platforms/83xx/mpc832x_rdb.c       | 4 +++-
 arch/powerpc/platforms/83xx/suspend.c           | 2 +-
 arch/powerpc/platforms/85xx/bsc913x_qds.c       | 2 +-
 arch/powerpc/platforms/85xx/bsc913x_rdb.c       | 2 +-
 arch/powerpc/platforms/85xx/c293pcie.c          | 3 +--
 arch/powerpc/platforms/85xx/common.c            | 1 +
 arch/powerpc/platforms/85xx/ge_imp3a.c          | 2 +-
 arch/powerpc/platforms/85xx/ksi8560.c           | 3 ++-
 arch/powerpc/platforms/85xx/mpc8536_ds.c        | 2 +-
 arch/powerpc/platforms/85xx/mpc85xx_ds.c        | 2 +-
 arch/powerpc/platforms/85xx/mpc85xx_mds.c       | 4 ++--
 arch/powerpc/platforms/85xx/mpc85xx_rdb.c       | 3 ++-
 arch/powerpc/platforms/85xx/p1010rdb.c          | 2 +-
 arch/powerpc/platforms/85xx/p1022_ds.c          | 2 +-
 arch/powerpc/platforms/85xx/p1022_rdk.c         | 2 +-
 arch/powerpc/platforms/85xx/p1023_rdb.c         | 3 +--
 arch/powerpc/platforms/85xx/socrates.c          | 2 +-
 arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 1 -
 arch/powerpc/platforms/85xx/stx_gp3.c           | 2 +-
 arch/powerpc/platforms/85xx/tqm85xx.c           | 2 +-
 arch/powerpc/platforms/85xx/twr_p102x.c         | 3 ++-
 arch/powerpc/platforms/85xx/xes_mpc85xx.c       | 2 +-
 arch/powerpc/platforms/86xx/common.c            | 3 +++
 arch/powerpc/platforms/86xx/gef_ppc9a.c         | 2 +-
 arch/powerpc/platforms/86xx/gef_sbc310.c        | 2 +-
 arch/powerpc/platforms/86xx/gef_sbc610.c        | 2 +-
 arch/powerpc/platforms/86xx/mvme7100.c          | 1 -
 arch/powerpc/platforms/86xx/pic.c               | 2 +-
 arch/powerpc/platforms/cell/axon_msi.c          | 3 ++-
 arch/powerpc/platforms/cell/cbe_regs.c          | 3 +--
 arch/powerpc/platforms/cell/iommu.c             | 2 +-
 arch/powerpc/platforms/cell/setup.c             | 1 +
 arch/powerpc/platforms/cell/spider-pci.c        | 1 -
 arch/powerpc/platforms/embedded6xx/holly.c      | 2 +-
 arch/powerpc/platforms/maple/setup.c            | 4 ++--
 arch/powerpc/platforms/pasemi/gpio_mdio.c       | 2 +-
 arch/powerpc/platforms/pasemi/setup.c           | 2 ++
 arch/powerpc/platforms/powermac/setup.c         | 2 +-
 arch/powerpc/platforms/powernv/opal-imc.c       | 1 -
 arch/powerpc/platforms/powernv/opal-rtc.c       | 3 ++-
 arch/powerpc/platforms/powernv/opal-secvar.c    | 2 +-
 arch/powerpc/platforms/powernv/opal-sensor.c    | 2 ++
 arch/powerpc/platforms/pseries/ibmebus.c        | 1 +
 arch/powerpc/sysdev/cpm_common.c                | 2 --
 arch/powerpc/sysdev/cpm_gpio.c                  | 3 ++-
 arch/powerpc/sysdev/fsl_pmc.c                   | 4 ++--
 arch/powerpc/sysdev/fsl_rio.c                   | 4 ++--
 arch/powerpc/sysdev/fsl_rmu.c                   | 1 -
 arch/powerpc/sysdev/fsl_soc.c                   | 1 -
 arch/powerpc/sysdev/mpic_msgr.c                 | 3 ++-
 arch/powerpc/sysdev/mpic_timer.c                | 1 -
 arch/powerpc/sysdev/of_rtc.c                    | 4 ++--
 arch/powerpc/sysdev/pmi.c                       | 4 ++--
 70 files changed, 86 insertions(+), 77 deletions(-)
arch/powerpc/include/asm/ibmebus.h +2 -0
index 088f95b2e14f..6f33253a364a 100644
@@ -46,6 +46,8 @@
 #include <linux/of_device.h>
 #include <linux/of_platform.h>
 
+struct platform_driver;
+
 extern struct bus_type ibmebus_bus_type;
 
 int ibmebus_register_driver(struct platform_driver *drv);
arch/powerpc/include/asm/macio.h +2 -1
index ff5fd82d9ff0..3a07c62973aa 100644
@@ -3,7 +3,8 @@
 #define __MACIO_ASIC_H__
 #ifdef __KERNEL__
 
-#include <linux/of_device.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
 
 extern struct bus_type macio_bus_type;
arch/powerpc/kernel/legacy_serial.c +1 -1
index 6ee65741dbd5..1da2f6e7d2a1 100644
@@ -5,8 +5,8 @@
 #include <linux/serial_core.h>
 #include <linux/console.h>
 #include <linux/pci.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/serial_reg.h>
 #include <asm/io.h>
arch/powerpc/kernel/of_platform.c +1 -3
index f89376ff633e..adc76fa58d1e 100644
@@ -13,9 +13,7 @@
 #include <linux/export.h>
 #include <linux/mod_devicetable.h>
 #include <linux/pci.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/atomic.h>
 
 #include <asm/errno.h>
arch/powerpc/kernel/setup-common.c +2 -2
index d2a446216444..e506699904ec 100644
@@ -31,9 +31,9 @@
 #include <linux/serial_8250.h>
 #include <linux/percpu.h>
 #include <linux/memblock.h>
-#include <linux/of_irq.h>
+#include <linux/of.h>
 #include <linux/of_fdt.h>
-#include <linux/of_platform.h>
+#include <linux/of_irq.h>
 #include <linux/hugetlb.h>
 #include <linux/pgtable.h>
 #include <asm/io.h>
arch/powerpc/kexec/file_load_64.c +1 -1
index 110d28bede2a..7e69be55451a 100644
@@ -17,7 +17,7 @@
 #include <linux/kexec.h>
 #include <linux/of_fdt.h>
 #include <linux/libfdt.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/memblock.h>
 #include <linux/slab.h>
 #include <linux/vmalloc.h>
arch/powerpc/kexec/ranges.c +1 -1
index 5fc53a5fcfdf..fb3e12f15214 100644
@@ -18,7 +18,7 @@
 
 #include <linux/sort.h>
 #include <linux/kexec.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/slab.h>
 #include <asm/sections.h>
 #include <asm/kexec_ranges.h>
arch/powerpc/platforms/4xx/cpm.c +1 -1
index 182e12855c27..670f8ad4465b 100644
@@ -18,7 +18,7 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/sysfs.h>
 #include <linux/cpu.h>
 #include <linux/suspend.h>
arch/powerpc/platforms/4xx/hsta_msi.c +1 -1
index e11b57a62b05..c6bd846b0d65 100644
@@ -11,7 +11,7 @@
 #include <linux/msi.h>
 #include <linux/of.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/pci.h>
 #include <linux/semaphore.h>
 #include <asm/msi_bitmap.h>
arch/powerpc/platforms/4xx/soc.c +1 -1
index ac1cd8b17879..f91df0827877 100644
@@ -15,8 +15,8 @@
 #include <linux/errno.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/of.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 
 #include <asm/dcr.h>
 #include <asm/dcr-regs.h>
arch/powerpc/platforms/512x/mpc5121_ads.c +1 -1
index 80b25ce076bc..a18f85b3ef36 100644
@@ -10,7 +10,7 @@
 
 #include <linux/kernel.h>
 #include <linux/io.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/machdep.h>
 #include <asm/ipic.h>
arch/powerpc/platforms/512x/mpc512x_generic.c +1 -1
index 97dfaac8f7ff..0d58ab257cd9 100644
@@ -9,7 +9,7 @@
  */
 
 #include <linux/kernel.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/machdep.h>
 #include <asm/ipic.h>
arch/powerpc/platforms/512x/mpc512x_lpbfifo.c +1 -1
index 1bfb29574caa..6edbbe6918f1 100644
@@ -10,9 +10,9 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of.h>
-#include <linux/of_platform.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
+#include <linux/platform_device.h>
 #include <asm/mpc5121.h>
 #include <asm/io.h>
 #include <linux/spinlock.h>
arch/powerpc/platforms/512x/pdm360ng.c +2 -1
index 4bdec1c25de7..ce51cfeeb066 100644
@@ -7,11 +7,12 @@
  * PDM360NG board setup
  */
 
+#include <linux/device.h>
 #include <linux/kernel.h>
 #include <linux/io.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_fdt.h>
-#include <linux/of_platform.h>
 
 #include <asm/machdep.h>
 #include <asm/ipic.h>
arch/powerpc/platforms/52xx/mpc52xx_gpt.c +1 -2
index 3fce4e1c3af6..581059527c36 100644
@@ -48,7 +48,6 @@
  * the output mode.  This driver does not change the output mode setting.
  */
 
-#include <linux/device.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
 #include <linux/io.h>

@@ -57,8 +56,8 @@
 #include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 #include <linux/of_gpio.h>
+#include <linux/platform_device.h>
 #include <linux/kernel.h>
 #include <linux/property.h>
 #include <linux/slab.h>
arch/powerpc/platforms/82xx/ep8248e.c +1 -0
index 8f1856ba692e..16808536f788 100644
@@ -13,6 +13,7 @@
 #include <linux/of_mdio.h>
 #include <linux/slab.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #include <asm/io.h>
 #include <asm/cpm2.h>
arch/powerpc/platforms/83xx/km83xx.c +2 -2
index 26ddc7136547..2b5d187d9b62 100644
@@ -20,8 +20,8 @@
 #include <linux/seq_file.h>
 #include <linux/root_dev.h>
 #include <linux/initrd.h>
-#include <linux/of_platform.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
 
 #include <linux/atomic.h>
 #include <linux/time.h>
arch/powerpc/platforms/83xx/mpc832x_rdb.c +3 -1
index 3b4e4173c59e..d523ce0f48db 100644
@@ -15,8 +15,10 @@
 #include <linux/spi/spi.h>
 #include <linux/spi/mmc_spi.h>
 #include <linux/mmc/host.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/fsl_devices.h>
 
 #include <asm/time.h>
arch/powerpc/platforms/83xx/suspend.c +1 -1
index 3fa8979ac8a6..9833c36bda83 100644
@@ -19,7 +19,7 @@
 #include <linux/fsl_devices.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/export.h>
 
 #include <asm/reg.h>
arch/powerpc/platforms/85xx/bsc913x_qds.c +1 -1
index a029aa090538..2eb62bff86d4 100644
@@ -9,7 +9,7 @@
  * Copyright 2014 Freescale Semiconductor Inc.
  */
 
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/pci.h>
 #include <asm/mpic.h>
 #include <sysdev/fsl_soc.h>
arch/powerpc/platforms/85xx/bsc913x_rdb.c +1 -1
index 361b4371d073..161f006cb3bb 100644
@@ -7,7 +7,7 @@
  * Copyright 2011-2012 Freescale Semiconductor Inc.
  */
 
-#include <linux/of_platform.h>
+#include <linux/of.h>
 #include <linux/pci.h>
 #include <asm/mpic.h>
 #include <sysdev/fsl_soc.h>
arch/powerpc/platforms/85xx/c293pcie.c +1 -2
index 34975708be79..7a63a3ad5e8a 100644
@@ -7,8 +7,7 @@
 
 #include <linux/stddef.h>
 #include <linux/kernel.h>
-#include <linux/of_fdt.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/machdep.h>
 #include <asm/udbg.h>
arch/powerpc/platforms/85xx/common.c +1 -0
index a554b6d87cf7..757811155587 100644
@@ -3,6 +3,7 @@
  * Routines common to most mpc85xx-based boards.
  */
 
+#include <linux/of.h>
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
arch/powerpc/platforms/85xx/ge_imp3a.c +1 -1
index 3678a1fbf5ad..9c3b44a1952e 100644
@@ -17,8 +17,8 @@
 #include <linux/delay.h>
 #include <linux/seq_file.h>
 #include <linux/interrupt.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/ksi8560.c +2 -1
index af38c3aec042..1b6326a4b0f2 100644
@@ -18,7 +18,8 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/mpc8536_ds.c +1 -1
index 58ab3831913f..e966b2ad8ecd 100644
@@ -12,7 +12,7 @@
 #include <linux/delay.h>
 #include <linux/seq_file.h>
 #include <linux/interrupt.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/mpc85xx_ds.c +1 -1
index 4347d629b567..2856148321b3 100644
@@ -15,8 +15,8 @@
 #include <linux/delay.h>
 #include <linux/seq_file.h>
 #include <linux/interrupt.h>
+#include <linux/of.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/mpc85xx_mds.c +2 -2
index 0546f19416c2..c19490cf6376 100644
@@ -26,8 +26,8 @@
 #include <linux/seq_file.h>
 #include <linux/initrd.h>
 #include <linux/fsl_devices.h>
-#include <linux/of_platform.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
 #include <linux/phy.h>
 #include <linux/memblock.h>
 #include <linux/fsl/guts.h>
arch/powerpc/platforms/85xx/mpc85xx_rdb.c +2 -1
index c42a68da6dfd..ec9f60fbebc7 100644
@@ -12,7 +12,8 @@
 #include <linux/delay.h>
 #include <linux/seq_file.h>
 #include <linux/interrupt.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
 #include <linux/fsl/guts.h>
 
 #include <asm/time.h>
arch/powerpc/platforms/85xx/p1010rdb.c +1 -1
index 14ec79a32746..10d6f1fa3327 100644
@@ -10,7 +10,7 @@
 #include <linux/pci.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/p1022_ds.c +1 -1
index 23d0926298b9..0dd786a061a6 100644
@@ -18,8 +18,8 @@
 
 #include <linux/fsl/guts.h>
 #include <linux/pci.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 #include <asm/div64.h>
 #include <asm/mpic.h>
 #include <asm/swiotlb.h>
arch/powerpc/platforms/85xx/p1022_rdk.c +1 -1
index d1159150c3b5..25ab6e9c1470 100644
@@ -14,8 +14,8 @@
 
 #include <linux/fsl/guts.h>
 #include <linux/pci.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 #include <asm/div64.h>
 #include <asm/mpic.h>
 #include <asm/swiotlb.h>
arch/powerpc/platforms/85xx/p1023_rdb.c +1 -2
index 9df0439a9382..e4fa8731fd2d 100644
@@ -15,9 +15,8 @@
 #include <linux/delay.h>
 #include <linux/module.h>
 #include <linux/fsl_devices.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
-#include <linux/of_device.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/socrates.c +1 -1
index 9fa1338bc002..403367b318db 100644
@@ -23,7 +23,7 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/socrates_fpga_pic.c +0 -1
index 3768c86b9629..baa12eff6d5d 100644
@@ -6,7 +6,6 @@
 #include <linux/irq.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 #include <linux/io.h>
 
 /*
arch/powerpc/platforms/85xx/stx_gp3.c +1 -1
index 5e2646b4c039..c10efc45894c 100644
@@ -22,7 +22,7 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/tqm85xx.c +1 -1
index 80effb028bf4..6be1b9809db6 100644
@@ -20,7 +20,7 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/85xx/twr_p102x.c +2 -1
index b88e23a334a4..c0a0456f1674 100644
@@ -13,7 +13,8 @@
 #include <linux/errno.h>
 #include <linux/fsl/guts.h>
 #include <linux/pci.h>
-#include <linux/of_platform.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
 
 #include <asm/pci-bridge.h>
 #include <asm/udbg.h>
arch/powerpc/platforms/85xx/xes_mpc85xx.c +1 -1
index 184013e6601e..45f257fc1ade 100644
@@ -16,8 +16,8 @@
 #include <linux/delay.h>
 #include <linux/seq_file.h>
 #include <linux/interrupt.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/86xx/common.c +3 -0
index 0069d38263e7..a4a550527609 100644
@@ -3,7 +3,10 @@
  * Routines common to most mpc86xx-based boards.
  */
 
+#include <linux/init.h>
+#include <linux/mod_devicetable.h>
 #include <linux/of_platform.h>
+#include <asm/reg.h>
 #include <asm/synch.h>
 
 #include "mpc86xx.h"
arch/powerpc/platforms/86xx/gef_ppc9a.c +1 -1
index f0512e51300c..f7f98cca7b91 100644
@@ -18,8 +18,8 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/86xx/gef_sbc310.c +1 -1
index 1430b524d982..689835f7f088 100644
@@ -18,8 +18,8 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/86xx/gef_sbc610.c +1 -1
index c92af0d964e1..365f511186ca 100644
@@ -18,8 +18,8 @@
 #include <linux/kdev_t.h>
 #include <linux/delay.h>
 #include <linux/seq_file.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 
 #include <asm/time.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/86xx/mvme7100.c +0 -1
index c0ac40514361..cee49ecd32d2 100644
@@ -20,7 +20,6 @@
 #include <linux/pci.h>
 #include <linux/of.h>
 #include <linux/of_fdt.h>
-#include <linux/of_platform.h>
 #include <linux/of_address.h>
 #include <asm/udbg.h>
 #include <asm/mpic.h>
arch/powerpc/platforms/86xx/pic.c +1 -1
index 2c32c3488afb..5c7bd925653d 100644
@@ -6,8 +6,8 @@
 #include <linux/stddef.h>
 #include <linux/kernel.h>
 #include <linux/interrupt.h>
+#include <linux/of.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 
 #include <asm/mpic.h>
 #include <asm/i8259.h>
arch/powerpc/platforms/cell/axon_msi.c +2 -1
index 106000449d3b..28dc86744cac 100644
@@ -10,10 +10,11 @@
 #include <linux/pci.h>
 #include <linux/msi.h>
 #include <linux/export.h>
-#include <linux/of_platform.h>
 #include <linux/slab.h>
 #include <linux/debugfs.h>
+#include <linux/of.h>
 #include <linux/of_irq.h>
+#include <linux/platform_device.h>
 
 #include <asm/dcr.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/cell/cbe_regs.c +1 -2
index fb4023f9ea6b..99b3558753e9 100644
@@ -10,9 +10,8 @@
 #include <linux/percpu.h>
 #include <linux/types.h>
 #include <linux/export.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
-#include <linux/of_platform.h>
 #include <linux/pgtable.h>
 
 #include <asm/io.h>
arch/powerpc/platforms/cell/iommu.c +1 -1
index 8c7133039566..1202a69b0a20 100644
@@ -16,7 +16,7 @@
 #include <linux/notifier.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/memblock.h>
arch/powerpc/platforms/cell/setup.c +1 -0
index 9e07d101bcee..f64a1ef98aa8 100644
@@ -27,6 +27,7 @@
 #include <linux/mutex.h>
 #include <linux/memory_hotplug.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #include <asm/mmu.h>
 #include <asm/processor.h>
arch/powerpc/platforms/cell/spider-pci.c +0 -1
index e36ebd84f55b..68439445b1c3 100644
@@ -9,7 +9,6 @@
 
 #include <linux/kernel.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 #include <linux/slab.h>
 #include <linux/io.h>
arch/powerpc/platforms/embedded6xx/holly.c +1 -1
index 02ff260ae1ee..ce9e58ee9754 100644
@@ -22,9 +22,9 @@
 #include <linux/serial.h>
 #include <linux/tty.h>
 #include <linux/serial_core.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 #include <linux/extable.h>
 
 #include <asm/time.h>
arch/powerpc/platforms/maple/setup.c +2 -2
index a4a79d77eca2..665d37e437ce 100644
@@ -3,7 +3,7 @@
  *  Maple (970 eval board) setup code
  *
  *  (c) Copyright 2004 Benjamin Herrenschmidt ([email protected]),
- *                     IBM Corp. 
+ *                     IBM Corp.
  */
 
 #undef DEBUG

@@ -36,8 +36,8 @@
 #include <linux/serial.h>
 #include <linux/smp.h>
 #include <linux/bitops.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/memblock.h>
 
 #include <asm/processor.h>
arch/powerpc/platforms/pasemi/gpio_mdio.c +1 -1
index 913b77b92cea..fd130fe7a65a 100644
@@ -20,7 +20,7 @@
 #include <linux/phy.h>
 #include <linux/of_address.h>
 #include <linux/of_mdio.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #define DELAY 1
arch/powerpc/platforms/pasemi/setup.c +2 -0
index 5c5b4a034f9e..ef985ba2bf21 100644
@@ -16,7 +16,9 @@
 #include <linux/console.h>
 #include <linux/export.h>
 #include <linux/pci.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/gfp.h>
 #include <linux/irqdomain.h>
arch/powerpc/platforms/powermac/setup.c +1 -1
index 0c41f4b005bc..6de1cd5d8a58 100644
@@ -45,7 +45,7 @@
 #include <linux/root_dev.h>
 #include <linux/bitops.h>
 #include <linux/suspend.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
 
 #include <asm/reg.h>
arch/powerpc/platforms/powernv/opal-imc.c +0 -1
index 348a8cdaecd6..828fc4d88471 100644
@@ -11,7 +11,6 @@
 #include <linux/platform_device.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
 #include <linux/crash_dump.h>
 #include <linux/debugfs.h>
 #include <asm/opal.h>
arch/powerpc/platforms/powernv/opal-rtc.c +2 -1
index a9bcf9217e64..79011a263aa6 100644
@@ -11,8 +11,9 @@
 #include <linux/bcd.h>
 #include <linux/rtc.h>
 #include <linux/delay.h>
-#include <linux/platform_device.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #include <asm/opal.h>
 #include <asm/firmware.h>
arch/powerpc/platforms/powernv/opal-secvar.c +1 -1
index a8436bf35e2f..6ac410f4d3c7 100644
@@ -12,8 +12,8 @@
 #define pr_fmt(fmt) "secvar: "fmt
 
 #include <linux/types.h>
+#include <linux/of.h>
 #include <linux/platform_device.h>
-#include <linux/of_platform.h>
 #include <asm/opal.h>
 #include <asm/secvar.h>
 #include <asm/secure_boot.h>
arch/powerpc/platforms/powernv/opal-sensor.c +2 -0
index 3192c614a1e1..8880a1c14573 100644
@@ -6,7 +6,9 @@
  */
 
 #include <linux/delay.h>
+#include <linux/of.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <asm/opal.h>
 #include <asm/machdep.h>
arch/powerpc/platforms/pseries/ibmebus.c +1 -0
index da7eccaeac63..5848f2a08750 100644
@@ -46,6 +46,7 @@
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/stat.h>
 #include <asm/ibmebus.h>
arch/powerpc/sysdev/cpm_common.c +0 -2
index 8234013a8772..47db732981a8 100644
@@ -15,11 +15,9 @@
  */
 
 #include <linux/init.h>
-#include <linux/of_device.h>
 #include <linux/spinlock.h>
 #include <linux/export.h>
 #include <linux/of.h>
-#include <linux/of_address.h>
 #include <linux/slab.h>
 
 #include <asm/udbg.h>
arch/powerpc/sysdev/cpm_gpio.c +2 -1
index 0695d26bd301..40f57111e93e 100644
@@ -9,7 +9,8 @@
  */
 
 #include <linux/module.h>
-#include <linux/of_device.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
 
 #include <asm/cpm.h>
 #ifdef CONFIG_8xx_GPIO
arch/powerpc/sysdev/fsl_pmc.c +2 -2
index 76896de970ca..9f6dd11c1344 100644
@@ -13,9 +13,9 @@
 #include <linux/export.h>
 #include <linux/suspend.h>
 #include <linux/delay.h>
-#include <linux/device.h>
+#include <linux/mod_devicetable.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 struct pmc_regs {
 	__be32 devdisr;
arch/powerpc/sysdev/fsl_rio.c +2 -2
index 0331962bc6d2..efd8f6291ea6 100644
@@ -23,10 +23,10 @@
 #include <linux/types.h>
 #include <linux/dma-mapping.h>
 #include <linux/interrupt.h>
-#include <linux/device.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/delay.h>
 #include <linux/slab.h>
arch/powerpc/sysdev/fsl_rmu.c +0 -1
index c1f724973589..58221b6e1465 100644
@@ -25,7 +25,6 @@
 #include <linux/interrupt.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
 #include <linux/slab.h>
 
 #include "fsl_rio.h"
arch/powerpc/sysdev/fsl_soc.c +0 -1
index 68709743450e..e71b3ede147e 100644
@@ -19,7 +19,6 @@
 #include <linux/device.h>
 #include <linux/platform_device.h>
 #include <linux/of.h>
-#include <linux/of_platform.h>
 #include <linux/phy.h>
 #include <linux/spi/spi.h>
 #include <linux/fsl_devices.h>
arch/powerpc/sysdev/mpic_msgr.c +2 -1
index 1a3ac0b5dd89..7b449cc51aef 100644
@@ -7,9 +7,10 @@
  */
 
 #include <linux/list.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/errno.h>
 #include <linux/err.h>
 #include <linux/export.h>
arch/powerpc/sysdev/mpic_timer.c +0 -1
index b2f0a73e8f93..7166e2e0baaf 100644
@@ -16,7 +16,6 @@
 #include <linux/slab.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/of_irq.h>
 #include <linux/syscore_ops.h>
 #include <sysdev/fsl_soc.h>
arch/powerpc/sysdev/of_rtc.c +2 -2
index 420f949b7485..2211937d3788 100644
@@ -5,10 +5,10 @@
  * Copyright 2007 David Gibson <[email protected]>, IBM Corporation.
  */
 #include <linux/kernel.h>
-#include <linux/of.h>
 #include <linux/init.h>
+#include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 
 #include <asm/prom.h>
arch/powerpc/sysdev/pmi.c +2 -2
index 9dabb50c36eb..fcf8d1516210 100644
@@ -16,11 +16,11 @@
 #include <linux/completion.h>
 #include <linux/spinlock.h>
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/workqueue.h>
 #include <linux/of_address.h>
-#include <linux/of_device.h>
 #include <linux/of_irq.h>
-#include <linux/of_platform.h>
+#include <linux/platform_device.h>
 
 #include <asm/io.h>
 #include <asm/pmi.h>
Signature · 1 line
2.40.1
Applied
#1 lore raw
Quoted 10 lines · Rob Herring

The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes.

[...]

Applied to powerpc/next.

[1/1] powerpc: Explicitly include correct DT includes

      https://git.kernel.org/powerpc/c/81d7cac4d11cc65f29be68c72759429d5194347a

cheers