Skip to contentSkip to conversation

Fixing check patch styling issues

PATCH RESEND Superseded Raghu Halharvi 2 participants 2 messages Jul 25, 2023 – Jul 26, 2023

v6 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v6 cover Fixing check patch styling issues

v6 changes:
- The v5 was approved was not committed, submitting both patches(v6) addressing styling issues in cxl/mbox.c and cxl/region.c after rebasing with latest source. The changes remain same except the function in which redundant dev_err() was present has been renamed to cxl_memdev_state_create. (Alison/Ira)

v5 changes:
- Updated the missing reviewed tag in "cxl/mbox: Remove redundant dev_err() after failed mem alloc" patch (Dave Jiang)

v4 changes:
- Updated the respective patches with reviewers tags for respective patches(Dave Jiang)

v3 changes:
- Update the cover letter and commit message with full author name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)

v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as suggested.
Dropped the patch containing tab changes in port.c

v1 cover letter:
The following patches are cleanup or fixing the styling issues found using checkpatch

In cxl/core/mbox.c, in case of null check failure, returning errno or -ENOMEM in this case is good enough, removing the redundant dev_err message.

In cxl/core/region.c, the else is not required after the return statement, cleaned it up.

Verified the build and sanity by booting the guest VM using the freshly built components.

Raghu Halharvi (2):
cxl/mbox: Remove redundant dev_err() after failed mem alloc cxl/region: Remove else after return statement

 drivers/cxl/core/mbox.c   | 4 +---
 drivers/cxl/core/region.c | 8 ++++----
 2 files changed, 5 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.2
Reviewed-by Vishal Verma Reviewed-by Dave Jiang Reviewed-by Ira Weiny Reviewed-by Vishal Verma Reviewed-by Dave Jiang Reviewed-by Ira Weiny on the v6 series
#1 lore raw
Quoted 6 lines · Raghu Halharvi

v6 changes:
- The v5 was approved was not committed, submitting both patches(v6) addressing styling issues in cxl/mbox.c and cxl/region.c after rebasing with latest source. The changes remain same except the function in which redundant dev_err() was present has been renamed to cxl_memdev_state_create. (Alison/Ira)

Hi Raghu,

This posting is a new cover letter alone, and it has the same exact Subject line as the previous cover letter which had patches attached. As you might imagin, that is confusing to humans and may be confusing to automated tools.

Please try this:

Next version is v7, not a resend

v7 changes:
- Append the actual patches that were omitted in previous send
- Update the v6 changelog
- Reorder and remove blank line in Patch Tags

v6 changes:
- Rebase
- Do the redundant dev_err() cleanup in cxl_memdev_state_create()

By Reorder the patch tags, I mean:

Replace this:

With this:

There should be no space among the tags, and they get listed in the order of arrival. ie. You gave your Signed-off-by first, and then the Reviewed-by tags follow. The maintainer who applies your patches, will add their Signed-off-by Tag last upon merging.

(If you'd like to try something new and useful, look up git format-patch --base option. We often use that in a patchset to tell reviewers and those who will apply the set, the base commit)

Thanks for keeping at it Raghu!

Alison

Quoted 44 lines

v5 changes:
- Updated the missing reviewed tag in "cxl/mbox: Remove redundant dev_err() after failed mem alloc" patch (Dave Jiang)

v4 changes:
- Updated the respective patches with reviewers tags for respective patches(Dave Jiang)

v3 changes:
- Update the cover letter and commit message with full author name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)

v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as suggested.
Dropped the patch containing tab changes in port.c

v1 cover letter:
The following patches are cleanup or fixing the styling issues found using checkpatch

In cxl/core/mbox.c, in case of null check failure, returning errno or -ENOMEM in this case is good enough, removing the redundant dev_err message.

In cxl/core/region.c, the else is not required after the return statement, cleaned it up.

Verified the build and sanity by booting the guest VM using the freshly built components.

Raghu Halharvi (2):
cxl/mbox: Remove redundant dev_err() after failed mem alloc cxl/region: Remove else after return statement

 drivers/cxl/core/mbox.c   | 4 +---
 drivers/cxl/core/region.c | 8 ++++----
 2 files changed, 5 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.2