Skip to content

Fixing check patch styling issues

Raghu Halharvi linux-cxl lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 3 repliesIn review
  2. v6 posting 2/20 of 2 patches 1 replySuperseded
  3. v6 posting 1/22 patches 1 replySuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v52 patches2 repliesSuperseded
v42 patches1 replySuperseded
v32 patches1 replySuperseded
v22 patches11 repliesSuperseded
v13 patches7 repliesSuperseded

Changes in v7 from the cover letter

- Append the actual patches that were omitted in previos end
- Update the v6 changelog
- Reorder and remove the blank line in patch tags (Alison)

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cxl/mbox: Remove redundant dev_err() after failed mem allocdrivers/cxl/core/mbox.c+1 -31 reply
2/2cxl/region: Remove else after return statementdrivers/cxl/core/region.c+4 -42 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchVishal VermaDave JiangIra WeinyAlison Schofield
1/2R-b R-b R-b R-b
2/2R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/2] Fixing check patch styling issues

v7 changes:
- Append the actual patches that were omitted in previos end
- Update the v6 changelog
- Reorder and remove the blank line in patch tags (Alison)

v6 changes:
- Rebase
- Do the redundant dev_err() cleanup in cxl_memdev_state_create() (Alison/Ira)

v5 changes:
- Updated the missing reviewed tag in "cxl/mbox: Remove redundant dev_err() after failed mem alloc" patch (Dave Jiang)

v4 changes:
- Updated the respective patches with reviewers tags for respective patches(Dave Jiang)

v3 changes:
- Update the cover letter and commit message with full author name(Fabio/Alison)
- Correct the "typo error" in commit message(Fabio)

v2 changes:
Thanks Alison, Ira for your comments, modified the v1 patches as suggested.
Dropped the patch containing tab changes in port.c

v1 cover letter:
The following patches are cleanup or fixing the styling issues found using checkpatch

In cxl/core/mbox.c, in case of null check failure, returning errno or -ENOMEM in this case is good enough, removing the redundant dev_err message.

In cxl/core/region.c, the else is not required after the return statement, cleaned it up.

Verified the build and sanity by booting the guest VM using the freshly built components.

Raghu Halharvi (2):
cxl/mbox: Remove redundant dev_err() after failed mem alloc cxl/region: Remove else after return statement

 drivers/cxl/core/mbox.c   | 4 +---
 drivers/cxl/core/region.c | 8 ++++----
 2 files changed, 5 insertions(+), 7 deletions(-)

base-commit: 0b5547c51827e053cc754db47d3ec3e6c2c451d2

Signature · 1 line
2.39.2