Skip to contentSkip to conversation

ata: pata_ns87415: mark ns87560_tf_read static

PATCH Superseded Arnd Bergmann 3 participants 3 messages Jul 26, 2023 – Jul 27, 2023 libata

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ata: pata_ns87415: mark ns87560_tf_read static

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

drivers/parport/parport_gsc.c: At top level:
drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]

There are no other references to this, so just make it static.

Fixes c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
---
 drivers/ata/pata_ns87415.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_ns87415.c +1 -1
index d60e1f69d7b02..c697219a61a2d 100644
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
  *	LOCKING:
  *	Inherited from caller.
  */
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
 {
 	struct ata_ioports *ioaddr = &ap->ioaddr;
 
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

drivers/parport/parport_gsc.c: At top level:
drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]

Wrong pasting? :-)

Quoted 4 lines

There are no other references to this, so just make it static.

Fixes c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")

With the messages fixed:

[...]

MBR, Sergey

Reviewed-by on v1 1/1
#2 lore raw
In reply to Arnd Bergmann
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

drivers/parport/parport_gsc.c: At top level:
drivers/parport/parport_gsc.c:415:5: warning: no previous prototype for 'parport_gsc_init' [-Wmissing-prototypes]

There are no other references to this, so just make it static.

Fixes c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")

Looking good.

-Serge(y)

Quoted 20 lines
---
 drivers/ata/pata_ns87415.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_ns87415.c +1 -1
index d60e1f69d7b02..c697219a61a2d 100644
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
  *	LOCKING:
  *	Inherited from caller.
  */
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
 {
 	struct ata_ioports *ioaddr = &ap->ioaddr;
 
Signature · 1 line
2.39.2