Skip to contentSkip to conversation

ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5

PATCH Applied Lukasz Majewski 2 participants 4 messages Jul 27, 2023 – Aug 24, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5

Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows following device warning:

'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"'

This is not critical, as KSZ driver by itself assigns default value of tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).

However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps' has been specified with the default value of 2000 ps.

---
 arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +1 -0
index 99cd6d15998b..b66570080894 100644
@@ -152,6 +152,7 @@
 				label = "cpu";
 				ethernet = <&macb0>;
 				phy-mode = "rgmii-txid";
+				tx-internal-delay-ps = <2000>;
 
 				fixed-link {
 					speed = <1000>;
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Applied
#1 lore raw
Quoted 5 lines · Lukasz Majewski

Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows following device warning:

'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"'

Quoted 7 lines

This is not critical, as KSZ driver by itself assigns default value of tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).

However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps' has been specified with the default value of 2000 ps.

Applied to at91-dt, thanks!

#2 lore raw
In reply to Lukasz Majewski

Dear Community,

Quoted 7 lines

Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows following device warning:

'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"'

Quoted 7 lines

This is not critical, as KSZ driver by itself assigns default value of tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).

However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps' has been specified with the default value of 2000 ps.

Gentle ping on this patch.

Claudiu, could you pick it as well?

Quoted 11 lines
---
 arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index 99cd6d15998b..b66570080894 100644 --- a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++ b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -152,6 +152,7 @@ label = "cpu";

arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts line 158

Quoted 6 lines
arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +1 -0
 				ethernet = <&macb0>;
 				phy-mode = "rgmii-txid";
+				tx-internal-delay-ps = <2000>;
 
 				fixed-link {
 					speed = <1000>;

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email protected]

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#3 lore raw

Hi, Lukasz,

Quoted 12 lines · Lukasz Majewski

Dear Community,

Quoted 10 lines

Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1) shows following device warning:

'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on "phy-mode" property, please update device tree to specify "rx-internal-delay-ps" and "tx-internal-delay-ps"'

This is not critical, as KSZ driver by itself assigns default value of tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).

Quoted 8 lines
Quoted 4 lines

However, to avoid extra warnings in logs - the missing 'tx-internal-delay-ps' has been specified with the default value of 2000 ps.

Gentle ping on this patch.

Claudiu, could you pick it as well?

It's already in arm-soc:

https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/arch/arm/boot/dts/microchip?h=for-next

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel