Skip to contentSkip to conversation

media: Kconfig: imx290: Correct CCI dependency

PATCH In review Sakari Ailus 3 participants 4 messages Jul 29, 2023 – Aug 7, 2023 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 media: Kconfig: imx290: Correct CCI dependency

The Kconfig parts of the original patch converting the IMX290 to use V4L2 CCI was mis-merged. Correct this.

Fixes be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")
---
 drivers/media/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/Kconfig +1 -1
index 24cbf35c6fe1..f3453a5da970 100644
@@ -125,6 +125,7 @@ config VIDEO_IMX274
 config VIDEO_IMX290
 	tristate "Sony IMX290 sensor support"
 	select REGMAP_I2C
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor driver for the Sony
 	  IMX290 camera sensor.
@@ -934,7 +935,6 @@ config VIDEO_ADV748X
 	select VIDEO_V4L2_SUBDEV_API
 	select REGMAP_I2C
 	select V4L2_FWNODE
-	select V4L2_CCI_I2C
 	help
 	  V4L2 subdevice driver for the Analog Devices
 	  ADV7481 and ADV7482 HDMI/Analog video decoders.
Signature · 1 line
2.39.2
#1 lore raw

PATCH 2/2 media: Kconfig: ov5693: Correct CCI dependency

The Kconfig parts of the original patch converting the OV5693 to use V4L2 CCI was mis-merged. Correct this.

Fixes 9f4204c422f6 ("media: ov5693: Convert to new CCI register access helpers")
---
 drivers/media/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/Kconfig +1 -1
index f3453a5da970..07cdf9590a14 100644
@@ -426,6 +426,7 @@ config VIDEO_OV5675
 
 config VIDEO_OV5693
 	tristate "OmniVision OV5693 sensor support"
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor driver for the OmniVision
 	  OV5693 camera.
@@ -657,7 +658,6 @@ config VIDEO_DW9768
 	select MEDIA_CONTROLLER
 	select VIDEO_V4L2_SUBDEV_API
 	select V4L2_FWNODE
-	select V4L2_CCI_I2C
 	help
 	  This is a driver for the DW9768 camera lens voice coil.
 	  DW9768 is a 10 bit DAC with 100mA output current sink
Signature · 1 line
2.39.2
Reviewed-by on v1 1/2
#2 lore raw
In reply to Sakari Ailus

Hi,

Quoted 7 lines · Sakari Ailus

The Kconfig parts of the original patch converting the IMX290 to use V4L2 CCI was mis-merged. Correct this.

Fixes be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")

Thanks, the series looks good to me:

for the series.

Regards,

Hans

Quoted 24 lines
---
 drivers/media/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/Kconfig +1 -1
index 24cbf35c6fe1..f3453a5da970 100644
@@ -125,6 +125,7 @@ config VIDEO_IMX274
 config VIDEO_IMX290
 	tristate "Sony IMX290 sensor support"
 	select REGMAP_I2C
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor driver for the Sony
 	  IMX290 camera sensor.
@@ -934,7 +935,6 @@ config VIDEO_ADV748X
 	select VIDEO_V4L2_SUBDEV_API
 	select REGMAP_I2C
 	select V4L2_FWNODE
-	select V4L2_CCI_I2C
 	help
 	  V4L2 subdevice driver for the Analog Devices
 	  ADV7481 and ADV7482 HDMI/Analog video decoders.
Reviewed-by on v1 1/2
#3 lore raw
In reply to Sakari Ailus

Hi Sakari,

Thank you for the patch.

Quoted 16 lines · Sakari Ailus

The Kconfig parts of the original patch converting the IMX290 to use V4L2 CCI was mis-merged. Correct this.

Fixes be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")
---
 drivers/media/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/Kconfig +0 -0
index 24cbf35c6fe1..f3453a5da970 100644

drivers/media/i2c/Kconfig config VIDEO_IMX274 · line 127

Quoted 3 lines
drivers/media/i2c/Kconfig +0 -0
@@ -125,6 +125,7 @@ config VIDEO_IMX274
 config VIDEO_IMX290
 	tristate "Sony IMX290 sensor support"
 	select REGMAP_I2C

I think you can also drop REGMAP_I2C, as that's now internal to the CCI helpers.

Quoted 12 lines
drivers/media/i2c/Kconfig +1 -1
+	select V4L2_CCI_I2C
 	help
 	  This is a Video4Linux2 sensor driver for the Sony
 	  IMX290 camera sensor.
@@ -934,7 +935,6 @@ config VIDEO_ADV748X
 	select VIDEO_V4L2_SUBDEV_API
 	select REGMAP_I2C
 	select V4L2_FWNODE
-	select V4L2_CCI_I2C
 	help
 	  V4L2 subdevice driver for the Analog Devices
 	  ADV7481 and ADV7482 HDMI/Analog video decoders.
Signature · 3 lines
Regards,

Laurent Pinchart