media: Kconfig: imx290: Correct CCI dependency
PATCH 1/2 media: Kconfig: imx290: Correct CCI dependency
The Kconfig parts of the original patch converting the IMX290 to use V4L2 CCI was mis-merged. Correct this.
--- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/Kconfig +1 -1
@@ -125,6 +125,7 @@ config VIDEO_IMX274 config VIDEO_IMX290 tristate "Sony IMX290 sensor support" select REGMAP_I2C + select V4L2_CCI_I2C help This is a Video4Linux2 sensor driver for the Sony IMX290 camera sensor.
@@ -934,7 +935,6 @@ config VIDEO_ADV748X select VIDEO_V4L2_SUBDEV_API select REGMAP_I2C select V4L2_FWNODE - select V4L2_CCI_I2C help V4L2 subdevice driver for the Analog Devices ADV7481 and ADV7482 HDMI/Analog video decoders.
Signature · 1 line
2.39.2
PATCH 2/2 media: Kconfig: ov5693: Correct CCI dependency
The Kconfig parts of the original patch converting the OV5693 to use V4L2 CCI was mis-merged. Correct this.
--- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/i2c/Kconfig +1 -1
@@ -426,6 +426,7 @@ config VIDEO_OV5675 config VIDEO_OV5693 tristate "OmniVision OV5693 sensor support" + select V4L2_CCI_I2C help This is a Video4Linux2 sensor driver for the OmniVision OV5693 camera.
@@ -657,7 +658,6 @@ config VIDEO_DW9768 select MEDIA_CONTROLLER select VIDEO_V4L2_SUBDEV_API select V4L2_FWNODE - select V4L2_CCI_I2C help This is a driver for the DW9768 camera lens voice coil. DW9768 is a 10 bit DAC with 100mA output current sink
Signature · 1 line
2.39.2
Hi,
Quoted 7 lines · Sakari Ailus
The
Kconfigparts of the original patch converting the IMX290 to use V4L2 CCI was mis-merged. Correct this.Reported-by kernel test robot <[email protected]>Fixes be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")Signed-off-by Sakari Ailus <[email protected]>
Thanks, the series looks good to me:
for the series.
Regards,
Hans
Quoted 24 lines
--- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/Kconfig +1
-1@@ -125,6 +125,7 @@ config VIDEO_IMX274 config VIDEO_IMX290 tristate "Sony IMX290 sensor support" select REGMAP_I2C + select V4L2_CCI_I2C help This is a Video4Linux2 sensor driver for the Sony IMX290 camera sensor.@@ -934,7 +935,6 @@ config VIDEO_ADV748X select VIDEO_V4L2_SUBDEV_API select REGMAP_I2C select V4L2_FWNODE - select V4L2_CCI_I2C help V4L2 subdevice driver for the Analog Devices ADV7481 and ADV7482 HDMI/Analog video decoders.
Hi Sakari,
Thank you for the patch.
Quoted 16 lines · Sakari Ailus
The
Kconfigparts of the original patch converting the IMX290 to use V4L2 CCI was mis-merged. Correct this.Reported-by kernel test robot <[email protected]>Fixes be02a09c84ad ("media: imx290: Convert to new CCI register access helpers")Signed-off-by Sakari Ailus <[email protected]>--- drivers/media/i2c/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/i2c/Kconfig +0
-0
drivers/media/i2c/Kconfig config VIDEO_IMX274 · line 127
Quoted 3 lines
drivers/media/i2c/Kconfig +0
-0@@ -125,6 +125,7 @@ config VIDEO_IMX274 config VIDEO_IMX290 tristate "Sony IMX290 sensor support" select REGMAP_I2C
I think you can also drop REGMAP_I2C, as that's now internal to the CCI helpers.
Quoted 12 lines
drivers/media/i2c/Kconfig +1
-1+ select V4L2_CCI_I2C help This is a Video4Linux2 sensor driver for the Sony IMX290 camera sensor.@@ -934,7 +935,6 @@ config VIDEO_ADV748X select VIDEO_V4L2_SUBDEV_API select REGMAP_I2C select V4L2_FWNODE - select V4L2_CCI_I2C help V4L2 subdevice driver for the Analog Devices ADV7481 and ADV7482 HDMI/Analog video decoders.
Signature · 3 lines
Regards, Laurent Pinchart