selftests: rtc: Fixes rtctest error handling.
Subsystems (3)
PATCH v5 1/1 selftests: rtc: Fixes rtctest error handling.
Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.
---
changes since v4:
Updated the commit message.
changes since v3:
Added Linux-kselftest and Linux-kernel mailing lists.
changes since v2:
Changed error message when rtc file does not exist.
changes since v1:
Removed check for uid=0
If rtc file is invalid, then exit the test.
tools/testing/selftests/rtc/rtctest.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
tools/testing/selftests/rtc/rtctest.c +10 -1
@@ -17,6 +17,7 @@#include <unistd.h> #include "../kselftest_harness.h" +#include "../kselftest.h" #define NUM_UIE 3#define ALARM_DELTA 3
@@ -419,6 +420,8 @@ __constructor_order_last(void)int main (int argc,char **argv) { +int ret =-1 ; +switch (argc) {case 2 : rtc_file = argv[1 ];
@@ -430,5 +433,11 @@ int main(int argc, char **argv)return 1 ; } -return test_harness_run (argc, argv); +// Run the test if rtc_file is valid +if (access (rtc_file,F_OK ) ==0 ) + ret =test_harness_run (argc, argv); +else +ksft_exit_fail_msg ("[ERROR]: Cannot access rtc file %s - Exiting\n" , rtc_file); + +return ret; }
Signature · 6 lines
2.25.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Re: [PATCH v5] selftests: rtc: Improve rtctest error handling
Quoted 2 lines
Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessible.
Will the attention grow for the application of “imperative mood” in change descriptions?
How do you think about to add the tag “Fixes”?
Would any other subject become more appropriate for your patch?
Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Re: [PATCH v5] selftests: rtc: Improve rtctest error handling
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them.
thanks,
greg k-h's patch email bot
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
Re: [v5] selftests: rtc: Improve rtctest error handling
Quoted 1 line
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
I hope that the “intelligence” can be improved also for this software component.
Quoted 2 lines
Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list.
…
This automated response is a questionable side effect of known recurring communication difficulties, isn't it?
Quoted 2 lines
Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all.
…
I hope that this request will be reconsidered in more detail especially when my change suggestions can be interpreted as reminders from the Linux development documentation for a discussed patch.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n3
Will the chances ever grow to resolve affected aspects in more constructive ways?
Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees