Skip to contentSkip to conversation

bus: omap_l3_smx: identify timeout cause before rebooting

PATCH In review Sicelo A. Mhlongo 3 participants 3 messages Aug 1, 2023 – Aug 9, 2023 OMAP2+ support

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 bus: omap_l3_smx: identify timeout cause before rebooting

Identify and print the error source before rebooting the board due to an l3 timeout error. This is helpful when debugging, e.g. via serial.

---
 drivers/bus/omap_l3_smx.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)
drivers/bus/omap_l3_smx.c +10 -11
index bb1606f5ce2d..8e1a38bfcd8b 100644
@@ -166,19 +166,10 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
 	irqreturn_t ret = IRQ_NONE;
 
 	int_type = irq == l3->app_irq ? L3_APPLICATION_ERROR : L3_DEBUG_ERROR;
-	if (!int_type) {
+	if (!int_type)
 		status = omap3_l3_readll(l3->rt, L3_SI_FLAG_STATUS_0);
-		/*
-		 * if we have a timeout error, there's nothing we can
-		 * do besides rebooting the board. So let's BUG on any
-		 * of such errors and handle the others. timeout error
-		 * is severe and not expected to occur.
-		 */
-		BUG_ON(status & L3_STATUS_0_TIMEOUT_MASK);
-	} else {
+	else
 		status = omap3_l3_readll(l3->rt, L3_SI_FLAG_STATUS_1);
-		/* No timeout error for debug sources */
-	}
 
 	/* identify the error source */
 	err_source = __ffs(status);
@@ -190,6 +181,14 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
 		ret |= omap3_l3_block_irq(l3, error, error_addr);
 	}
 
+	/*
+	 * if we have a timeout error, there's nothing we can
+	 * do besides rebooting the board. So let's BUG on any
+	 * of such errors and handle the others. timeout error
+	 * is severe and not expected to occur.
+	 */
+	BUG_ON(!int_type && status & L3_STATUS_0_TIMEOUT_MASK);
+
 	/* Clear the status register */
 	clear = (L3_AGENT_STATUS_CLEAR_IA << int_type) |
 		L3_AGENT_STATUS_CLEAR_TA;
Signature · 1 line
2.40.1
Reviewed-by on v3 1/1
#1 lore raw

Hi,

Quoted 7 lines · Sicelo A. Mhlongo

Identify and print the error source before rebooting the board due to an l3 timeout error. This is helpful when debugging, e.g. via serial.

---
 drivers/bus/omap_l3_smx.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

nice, adding features with a negative diffstat :)

-- Sebastian

Quoted 44 lines
drivers/bus/omap_l3_smx.c +10 -11
index bb1606f5ce2d..8e1a38bfcd8b 100644
@@ -166,19 +166,10 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
 	irqreturn_t ret = IRQ_NONE;
 
 	int_type = irq == l3->app_irq ? L3_APPLICATION_ERROR : L3_DEBUG_ERROR;
-	if (!int_type) {
+	if (!int_type)
 		status = omap3_l3_readll(l3->rt, L3_SI_FLAG_STATUS_0);
-		/*
-		 * if we have a timeout error, there's nothing we can
-		 * do besides rebooting the board. So let's BUG on any
-		 * of such errors and handle the others. timeout error
-		 * is severe and not expected to occur.
-		 */
-		BUG_ON(status & L3_STATUS_0_TIMEOUT_MASK);
-	} else {
+	else
 		status = omap3_l3_readll(l3->rt, L3_SI_FLAG_STATUS_1);
-		/* No timeout error for debug sources */
-	}
 
 	/* identify the error source */
 	err_source = __ffs(status);
@@ -190,6 +181,14 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3)
 		ret |= omap3_l3_block_irq(l3, error, error_addr);
 	}
 
+	/*
+	 * if we have a timeout error, there's nothing we can
+	 * do besides rebooting the board. So let's BUG on any
+	 * of such errors and handle the others. timeout error
+	 * is severe and not expected to occur.
+	 */
+	BUG_ON(!int_type && status & L3_STATUS_0_TIMEOUT_MASK);
+
 	/* Clear the status register */
 	clear = (L3_AGENT_STATUS_CLEAR_IA << int_type) |
 		L3_AGENT_STATUS_CLEAR_TA;
Signature · 1 line
2.40.1
maintainer
#2 lore raw
Quoted 6 lines · Sebastian Reichel

Hi,

Quoted 3 lines · Sicelo A. Mhlongo

Identify and print the error source before rebooting the board due to an l3 timeout error. This is helpful when debugging, e.g. via serial.

Quoted 8 lines
Quoted 4 lines
---
 drivers/bus/omap_l3_smx.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

nice, adding features with a negative diffstat :)

Great, I'll add this to omap-for-v6.6/ti-sysc branch. The omap_l3_smx deals with interconnect related issues and is closely coupled with ti-sysc driver.

Regards,

Tony