bus: omap_l3_smx: identify timeout source before rebooting
PATCH 1/1 bus: omap_l3_smx: identify timeout source before rebooting
Identify and print the error source before rebooting the board due to an l3 application timeout error, by delaying the BUG_ON. This is helpful when debugging, e.g. via serial.
--- drivers/bus/omap_l3_smx.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/bus/omap_l3_smx.c +8 -4
@@ -170,11 +170,9 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) status =omap3_l3_readll (l3->rt,L3_SI_FLAG_STATUS_0 );/* * if we have a timeout error, there's nothing we can -* do besides rebooting the board. So let's BUG on any -* of such errors and handle the others. timeout error -* is severe and not expected to occur. +* do besides rebooting the board after identifying the +* error source. */ -BUG_ON (status &L3_STATUS_0_TIMEOUT_MASK ); }else { status =omap3_l3_readll (l3->rt,L3_SI_FLAG_STATUS_1 );/* No timeout error for debug sources */
@@ -190,6 +188,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) ret |=omap3_l3_block_irq (l3, error, error_addr); } +/* +* BUG on application timeout errors since they are severe and not +* expected to occur. +*/ +BUG_ON (status &L3_STATUS_0_TIMEOUT_MASK ); +/* Clear the status register */ clear = (L3_AGENT_STATUS_CLEAR_IA << int_type) |L3_AGENT_STATUS_CLEAR_TA ;
Signature · 1 line
2.40.1
Tony Lindgren
maintainerQuoted 3 lines · Sicelo A. Mhlongo
Identify and print the error source before rebooting the board due to an l3 application timeout error, by delaying the
BUG_ON. This is helpful when debugging, e.g. via serial.
Makes sense to try to show some information, but please see the question below.
Quoted 19 lines
drivers/bus/omap_l3_smx.c +2
-4@@ -170,11 +170,9 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) status =omap3_l3_readll (l3->rt,L3_SI_FLAG_STATUS_0 );/* * if we have a timeout error, there's nothing we can -* do besides rebooting the board. So let's BUG on any -* of such errors and handle the others. timeout error -* is severe and not expected to occur. +* do besides rebooting the board after identifying the +* error source. */ -BUG_ON (status &L3_STATUS_0_TIMEOUT_MASK ); }else { status =omap3_l3_readll (l3->rt,L3_SI_FLAG_STATUS_1 );/* No timeout error for debug sources */
drivers/bus/omap_l3_smx.c static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) · line 195
Quoted 8 lines
drivers/bus/omap_l3_smx.c +5
-0@@ -190,6 +188,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) ret |=omap3_l3_block_irq (l3, error, error_addr); } +/* +* BUG on application timeout errors since they are severe and not +* expected to occur. +*/ +BUG_ON (status &L3_STATUS_0_TIMEOUT_MASK );
Aren't you now checking the bit for both L3_SI_FLAG_STATUS_0 and L3_SI_FLAG_STATUS_1 register values? I think it should be only for register L3_SI_FLAG_STATUS_0 value?
Regards,
Tony
Hi,
Quoted 30 lines · Tony Lindgren
Quoted 3 lines · Sicelo A. Mhlongo
Identify and print the error source before rebooting the board due to an l3 application timeout error, by delaying the
BUG_ON. This is helpful when debugging, e.g. via serial.Makes sense to try to show some information, but please see the question below.
Quoted 22 lines
drivers/bus/omap_l3_smx.c +2
-4@@ -170,11 +170,9 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) status =omap3_l3_readll (l3->rt,L3_SI_FLAG_STATUS_0 );/* * if we have a timeout error, there's nothing we can -* do besides rebooting the board. So let's BUG on any -* of such errors and handle the others. timeout error -* is severe and not expected to occur. +* do besides rebooting the board after identifying the +* error source. */ -BUG_ON (status &L3_STATUS_0_TIMEOUT_MASK ); }else { status =omap3_l3_readll (l3->rt,L3_SI_FLAG_STATUS_1 );/* No timeout error for debug sources */ @@ -190,6 +188,12 @@ static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) ret |=omap3_l3_block_irq (l3, error, error_addr); }
Quoted 10 lines
drivers/bus/omap_l3_smx.c static irqreturn_t omap3_l3_app_irq(int irq, void *_l3) · line 195
Quoted 5 lines
drivers/bus/omap_l3_smx.c +5
-0+/* +* BUG on application timeout errors since they are severe and not +* expected to occur. +*/ +BUG_ON (status &L3_STATUS_0_TIMEOUT_MASK );Aren't you now checking the bit for both
L3_SI_FLAG_STATUS_0andL3_SI_FLAG_STATUS_1register values? I think it should be only for registerL3_SI_FLAG_STATUS_0value?
Ah, you are right. It should be:
`BUG_ON(!int_type && status & L3_STATUS_0_TIMEOUT_MASK);`
I'll send in a v2.
Thanks
Sicelo