Skip to contentSkip to conversation

drm/buddy: Fix drm buddy info output format

PATCH In review Ma Jun 3 participants 3 messages Aug 4, 2023 – Aug 7, 2023

Subsystems (3)
lore
Share & tools
lore

Ma Jun

author
#0 lore raw

PATCH 1/1 drm/buddy: Fix drm buddy info output format

[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.

---
 drivers/gpu/drm/drm_buddy.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_buddy.c +4 -4
index 3d1f50f481cf..ef3dd15c334a 100644
@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p)
 			count++;
 		}
 
-		drm_printf(p, "order-%d ", order);
+		drm_printf(p, "order-%2d ", order);
 
 		free = count * (mm->chunk_size << order);
 		if (free < SZ_1M)
-			drm_printf(p, "free: %lluKiB", free >> 10);
+			drm_printf(p, "free: %8llu KiB", free >> 10);
 		else
-			drm_printf(p, "free: %lluMiB", free >> 20);
+			drm_printf(p, "free: %8llu MiB", free >> 20);
 
-		drm_printf(p, ", pages: %llu\n", count);
+		drm_printf(p, ", blocks: %llu\n", count);
 	}
 }
 EXPORT_SYMBOL(drm_buddy_print);
Signature · 1 line
2.34.1
#1 lore raw

Am 04.08.23 um 08:56 schrieb Ma Jun:

Quoted 4 lines

[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.

Of hand looks good to me, but Arun should probably judge.

Christian.

Quoted 28 lines
---
  drivers/gpu/drm/drm_buddy.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_buddy.c +4 -4
index 3d1f50f481cf..ef3dd15c334a 100644
@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p)
  			count++;
  		}
 
-		drm_printf(p, "order-%d ", order);
+		drm_printf(p, "order-%2d ", order);
 
  		free = count * (mm->chunk_size << order);
  		if (free < SZ_1M)
-			drm_printf(p, "free: %lluKiB", free >> 10);
+			drm_printf(p, "free: %8llu KiB", free >> 10);
  		else
-			drm_printf(p, "free: %lluMiB", free >> 20);
+			drm_printf(p, "free: %8llu MiB", free >> 20);
 
-		drm_printf(p, ", pages: %llu\n", count);
+		drm_printf(p, ", blocks: %llu\n", count);
  	}
  }
  EXPORT_SYMBOL(drm_buddy_print);
maintainer Reviewed-by
#2 lore raw

looks good to me as well.

Quoted 37 lines · Christian König

Am 04.08.23 um 08:56 schrieb Ma Jun:

Quoted 4 lines

[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.

Of hand looks good to me, but Arun should probably judge.

Christian.

Quoted 26 lines

---
  drivers/gpu/drm/drm_buddy.c | 8 ++++----

  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_buddy.c +2 -1
index 3d1f50f481cf..ef3dd15c334a 100644
@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, 
 struct drm_printer *p)
               count++;
           }
   -        drm_printf(p, "order-%d ", order);
+        drm_printf(p, "order-%2d ", order);
             free = count * (mm->chunk_size << order);
           if (free < SZ_1M)
-            drm_printf(p, "free: %lluKiB", free >> 10);
+            drm_printf(p, "free: %8llu KiB", free >> 10);

          else
-            drm_printf(p, "free: %lluMiB", free >> 20); +            drm_printf(p, "free: %8llu MiB", free >> 20); -        drm_printf(p, ", pages: %llu\n", count); +        drm_printf(p, ", blocks: %llu\n", count); }
  }
  EXPORT_SYMBOL(drm_buddy_print);