drm/buddy: Fix drm buddy info output format
Subsystems (3)
PATCH 1/1 drm/buddy: Fix drm buddy info output format
[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.
--- drivers/gpu/drm/drm_buddy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/drm_buddy.c +4 -4
@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p) count++; } -drm_printf (p,"order-%d " , order); +drm_printf (p,"order-%2d " , order); free = count * (mm->chunk_size << order);if (free <SZ_1M ) -drm_printf (p,"free: %lluKiB" , free >>10 ); +drm_printf (p,"free: %8llu KiB" , free >>10 );else -drm_printf (p,"free: %lluMiB" , free >>20 ); +drm_printf (p,"free: %8llu MiB" , free >>20 ); -drm_printf (p,", pages: %llu\n" , count); +drm_printf (p,", blocks: %llu\n" , count); } }EXPORT_SYMBOL (drm_buddy_print);
Signature · 1 line
2.34.1
Am 04.08.23 um 08:56 schrieb Ma Jun:
Quoted 4 lines
[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.Signed-off-by Ma Jun <[email protected]>
Of hand looks good to me, but Arun should probably judge.
Christian.
Quoted 28 lines
--- drivers/gpu/drm/drm_buddy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_buddy.c +4
-4@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p) count++; } -drm_printf (p,"order-%d " , order); +drm_printf (p,"order-%2d " , order); free = count * (mm->chunk_size << order);if (free <SZ_1M ) -drm_printf (p,"free: %lluKiB" , free >>10 ); +drm_printf (p,"free: %8llu KiB" , free >>10 );else -drm_printf (p,"free: %lluMiB" , free >>20 ); +drm_printf (p,"free: %8llu MiB" , free >>20 ); -drm_printf (p,", pages: %llu\n" , count); +drm_printf (p,", blocks: %llu\n" , count); } }EXPORT_SYMBOL (drm_buddy_print);
looks good to me as well.
Quoted 37 lines · Christian König
Am 04.08.23 um 08:56 schrieb Ma Jun:
Quoted 4 lines
[1] Change pages to blocks to avoid confusion.
[2] Fix output format to align the output info.Signed-off-by Ma Jun <[email protected]>Of hand looks good to me, but Arun should probably judge.
Christian.
Quoted 26 lines
---
drivers/gpu/drm/drm_buddy.c| 8 ++++----1 file changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/drm_buddy.c +2
-1@@ -781,15 +781,15 @@ void drm_buddy_print(struct drm_buddy *mm, struct drm_printer *p) count++; } - drm_printf(p, "order-%d ", order); + drm_printf(p, "order-%2d ", order); free = count * (mm->chunk_size << order); if (free < SZ_1M) - drm_printf(p, "free: %lluKiB", free >> 10); + drm_printf(p, "free: %8llu KiB", free >> 10);else
-drm_printf(p, "free: %lluMiB", free >> 20); +drm_printf(p, "free: %8llu MiB", free >> 20); -drm_printf(p, ", pages: %llu\n", count); +drm_printf(p, ", blocks: %llu\n", count); }
}
EXPORT_SYMBOL(drm_buddy_print);