Skip to contentSkip to conversation

media: ivsc: Improve Kconfig help text

PATCH Superseded Sakari Ailus 3 participants 4 messages Aug 4, 2023 – Aug 7, 2023

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH 1/1 media: ivsc: Improve Kconfig help text

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
 drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +6 -2
index 9535ac10f4f7..e9d94dbb4305 100644
@@ -8,5 +8,9 @@ config INTEL_VSC
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
 	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing
-	  Unit(IPU) driver of Intel.
+	  camera sensor ownership between IVSC and host CPU (ACE) as well
+	  as configuring the CSI-2 link (CSI) towards the Image Processing
+	  Unit (IPU) driver of Intel.
+
+	  The modules will be called ivsc-csi and ivsc-ace.
+
Signature · 1 line
2.39.2
#1 lore raw

Hi Sakari,

Thank you for the patch.

Quoted 14 lines · Sakari Ailus

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
 drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +0 -0
index 9535ac10f4f7..e9d94dbb4305 100644

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 11

Quoted 6 lines
drivers/media/pci/intel/ivsc/Kconfig +1 -2
@@ -8,5 +8,9 @@ config INTEL_VSC
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
 	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing
-	  Unit(IPU) driver of Intel.
+	  camera sensor ownership between IVSC and host CPU (ACE) as well

What does ACE stand for ?

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 13

Quoted 2 lines
drivers/media/pci/intel/ivsc/Kconfig +2 -0
+	  as configuring the CSI-2 link (CSI) towards the Image Processing
+	  Unit (IPU) driver of Intel.

If I understand things correctly, this is about routing the data from the sensor to the IVSC output towards the host. Is that right ? If so, let's make that explicit.

Quoted 3 lines
drivers/media/pci/intel/ivsc/Kconfig +3 -0
+
+	  The modules will be called ivsc-csi and ivsc-ace.
+
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#2 lore raw

Hi Laurent,

Quoted 28 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 14 lines · Sakari Ailus

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
 drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +0 -0
index 9535ac10f4f7..e9d94dbb4305 100644

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 11

Quoted 6 lines
drivers/media/pci/intel/ivsc/Kconfig +1 -2
@@ -8,5 +8,9 @@ config INTEL_VSC
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
 	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing
-	  Unit(IPU) driver of Intel.
+	  camera sensor ownership between IVSC and host CPU (ACE) as well

What does ACE stand for ?

Quoted 6 lines

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 13

Quoted 2 lines
drivers/media/pci/intel/ivsc/Kconfig +2 -0
+	  as configuring the CSI-2 link (CSI) towards the Image Processing
+	  Unit (IPU) driver of Intel.

If I understand things correctly, this is about routing the data from the sensor to the IVSC output towards the host. Is that right ? If so, let's make that explicit.

Yes, I'll add that for v2.

Quoted 5 lines
Quoted 4 lines
drivers/media/pci/intel/ivsc/Kconfig +3 -0
+
+	  The modules will be called ivsc-csi and ivsc-ace.
+
Signature · 3 lines
Regards,

Sakari Ailus
#3 lore raw
In reply to Laurent Pinchart

Hi Laurent,

Quoted 25 lines

-----Original Message-----
From: Laurent Pinchart <[email protected]>

Hi Sakari,

Thank you for the patch.

Quoted 17 lines · Sakari Ailus

Improve the Kconfig help text to convey the ACE is for changing camera sensor ownership and CSI for configuring the CSI-2 rx and tx.

---
 drivers/media/pci/intel/ivsc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/media/pci/intel/ivsc/Kconfig +0 -0
index 9535ac10f4f7..e9d94dbb4305 100644
@@ -8,5 +8,9 @@ config INTEL_VSC
 	  This adds support for Intel Visual Sensing Controller (IVSC).
 
Quoted 6 lines

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 11

Quoted 4 lines
drivers/media/pci/intel/ivsc/Kconfig +1 -2
 	  Enables the IVSC firmware services required for controlling
-	  camera sensor ownership and CSI-2 link through Image Processing
-	  Unit(IPU) driver of Intel.
+	  camera sensor ownership between IVSC and host CPU (ACE) as well

What does ACE stand for ?

Below is from cover letter of my IVSC patch, hope that answer your question.

"""
Switching ownership requires an interface with two different hardware modules inside IVSC.
The software interface to these modules is via Intel MEI (The Intel Management Engine) commands.
These two hardware modules have two different MEI UUIDs to enumerate. These hardware modules are:
- ACE (Algorithm Context Engine): This module is for algorithm computing when IVSC owns camera sensor.
Also ACE module controls camera sensor's ownership. This hardware module is used to set ownership of camera sensor.
- CSI (Camera Serial Interface): This module is used to route camera sensor data either to IVSC or to host for IPU driver and application.
"""

BR,
Wentong

Quoted 15 lines

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 13

Quoted 3 lines
drivers/media/pci/intel/ivsc/Kconfig +2 -0
+	  as configuring the CSI-2 link (CSI) towards the Image Processing
+	  Unit (IPU) driver of Intel.

If I understand things correctly, this is about routing the data from the sensor to the IVSC output towards the host. Is that right ? If so, let's make that explicit.

drivers/media/pci/intel/ivsc/Kconfig config INTEL_VSC · line 16

Quoted 3 lines
drivers/media/pci/intel/ivsc/Kconfig +3 -0
+
+	  The modules will be called ivsc-csi and ivsc-ace.
+

--
Regards,

Laurent Pinchart