ARM: dts: Facebook Yosemite 4 platform
Subsystems (2)
v7 cover ARM: dts: Facebook Yosemite 4 platform
Add linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.
Changelog:
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting
- Remove duplicated multi-master setting
v4 - Resend with cover letter
v3 - Revise the bootargs to stdout-path
- Revise i2c devices
v2 - Revise the DTS node name
v1 - Add binding document
Delphine CC Chiu (2):
dt-bindings: arm: aspeed: add Facebook Yosemite 4 board
ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
.../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 633 ++++++++++++++++++ 3 files changed, 635 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
Signature · 1 line
2.25.1
PATCH v7 1/2 dt-bindings: arm: aspeed: add Facebook Yosemite 4 board
Document the new compatibles used on Facebook Yosemite 4.
---
Changelog:
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4
--- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
@@ -79,6 +79,7 @@ properties: - facebook,elbert-bmc - facebook,fuji-bmc - facebook,greatlakes-bmc + - facebook,yosemite4-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmc
Signature · 1 line
2.25.1
Re: [PATCH v7 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite 4 board
Quoted 4 lines · Delphine CC Chiu
Document the new compatibles used on Facebook Yosemite 4.
Signed-off-by Delphine CC Chiu <[email protected]>---
Best regards,
Krzysztof
PATCH v7 2/2 ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
In reply to Delphine CC ChiuAdd linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.
---
Changelog:
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting
- Remove duplicated multi-master setting
v3 - Revise the bootargs to stdout-path
- Revise i2c devices
v2 - Revise the DTS node name
--- arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 633 ++++++++++++++++++ 2 files changed, 634 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-wedge400.dtb \ aspeed-bmc-facebook-yamp.dtb \ aspeed-bmc-facebook-yosemitev2.dtb \ + aspeed-bmc-facebook-yosemite4.dtb \ aspeed-bmc-ibm-bonnell.dtb \ aspeed-bmc-ibm-everest.dtb \ aspeed-bmc-ibm-rainier.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +633 -0
633 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
Quoted 5 lines · Delphine CC Chiu
Add linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.Signed-off-by Delphine CC Chiu <[email protected]>---
Best regards,
Krzysztof
Joel Stanley
maintainerRe: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
In reply to Delphine CC ChiuQuoted 3 lines · Delphine CC Chiu
Add linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.
Convention is to mention what kind of machine this is, to give us some context for review. "This is an x86 server" or similar. Take a look at existing aspeed device tree commits for inspiration.
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 98
Quoted 13 lines
+&mac2 {
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +12
-0+ status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii3_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>;
None of these are properties that mainline Linux supports. Do you plan on sending patches for these?
Quoted 16 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +16
-0+}; + +&mac3 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +};
Joel Stanley
maintainerRe: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
Quoted 6 lines · Joel Stanley
Quoted 3 lines · Delphine CC Chiu
Add linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.
There were also some of these annoying warnings. Please try to fix them up in your next version:
../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:460.4-14:
Warning (reg_format):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:510.4-14:
Warning (reg_format):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:567.4-14:
Warning (reg_format):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 73/i2c at 0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:578.4-14:
Warning (reg_format):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 73/i2c at 1:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:457.9-505.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 0: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:457.9-505.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 0: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:507.9-555.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 1: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:507.9-555.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 1: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:564.9-573.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 73/i2c at 0: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:564.9-573.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 73/i2c at 0: Relying on default #size-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:575.9-584.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 73/i2c at 1: Relying on default #address-cells value ../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:575.9-584.5:
Warning (avoid_default_addr_size):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 73/i2c at 1: Relying on default #size-cells value
Joel Stanley
maintainerRe: [PATCH v7 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite 4 BMC
Quoted 9 lines · Joel Stanley
Quoted 6 lines · Joel Stanley
Quoted 3 lines · Delphine CC Chiu
Add linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.
Quoted 7 lines
There were also some of these annoying warnings. Please try to fix them up in your next version:
../arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts:460.4-14:
Warning (reg_format):
/ahb/apb/bus at 1e78a000/i2c-bus at 780/i2c-mux at 71/i2c at 0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)@@ -450,6 +450,9 @@ eeprom at 51 {
This silenced most of them:
i2c-mux at 71 {
compatible = "nxp,pca9846";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
idle-state = <0>;
i2c-mux-idle-disconnect;
reg = <0x71>;@@ -557,6 +560,9 @@ gpio at 61 {
i2c-mux at 73 {
compatible = "nxp,pca9544";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
idle-state = <0>;
i2c-mux-idle-disconnect;
reg = <0x73>;And then this fixed the remaining one:
@@ -423,7 +423,7 @@ power-sensor at 42 {
reg = <0x42>;
};- power-sensor at 41 {
+ power-sensor at 43 {
compatible = "ti,ina230";
reg = <0x43>;
};Please fold in these changes in your next version.