thermal: max77620_thermal: removed unneeded call to platform_set_drvdata()
PATCH 1/1 thermal: max77620_thermal: removed unneeded call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
--- drivers/thermal/max77620_thermal.c | 2 -- 1 file changed, 2 deletions(-)
drivers/thermal/max77620_thermal.c +0 -2
@@ -139,8 +139,6 @@ static int max77620_thermal_probe(struct platform_device *pdev)return ret; } -platform_set_drvdata (pdev, mtherm); -return 0 ; }
Signature · 1 line
2.34.1
Quoted 6 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.
I was (at first) tempted to say that this may be reduced to "return devm_request_threaded_irq(...)", but after a while, I thought that this is quite fine on it's own.
Just removing the 'platform_set_drvdata(...)' does add a bit of neat symmetry to the code.
So
Quoted 21 lines
Signed-off-by Andrei Coardos <[email protected]>--- drivers/thermal/max77620_thermal.c | 2 -- 1 file changed, 2 deletions(-)drivers/thermal/max77620_thermal.c +0
-3@@ -139,8 +139,6 @@ static int max77620_thermal_probe(struct platform_device *pdev)return ret; } -platform_set_drvdata (pdev, mtherm); -return 0 ; } --2.34.1
Daniel Lezcano
AppliedQuoted 7 lines · Andrei Coardos
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata()call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.Signed-off-by Andrei Coardos <[email protected]>---
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog