Skip to contentSkip to conversation

thermal: max77620_thermal: removed unneeded call to platform_set_drvdata()

PATCH Applied Andrei Coardos 3 participants 3 messages Aug 11, 2023 – Aug 16, 2023 Thermal

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal: max77620_thermal: removed unneeded call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---
 drivers/thermal/max77620_thermal.c | 2 --
 1 file changed, 2 deletions(-)
drivers/thermal/max77620_thermal.c +0 -2
index 61c7622d9945..919b6ee208d8 100644
@@ -139,8 +139,6 @@ static int max77620_thermal_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	platform_set_drvdata(pdev, mtherm);
-
 	return 0;
 }
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

I was (at first) tempted to say that this may be reduced to "return devm_request_threaded_irq(...)", but after a while, I thought that this is quite fine on it's own.
Just removing the 'platform_set_drvdata(...)' does add a bit of neat symmetry to the code.

So

Quoted 21 lines
---
 drivers/thermal/max77620_thermal.c | 2 --
 1 file changed, 2 deletions(-)
drivers/thermal/max77620_thermal.c +0 -3
index 61c7622d9945..919b6ee208d8 100644
@@ -139,8 +139,6 @@ static int max77620_thermal_probe(struct platform_device *pdev)
                return ret;
        }
 
-       platform_set_drvdata(pdev, mtherm);
-
        return 0;
 }
 
--

2.34.1

#2 lore raw
In reply to Andrei Coardos
Quoted 7 lines · Andrei Coardos

This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file.

---

Applied, thanks

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog