Skip to contentSkip to conversation

tests/amdgpu: Fix build error due to external file include

PATCH In review Aurabindo Pillai 3 participants 4 messages Aug 22, 2023

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 tests/amdgpu: Fix build error due to external file include

Remove the external file include that causes build error on certain systems configured in the CI.

---
 tests/amdgpu/amd_odm.c | 1 -
 1 file changed, 1 deletion(-)
tests/amdgpu/amd_odm.c +0 -1
index 2781ad1c2..839f2de3f 100644
@@ -5,7 +5,6 @@
 
 #include <fcntl.h>
 #include <stdio.h>
-#include <xf86drmMode.h>
 
 #include "igt.h"
 #include "igt_amd.h"
Signature · 1 line
2.41.0
Acked-by on v4 1/1
#1 lore raw

Hi Aurabindo,

Quoted 13 lines · Aurabindo Pillai

Remove the external file include that causes build error on certain systems configured in the CI.

---
 tests/amdgpu/amd_odm.c | 1 -
 1 file changed, 1 deletion(-)
tests/amdgpu/amd_odm.c +0 -0
index 2781ad1c2..839f2de3f 100644

tests/amdgpu/amd_odm.c line 8

Quoted 4 lines
tests/amdgpu/amd_odm.c +0 -1
@@ -5,7 +5,6 @@
 
 #include <fcntl.h>
 #include <stdio.h>
-#include <xf86drmMode.h>

Will this test work without xf86drmMode.h?
If it is kms test you may just include igt_kms.h but first apply fix (or revert).

Regards,
Kamil

Quoted 6 lines
tests/amdgpu/amd_odm.c +0 -0
 #include "igt.h"
 #include "igt_amd.h"
Signature · 1 line
2.41.0
#2 lore raw
Quoted 23 lines · Kamil Konieczny

Hi Aurabindo,

Quoted 13 lines · Aurabindo Pillai

Remove the external file include that causes build error on certain systems configured in the CI.

---
  tests/amdgpu/amd_odm.c | 1 -
  1 file changed, 1 deletion(-)
tests/amdgpu/amd_odm.c +0 -0
index 2781ad1c2..839f2de3f 100644

tests/amdgpu/amd_odm.c line 8

Quoted 4 lines
tests/amdgpu/amd_odm.c +0 -1
@@ -5,7 +5,6 @@
 
  #include <fcntl.h>
  #include <stdio.h>
-#include <xf86drmMode.h>
Quoted 3 lines

Will this test work without xf86drmMode.h?
If it is kms test you may just include igt_kms.h but first apply fix (or revert).

Yes, looks like IGT already includes all the necessary headers.

Quoted 10 lines

Regards,
Kamil

Quoted 6 lines
tests/amdgpu/amd_odm.c +0 -0
  #include "igt.h"
  #include "igt_amd.h"
Signature · 1 line
2.41.0
Signature · 4 lines
--

Thanks & Regards,
Jay