tests/amdgpu: Fix build error due to external file include
PATCH v4 1/1 tests/amdgpu: Fix build error due to external file include
Remove the external file include that causes build error on certain systems configured in the CI.
--- tests/amdgpu/amd_odm.c | 1 - 1 file changed, 1 deletion(-)
tests/amdgpu/amd_odm.c +0 -1
@@ -5,7 +5,6 @@#include <fcntl.h> #include <stdio.h> -#include <xf86drmMode.h> #include "igt.h" #include "igt_amd.h"
Signature · 1 line
2.41.0
Hi Aurabindo,
Quoted 13 lines · Aurabindo Pillai
Remove the external file include that causes build error on certain systems configured in the CI.
Signed-off-by Aurabindo Pillai <[email protected]>--- tests/amdgpu/amd_odm.c | 1 - 1 file changed, 1 deletion(-)tests/amdgpu/amd_odm.c +0
-0
tests/amdgpu/amd_odm.c line 8
Quoted 4 lines
tests/amdgpu/amd_odm.c +0
-1@@ -5,7 +5,6 @@#include <fcntl.h> #include <stdio.h> -#include <xf86drmMode.h>
Will this test work without xf86drmMode.h?
If it is kms test you may just include igt_kms.h but first apply fix (or revert).
Regards,
Kamil
Quoted 6 lines
tests/amdgpu/amd_odm.c +0
-0#include "igt.h" #include "igt_amd.h" Signature · 1 line
2.41.0
Quoted 23 lines · Kamil Konieczny
Hi Aurabindo,
Quoted 13 lines · Aurabindo Pillai
Remove the external file include that causes build error on certain systems configured in the CI.
Signed-off-by Aurabindo Pillai <[email protected]>--- tests/amdgpu/amd_odm.c | 1 - 1 file changed, 1 deletion(-)tests/amdgpu/amd_odm.c +0
-0tests/amdgpu/amd_odm.c line 8
Quoted 4 lines
tests/amdgpu/amd_odm.c +0
-1@@ -5,7 +5,6 @@#include <fcntl.h> #include <stdio.h> -#include <xf86drmMode.h> Acked-by Kamil Konieczny <[email protected]>
Quoted 3 lines
Will this test work without
xf86drmMode.h?
If it is kms test you may just includeigt_kms.hbut first apply fix (or revert).
Yes, looks like IGT already includes all the necessary headers.
Quoted 10 lines
Regards,
KamilQuoted 6 lines
tests/amdgpu/amd_odm.c +0
-0#include "igt.h" #include "igt_amd.h" Signature · 1 line
2.41.0
Signature · 4 lines
-- Thanks & Regards, Jay
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for tests/amdgpu: Fix build error due to external file include
In reply to Aurabindo Pillai== Series Details ==
== Series Details ==
Series: tests/amdgpu: Fix build error due to external file include
URL : https://patchwork.freedesktop.org/series/122761/
State : failure
== Summary ==
Series 122761 revision 1 was fully merged or fully failed: no git log