Skip to contentSkip to conversation

Packagegroup and irqbalance fixup

PATCH In review [email protected] 2 participants 7 messages Aug 22, 2023 – Aug 28, 2023

lore
Share & tools
lore
#0 lore raw

v2 cover Packagegroup and irqbalance fixup

From: Randolph Sapp <[email protected]>

Rework of previous series to include feedback and drop the additional packagegroup.

I was previously trying to mold a existing build target into something useful for RT applications (where the end user want's to cheat and not properly tune the system to their usecase) but that should have be addressed separately with a new build target. Maybe someone will revisit that eventually.

Randolph Sapp (3):
packagegroup-arago-bootstrap: fix RDEPENDS notation
packagegroup-arago-base: edit the description to describe current use
irqbalance: remove append to install systemd script

 .../recipes-core/packagegroups/packagegroup-arago-base.bb   | 2 +-
 .../packagegroups/packagegroup-arago-bootstrap.bb           | 2 +-
 .../recipes-extended/irqbalance/irqbalance_git.bbappend     | 6 +-----
 3 files changed, 3 insertions(+), 7 deletions(-)
Signature · 1 line
2.41.0
#1 lore raw

PATCH v2 1/3 packagegroup-arago-bootstrap: fix RDEPENDS notation

From: Randolph Sapp <[email protected]>

The RDEPENDS for this packagegroup was still using the legacy format so it was being evaluated as a do-nothing group. Enable it.

---
 .../recipes-core/packagegroups/packagegroup-arago-bootstrap.bb  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb +1 -1
index b0ec64b0..50f759be 100644
@@ -47,6 +47,6 @@ UTILS:append:k3 = " \
     k3conf \
 "
 
-RDEPENDS_${PN} = "\
+RDEPENDS:${PN} = "\
     ${UTILS} \
 "
Signature · 1 line
2.41.0
#2 lore raw

Re: [meta-arago][kirkstone/master][PATCHv2 1/3] packagegroup-arago-bootstrap: fix RDEPENDS notation

I believe this was already acked:

https://patchwork.yoctoproject.org/project/arago/patch/[email protected]/

Quoted 24 lines · On Tue, Aug 22, 2023 at 05:38:29PM -0500, [email protected] wrote:

From: Randolph Sapp <[email protected]>

The RDEPENDS for this packagegroup was still using the legacy format so it was being evaluated as a do-nothing group. Enable it.

---
 .../recipes-core/packagegroups/packagegroup-arago-bootstrap.bb  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb +1 -1
index b0ec64b0..50f759be 100644
@@ -47,6 +47,6 @@ UTILS:append:k3 = " \
     k3conf \
 "
 
-RDEPENDS_${PN} = "\
+RDEPENDS:${PN} = "\
     ${UTILS} \
 "
Signature · 1 line
2.41.0
#3 lore raw

PATCH v2 2/3 packagegroup-arago-base: edit the description to describe current use

In reply to [email protected]

From: Randolph Sapp <[email protected]>

Edit the description of this packagegroup to more accurately describe it's current use in this dependency web. Additionally convert the DESCRIPTION to SUMMARY, since this is under 72 characters and not full, long description.

---
 .../recipes-core/packagegroups/packagegroup-arago-base.bb       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +1 -1
index ff32112a..1f63a7d0 100644
@@ -1,4 +1,4 @@
-DESCRIPTION = "Basic task to get a device booting"
+SUMMARY = "Base tools that are recommended for most images"
 LICENSE = "MIT"
 PR = "r9"
 
Signature · 1 line
2.41.0
Acked-by on v2 2/3
#4 lore raw

Re: [meta-arago][kirkstone/master][PATCHv2 2/3] packagegroup-arago-base: edit the description to describe current use

Quoted 6 lines · On Tue, Aug 22, 2023 at 05:38:30PM -0500, [email protected] wrote:

From: Randolph Sapp <[email protected]>

Edit the description of this packagegroup to more accurately describe it's current use in this dependency web. Additionally convert the DESCRIPTION to SUMMARY, since this is under 72 characters and not full, long description.

Quoted 17 lines
---
 .../recipes-core/packagegroups/packagegroup-arago-base.bb       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +1 -1
index ff32112a..1f63a7d0 100644
@@ -1,4 +1,4 @@
-DESCRIPTION = "Basic task to get a device booting"
+SUMMARY = "Base tools that are recommended for most images"
 LICENSE = "MIT"
 PR = "r9"
 
Signature · 1 line
2.41.0
#5 lore raw

PATCH v2 3/3 irqbalance: remove append to install systemd script

In reply to [email protected]

From: Randolph Sapp <[email protected]>

The source recipe that this file appends to already has the corresponding logic to install both the systemd and sysvinit service and set them to load on start. No reason to override them.

---
 .../recipes-extended/irqbalance/irqbalance_git.bbappend     | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend +1 -5
index ff504150..7c289fc1 100644
@@ -1,8 +1,4 @@
 SRCREV = "c24ed221e9e82faf1ad22de133c3c97a0117c5d7"
-PV = "1.9.2"
-
-do_install:append () {
-         install -m 0644 ${S}/misc/irqbalance.service ${D}${systemd_unitdir}/system/irqbalanced.service
-}
+PV = "1.9.2+git${SRCPV}"
 
 PR:append = ".arago3"
Signature · 1 line
2.41.0
Acked-by on v2 3/3
#6 lore raw

Re: [meta-arago][kirkstone/master][PATCHv2 3/3] irqbalance: remove append to install systemd script

Quoted 5 lines · Randolph Sapp via lists.yoctoproject.org

From: Randolph Sapp <[email protected]>

The source recipe that this file appends to already has the corresponding logic to install both the systemd and sysvinit service and set them to load on start. No reason to override them.

Quoted 21 lines
---
 .../recipes-extended/irqbalance/irqbalance_git.bbappend     | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend +1 -5
index ff504150..7c289fc1 100644
@@ -1,8 +1,4 @@
 SRCREV = "c24ed221e9e82faf1ad22de133c3c97a0117c5d7"
-PV = "1.9.2"
-
-do_install:append () {
-         install -m 0644 ${S}/misc/irqbalance.service ${D}${systemd_unitdir}/system/irqbalanced.service
-}
+PV = "1.9.2+git${SRCPV}"
 
 PR:append = ".arago3"
Signature · 1 line
2.41.0