Packagegroup cleaning and a new proposal
cover Packagegroup cleaning and a new proposal
From: Randolph Sapp <[email protected]>
Clean up some package groups, introduce a new group for all-around useful tools that all images should inherit, and drop some unnecessary logic in the irqbalance append.
We'll have to talk a little more about what to do with the sysvinit images. I see no reason why we can't inherit the configuration mechanisms poky uses for multiple init systems, aside from having to fragment the package feeds accordingly.
Randolph Sapp (5):
packagegroup-arago-bootstrap: fix RDEPENDS notation
packagegroup-arago-base: edit the summary to describe current use
irqbalance: remove append to install systemd script
packagegroup-arago-boot: add a new group for all-around useful
packages
arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL
.../recipes-core/images/arago-image.inc | 1 + .../recipes-core/images/arago-tiny-image.inc | 1 + .../packagegroups/packagegroup-arago-base.bb | 2 +- .../packagegroups/packagegroup-arago-boot.bb | 17 +++++++++++++++++ .../packagegroup-arago-bootstrap.bb | 2 +- .../packagegroup-arago-tisdk-addons.bb | 1 - .../irqbalance/irqbalance_git.bbappend | 6 +----- 7 files changed, 22 insertions(+), 8 deletions(-) create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
Signature · 1 line
2.41.0
PATCH 1/5 packagegroup-arago-bootstrap: fix RDEPENDS notation
From: Randolph Sapp <[email protected]>
The RDEPENDS for this packagegroup was still using the legacy format so it was being evaluated as a do-nothing group. Enable it.
--- .../recipes-core/packagegroups/packagegroup-arago-bootstrap.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb +1 -1
@@ -47,6 +47,6 @@ UTILS:append:k3 = " \ k3conf \ " -RDEPENDS_${PN} = "\ +RDEPENDS:${PN} = "\ ${UTILS} \ "
Signature · 1 line
2.41.0
Re: [meta-arago][kirkstone/master][PATCH 1/5] packagegroup-arago-bootstrap: fix RDEPENDS notation
Quoted 4 lines · On Thu, Jul 27, 2023 at 07:20:28PM -0500, [email protected] wrote:
From: Randolph Sapp <[email protected]>
The RDEPENDS for this packagegroup was still using the legacy format so it was being evaluated as a do-nothing group. Enable it.
Good catch!
Quoted 1 line
Signed-off-by Randolph Sapp <[email protected]>
Quoted 18 lines
--- .../recipes-core/packagegroups/packagegroup-arago-bootstrap.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-bootstrap.bb +1
-1@@ -47,6 +47,6 @@ UTILS:append:k3 = " \ k3conf \ " -RDEPENDS_${PN} = "\ +RDEPENDS:${PN} = "\ ${UTILS} \ "Signature · 1 line
2.41.0
PATCH 2/5 packagegroup-arago-base: edit the summary to describe current use
In reply to [email protected]From: Randolph Sapp <[email protected]>
Edit the summary of this packagegroup to more accurately describe it's current use in this dependency web.
--- .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +1 -1
@@ -1,4 +1,4 @@ -DESCRIPTION = "Basic task to get a device booting" +DESCRIPTION = "Base tools that are recommended for most images" LICENSE = "MIT" PR = "r9"
Signature · 1 line
2.41.0
Re: [meta-arago][kirkstone/master][PATCH 2/5] packagegroup-arago-base: edit the summary to describe current use
Quoted 4 lines · On Thu, Jul 27, 2023 at 07:20:29PM -0500, [email protected] wrote:
From: Randolph Sapp <[email protected]>
Edit the summary of this packagegroup to more accurately describe it's current use in this dependency web.
May be worth to convert to SUMMARY as well...
Quoted 1 line
Signed-off-by Randolph Sapp <[email protected]>
Quoted 13 lines
--- .../recipes-core/packagegroups/packagegroup-arago-base.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-base.bb +1
-1@@ -1,4 +1,4 @@ -DESCRIPTION = "Basic task to get a device booting" +DESCRIPTION = "Base tools that are recommended for most images" LICENSE = "MIT" PR = "r9"
PATCH 3/5 irqbalance: remove append to install systemd script
In reply to [email protected]From: Randolph Sapp <[email protected]>
The source recipe that this file appends to already has the corresponding logic to install both the systemd and sysvinit service and set them to load on start. No reason to override them.
--- .../recipes-extended/irqbalance/irqbalance_git.bbappend | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
meta-arago-distro/recipes-extended/irqbalance/irqbalance_git.bbappend +1 -5
@@ -1,8 +1,4 @@ SRCREV = "c24ed221e9e82faf1ad22de133c3c97a0117c5d7" -PV = "1.9.2" - -do_install:append () { - install -m 0644 ${S}/misc/irqbalance.service ${D}${systemd_unitdir}/system/irqbalanced.service -} +PV = "1.9.2+git${SRCPV}" PR:append = ".arago3"
Signature · 1 line
2.41.0
PATCH 4/5 packagegroup-arago-boot: add a new group for all-around useful packages
In reply to [email protected]From: Randolph Sapp <[email protected]>
Add a new package group for performance or QoL tools that all images should inherit and add the first example of a package that should belong here.
Irqbalance is a good example. It helps reduce irq response delays on most if not all of our platforms and is only problematic for users attempting to reduce jitter specifically through the use of irq pinning, in which case it can be easily disabled.
--- .../recipes-core/images/arago-image.inc | 1 + .../packagegroups/packagegroup-arago-boot.bb | 17 +++++++++++++++++ .../packagegroup-arago-tisdk-addons.bb | 1 - 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb
meta-arago-distro/recipes-core/images/arago-image.inc +1 -0
@@ -11,6 +11,7 @@ EXTRA_IMAGECMD:ext2.gz += "-i 4096" IMAGE_INSTALL = " \ packagegroup-core-boot \ + packagegroup-arago-boot \ ${VIRTUAL-RUNTIME_initramfs} \ ${CORE_IMAGE_EXTRA_INSTALL} \ "
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb new file +17 -0
@@ -0,0 +1,17 @@ +SUMMARY = "Tools or utilities that all images should inherit" +DESCRIPTION = "These are packages that lead to general performance or QoL improvements on our platforms that should be inherited by all images. The idea is to keep this group as small as possible moving forward for compatibility with things like the tisdk-tiny-image build target." +LICENSE = "MIT" +PR = "r0" + +PACKAGE_ARCH = "${MACHINE_ARCH}" + +inherit packagegroup + +# packages that lead to general performance improvements +PERFORMANCE_UTILS = " \ + irqbalance \ +" + +RDEPENDS:${PN} = "\ + ${PERFORMANCE_UTILS} \ +"
meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb +0 -1
@@ -50,7 +50,6 @@ UTILS:append:omap-a15 = " mmc-utils \ UTILS:append:k3 = " mmc-utils \ switch-config \ - irqbalance \ ti-rpmsg-char \ ti-rpmsg-char-examples \ statcol \
Signature · 1 line
2.41.0
Re: [meta-arago][kirkstone/master][PATCH 4/5] packagegroup-arago-boot: add a new group for all-around useful packages
"boot" packagegroup is usually used to list mandatory components required to boot the target.
"base" is where you list a minimal set of additional components that are often useful, but the target can still boot without.
And one can argue that performance util like irqbalance doesn't fit either of the above. While is probably fine to be included in all default images except tiny. Come to think of it, "addons" was a perfect place for it...
Quoted 68 lines · Randolph Sapp via lists.yoctoproject.org
From: Randolph Sapp <[email protected]>
Add a new package group for performance or QoL tools that all images should inherit and add the first example of a package that should belong here.
Irqbalance is a good example. It helps reduce irq response delays on most if not all of our platforms and is only problematic for users attempting to reduce jitter specifically through the use of irq pinning, in which case it can be easily disabled.
Signed-off-by Randolph Sapp <[email protected]>--- .../recipes-core/images/arago-image.inc | 1 + .../packagegroups/packagegroup-arago-boot.bb | 17 +++++++++++++++++ .../packagegroup-arago-tisdk-addons.bb | 1 - 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bbmeta-arago-distro/recipes-core/images/arago-image.inc +1
-0@@ -11,6 +11,7 @@ EXTRA_IMAGECMD:ext2.gz += "-i 4096" IMAGE_INSTALL = " \ packagegroup-core-boot \ + packagegroup-arago-boot \ ${VIRTUAL-RUNTIME_initramfs} \ ${CORE_IMAGE_EXTRA_INSTALL} \ "meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-boot.bb new file +17
-0@@ -0,0 +1,17 @@ +SUMMARY = "Tools or utilities that all images should inherit" +DESCRIPTION = "These are packages that lead to general performance or QoL improvements on our platforms that should be inherited by all images. The idea is to keep this group as small as possible moving forward for compatibility with things like the tisdk-tiny-image build target." +LICENSE = "MIT" +PR = "r0" + +PACKAGE_ARCH = "${MACHINE_ARCH}" + +inherit packagegroup + +# packages that lead to general performance improvements +PERFORMANCE_UTILS = " \ + irqbalance \ +" + +RDEPENDS:${PN} = "\ + ${PERFORMANCE_UTILS} \ +"meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb +0
-1@@ -50,7 +50,6 @@ UTILS:append:omap-a15 = " mmc-utils \ UTILS:append:k3 = " mmc-utils \ switch-config \ - irqbalance \ ti-rpmsg-char \ ti-rpmsg-char-examples \ statcol \Signature · 1 line
2.41.0
PATCH 5/5 arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL
In reply to [email protected]From: Randolph Sapp <[email protected]>
This image install override is interesting. Perhaps we should move to the separate build target distro configs like pokey uses [1] to avoid configuration collisions while still allowing for some base image templating through include files like arago-image.inc
[1] https://git.yoctoproject.org/poky/tree/meta-poky/conf/distro/poky-tiny.conf?h=kirkstone
--- meta-arago-distro/recipes-core/images/arago-tiny-image.inc | 1 + 1 file changed, 1 insertion(+)
meta-arago-distro/recipes-core/images/arago-tiny-image.inc +1 -0
@@ -6,4 +6,5 @@ IMAGE_FEATURES:remove = "splash" IMAGE_INSTALL = " \ packagegroup-arago-sysvinit-boot \ + packagegroup-arago-boot \ "
Signature · 1 line
2.41.0
Re: [meta-arago][kirkstone/master][PATCH 5/5] arago-tiny-image: add packagegroup-arago-boot to IMAGE_INSTALL
Quoted 4 lines · Randolph Sapp via lists.yoctoproject.org
From: Randolph Sapp <[email protected]>
This image install override is interesting. Perhaps we should move to the separate build target distro configs like pokey uses [1] to avoid
What's "pokey"? It's Poky - https://elinux.org/Poky
Quoted 4 lines
configuration collisions while still allowing for some base image templating through include files like arago-image.inc
[1] https://git.yoctoproject.org/poky/tree/meta-poky/conf/distro/poky-tiny.conf?h=kirkstone
Either way, the above commit log doesn't seem to have anything to do with the actual change...
Quoted 10 lines
Signed-off-by Randolph Sapp <[email protected]>--- meta-arago-distro/recipes-core/images/arago-tiny-image.inc | 1 + 1 file changed, 1 insertion(+)meta-arago-distro/recipes-core/images/arago-tiny-image.inc +0
-0
meta-arago-distro/recipes-core/images/arago-tiny-image.inc IMAGE_FEATURES:remove = "splash" · line 9
Quoted 4 lines
meta-arago-distro/recipes-core/images/arago-tiny-image.inc +1
-0@@ -6,4 +6,5 @@ IMAGE_FEATURES:remove = "splash" IMAGE_INSTALL = " \ packagegroup-arago-sysvinit-boot \ + packagegroup-arago-boot \
This include file is shared among tiny and bootstrap images. While addind irqbalance and/or other tools might be useful for bootstrapping (?) it is not so clear for the tiny image. It was meant to be the very bare minimum and also used as initramfs and jailhouse cells.