Skip to contentSkip to conversation

ARM: dts: Facebook Yosemite 4 platform

PATCH In review Delphine CC Chiu 2 participants 5 messages Aug 28, 2023 – Sep 1, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v12 cover ARM: dts: Facebook Yosemite 4 platform

Add linux device tree entry related to
Yosemite 4 specific devices connected to BMC SoC.

Changelog:
v12 - Add spi gpio config
v11 - Add imux configs for i2c-mux
- Add gpio and eeprom devices
- Remove temperature-sensor 11-004a and 11-004b
- Change power-sensor ina230 to ina233
v10 - Change to 128MB flash layout from 64MB
v9 - Remove mac2/mac3 duplicated setting about no-hw-checksum v8 - Add description of Yosemite 4
- Remove unsupported ncsi config
- Revise i2c-mux config
- Correct power sensor i2c address
- Restore i2c 11 bus-frequency to default
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting
- Remove duplicated multi-master setting
v4 - Resend with cover letter
v3 - Revise the bootargs to stdout-path
- Revise i2c devices
v2 - Revise the DTS node name
v1 - Add binding document

Delphine CC Chiu (2):
dt-bindings: arm: aspeed: add Facebook Yosemite 4 board
ARM: dts: aspeed: yosemite4: add Facebook Yosemite 4 BMC

 .../bindings/arm/aspeed/aspeed.yaml           |    1 +
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 1102 +++++++++++++++++
 3 files changed, 1104 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
Signature · 1 line
2.25.1
#1 lore raw

PATCH v12 1/2 dt-bindings: arm: aspeed: add Facebook Yosemite 4 board

Document the new compatibles used on Facebook Yosemite 4.

---
Changelog:
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index e0eff4c05879..23ee325bfed0 100644
@@ -79,6 +79,7 @@ properties:
               - facebook,elbert-bmc
               - facebook,fuji-bmc
               - facebook,greatlakes-bmc
+              - facebook,yosemite4-bmc
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
Signature · 1 line
2.25.1
#2 lore raw

PATCH v12 2/2 ARM: dts: aspeed: yosemite4: add Facebook Yosemite 4 BMC

In reply to Delphine CC Chiu

Add linux device tree entry for Yosemite 4 devices connected to BMC. The Yosemite 4 is a Meta multi-node server platform, based on AST2600 SoC.

---
Changelog:
v12 - Add spi gpio config
v11 - Add imux configs for i2c-mux
- Add gpio and eeprom devices
- Remove temperature-sensor 11-004a and 11-004b
- Change power-sensor ina230 to ina233
v10 - Change to 128MB flash layout from 64MB
v9 - Remove mac2/mac3 duplicated setting about no-hw-checksum v8 - Add description of Yosemite 4
- Remove unsupported ncsi config
- Revise i2c-mux config
- Correct power sensor i2c address
- Restore i2c 11 bus-frequency to default
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting
- Remove duplicated multi-master setting
v3 - Revise the bootargs to stdout-path
- Revise i2c devices
v2 - Revise the DTS node name

---
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 1102 +++++++++++++++++
 2 files changed, 1103 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index c68984322a86..5b9264b823f3 100644
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-facebook-wedge400.dtb \
 	aspeed-bmc-facebook-yamp.dtb \
 	aspeed-bmc-facebook-yosemitev2.dtb \
+	aspeed-bmc-facebook-yosemite4.dtb \
 	aspeed-bmc-ibm-bonnell.dtb \
 	aspeed-bmc-ibm-everest.dtb \
 	aspeed-bmc-ibm-rainier.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +1102 -0

1,102 lines not on this page · raw message

Signature · 1 line
2.25.1
#3 lore raw

Re: [PATCH v12 2/2] ARM: dts: aspeed: yosemite4: add Facebook Yosemite 4 BMC

Quoted 3 lines · On Mon, Aug 28, 2023 at 1:52?AM Delphine CC Chiu <[email protected]>…

Add linux device tree entry for Yosemite 4 devices connected to BMC. The Yosemite 4 is a Meta multi-node server platform, based on AST2600 SoC.

This was already applied and sent upstream on Aug 10 by Joel. You'll need incremental patches.

Quoted 948 lines

---
Changelog:
v12 - Add spi gpio config
v11 - Add imux configs for i2c-mux
- Add gpio and eeprom devices
- Remove temperature-sensor 11-004a and 11-004b
- Change power-sensor ina230 to ina233
v10 - Change to 128MB flash layout from 64MB
v9 - Remove mac2/mac3 duplicated setting about no-hw-checksum v8 - Add description of Yosemite 4
- Remove unsupported ncsi config
- Revise i2c-mux config
- Correct power sensor i2c address
- Restore i2c 11 bus-frequency to default
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting
- Remove duplicated multi-master setting
v3 - Revise the bootargs to stdout-path
- Revise i2c devices
v2 - Revise the DTS node name

---
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 1102 +++++++++++++++++
 2 files changed, 1103 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
arch/arm/boot/dts/aspeed/Makefile +1 -0
index c68984322a86..5b9264b823f3 100644
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
        aspeed-bmc-facebook-wedge400.dtb \
        aspeed-bmc-facebook-yamp.dtb \
        aspeed-bmc-facebook-yosemitev2.dtb \
+       aspeed-bmc-facebook-yosemite4.dtb \
        aspeed-bmc-ibm-bonnell.dtb \
        aspeed-bmc-ibm-everest.dtb \
        aspeed-bmc-ibm-rainier.dtb \
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +901 -0
new file mode 100644
index 000000000000..851091a512dd
@@ -0,0 +1,1102 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+// Copyright 2022 Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/i2c/i2c.h>
+
+/ {
+       model = "Facebook Yosemite 4 BMC";
+       compatible = "facebook,yosemite4-bmc", "aspeed,ast2600";
+
+       aliases {
+               serial4 = &uart5;
+               serial5 = &uart6;
+               serial6 = &uart7;
+               serial7 = &uart8;
+               serial8 = &uart9;
+
+               i2c16 = &imux16;
+               i2c17 = &imux17;
+               i2c18 = &imux18;
+               i2c19 = &imux19;
+               i2c20 = &imux20;
+               i2c21 = &imux21;
+               i2c22 = &imux22;
+               i2c23 = &imux23;
+               i2c24 = &imux24;
+               i2c25 = &imux25;
+               i2c26 = &imux26;
+               i2c27 = &imux27;
+               i2c28 = &imux28;
+               i2c29 = &imux29;
+               i2c30 = &imux30;
+               i2c31 = &imux31;
+               i2c32 = &imux32;
+               i2c33 = &imux33;
+       };
+
+       chosen {
+               stdout-path = "serial4:57600n8";
+       };
+
+       memory at 80000000 {
+               device_type = "memory";
+               reg = <0x80000000 0x80000000>;
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";
+               io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>,
+                               <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
+                               <&adc1 0>, <&adc1 1>;
+       };
+
+       spi_gpio: spi-gpio {
+               status = "okay";
+               compatible = "spi-gpio";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               gpio-sck = <&gpio0 ASPEED_GPIO(X, 3) GPIO_ACTIVE_HIGH>;
+               gpio-mosi = <&gpio0 ASPEED_GPIO(X, 4) GPIO_ACTIVE_HIGH>;
+               gpio-miso = <&gpio0 ASPEED_GPIO(X, 5) GPIO_ACTIVE_HIGH>;
+               num-chipselects = <1>;
+               cs-gpios = <&gpio0 ASPEED_GPIO(X, 0) GPIO_ACTIVE_LOW>;
+
+               tpmdev at 0 {
+                       compatible = "tcg,tpm_tis-spi";
+                       spi-max-frequency = <33000000>;
+                       reg = <0>;
+               };
+       };
+};
+
+&uart1 {
+       status = "okay";
+};
+
+&uart2 {
+       status = "okay";
+};
+
+&uart3 {
+       status = "okay";
+};
+
+&uart4 {
+       status = "okay";
+};
+
+&uart5 {
+       status = "okay";
+};
+
+&uart6 {
+       status = "okay";
+};
+
+&uart7 {
+       status = "okay";
+};
+
+&uart8 {
+       status = "okay";
+};
+
+&uart9 {
+       status = "okay";
+};
+
+&wdt1 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_wdtrst1_default>;
+       aspeed,reset-type = "soc";
+       aspeed,external-signal;
+       aspeed,ext-push-pull;
+       aspeed,ext-active-high;
+       aspeed,ext-pulse-duration = <256>;
+};
+
+&mac2 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii3_default>;
+       use-ncsi;
+       mlx,multi-host;
+};
+
+&mac3 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii4_default>;
+       use-ncsi;
+       mlx,multi-host;
+};
+
+&fmc {
+       status = "okay";
+       flash at 0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc";
+               spi-rx-bus-width = <4>;
+               spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout-128.dtsi"
+       };
+       flash at 1 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc2";
+               spi-rx-bus-width = <4>;
+               spi-max-frequency = <50000000>;
+       };
+};
+
+&i2c0 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c1 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c2 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c3 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c4 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c5 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c6 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c7 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c8 {
+       status = "okay";
+       bus-frequency = <400000>;
+       i2c-mux at 70 {
+               compatible = "nxp,pca9544";
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x70>;
+
+               imux16: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux17: i2c at 1 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <1>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux18: i2c at 2 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <2>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux19: i2c at 3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <3>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+       };
+};
+
+&i2c9 {
+       status = "okay";
+       bus-frequency = <400000>;
+       i2c-mux at 71 {
+               compatible = "nxp,pca9544";
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x71>;
+
+               imux20: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux21: i2c at 1 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <1>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux22: i2c at 2 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <2>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux23: i2c at 3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <3>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+       };
+};
+
+&i2c10 {
+       status = "okay";
+       bus-frequency = <400000>;
+       i2c-mux at 74 {
+               compatible = "nxp,pca9544";
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x74>;
+
+               imux28: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+               };
+
+               imux29: i2c at 1 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <1>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 24 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x24>;
+                       };
+               };
+       };
+};
+
+&i2c11 {
+       status = "okay";
+       power-sensor at 10 {
+               compatible = "adi, adm1272";
+               reg = <0x10>;
+       };
+
+       power-sensor at 12 {
+               compatible = "adi, adm1272";
+               reg = <0x12>;
+       };
+
+       gpio at 20 {
+               compatible = "nxp,pca9555";
+               reg = <0x20>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       gpio at 21 {
+               compatible = "nxp,pca9555";
+               reg = <0x21>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       gpio at 22 {
+               compatible = "nxp,pca9555";
+               reg = <0x22>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       gpio at 23 {
+               compatible = "nxp,pca9555";
+               reg = <0x23>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       temperature-sensor at 48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       temperature-sensor at 49 {
+               compatible = "ti,tmp75";
+               reg = <0x49>;
+       };
+
+       eeprom at 54 {
+               compatible = "atmel,24c256";
+               reg = <0x54>;
+       };
+};
+
+&i2c12 {
+       status = "okay";
+       bus-frequency = <400000>;
+
+       temperature-sensor at 48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       eeprom at 50 {
+               compatible = "atmel,24c128";
+               reg = <0x50>;
+       };
+
+       eeprom at 54 {
+               compatible = "atmel,24c64";
+               reg = <0x54>;
+       };
+
+       rtc at 6f {
+               compatible = "nuvoton,nct3018y";
+               reg = <0x6f>;
+       };
+};
+
+&i2c13 {
+       status = "okay";
+       bus-frequency = <400000>;
+       gpio at 20 {
+               compatible = "nxp,pca9506";
+               reg = <0x20>;
+       };
+
+       gpio at 21 {
+               compatible = "nxp,pca9506";
+               reg = <0x21>;
+       };
+
+       gpio at 22 {
+               compatible = "nxp,pca9506";
+               reg = <0x22>;
+       };
+
+       gpio at 23 {
+               compatible = "nxp,pca9506";
+               reg = <0x23>;
+       };
+};
+
+&i2c14 {
+       status = "okay";
+       bus-frequency = <400000>;
+       adc at 1d {
+               compatible = "ti,adc128d818";
+               reg = <0x1d>;
+               ti,mode = /bits/ 8 <2>;
+       };
+
+       adc at 35 {
+               compatible = "ti,adc128d818";
+               reg = <0x35>;
+               ti,mode = /bits/ 8 <2>;
+       };
+
+       adc at 37 {
+               compatible = "ti,adc128d818";
+               reg = <0x37>;
+               ti,mode = /bits/ 8 <2>;
+       };
+
+       power-sensor at 40 {
+               compatible = "ti,ina233";
+               reg = <0x40>;
+       };
+
+       power-sensor at 41 {
+               compatible = "ti,ina233";
+               reg = <0x41>;
+       };
+
+       power-sensor at 42 {
+               compatible = "ti,ina233";
+               reg = <0x42>;
+       };
+
+       power-sensor at 43 {
+               compatible = "ti,ina233";
+               reg = <0x43>;
+       };
+
+       power-sensor at 44 {
+               compatible = "ti,ina233";
+               reg = <0x44>;
+       };
+
+       temperature-sensor at 4e {
+               compatible = "ti,tmp75";
+               reg = <0x4e>;
+       };
+
+       temperature-sensor at 4f {
+               compatible = "ti,tmp75";
+               reg = <0x4f>;
+       };
+
+       eeprom at 51 {
+               compatible = "atmel,24c128";
+               reg = <0x51>;
+       };
+
+       i2c-mux at 71 {
+               compatible = "nxp,pca9846";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x71>;
+
+               imux30: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 911

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +10 -0
+                       reg = <0>;
+
+                       adc at 1f {
+                               compatible = "ti,adc128d818";
+                               reg = <0x1f>;
+                               ti,mode = /bits/ 8 <2>;
+                       };
+
+                       pwm at 20{
+                               compatible = "max31790";

This is not documented. It also needs a vendor prefix.

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 351

Quoted 3 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +3 -0
+                               reg = <0x20>;
+                               #address-cells = <1>;
+                               #size-cells = <0>;

These 2 are for child nodes, but you don't have any. And a PWM probably never will.

Rob

#4 lore raw

RE: [PATCH v12 2/2] ARM: dts: aspeed: yosemite4: add Facebook Yosemite 4 BMC

Quoted 20 lines

-----Original Message-----
From: Rob Herring <[email protected]>
Sent: Tuesday, August 29, 2023 10:14 PM
To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>
Cc: patrick at stwcx.xyz; Krzysztof Kozlowski <[email protected]>; Conor Dooley <[email protected]>; Joel Stanley <[email protected]>; Andrew Jeffery <[email protected]>; devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux-aspeed at lists.ozlabs.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH v12 2/2] ARM: dts: aspeed: yosemite4: add Facebook Yosemite 4 BMC

Security Reminder: Please be aware that this email is sent by an external
sender.

Quoted 1 line · On Mon, Aug 28, 2023 at 1:52?AM Delphine CC Chiu <[email protected]>…
Quoted 6 lines
Quoted 2 lines

Add linux device tree entry for Yosemite 4 devices connected to BMC. The Yosemite 4 is a Meta multi-node server platform, based on AST2600

SoC.

This was already applied and sent upstream on Aug 10 by Joel. You'll need incremental patches.

I'll rebase the master and generate incremental patches in next time contribution, thank you for the correction.

Quoted 963 lines
Quoted 95 lines

---
Changelog:
v12 - Add spi gpio config
v11 - Add imux configs for i2c-mux
- Add gpio and eeprom devices
- Remove temperature-sensor 11-004a and 11-004b
- Change power-sensor ina230 to ina233
v10 - Change to 128MB flash layout from 64MB
v9 - Remove mac2/mac3 duplicated setting about no-hw-checksum v8 - Add description of Yosemite 4
- Remove unsupported ncsi config
- Revise i2c-mux config
- Correct power sensor i2c address
- Restore i2c 11 bus-frequency to default
v7 - Revise changelog format
v6 - Change project name from yosemitev4 to yosemite4 v5 - Revise rtc setting
- Remove duplicated multi-master setting
v3 - Revise the bootargs to stdout-path
- Revise i2c devices
v2 - Revise the DTS node name

---
 arch/arm/boot/dts/aspeed/Makefile             |    1 +
 .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 1102
+++++++++++++++++
 2 files changed, 1103 insertions(+)
 create mode 100644

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts

arch/arm/boot/dts/aspeed/Makefile +1 -0
index c68984322a86..5b9264b823f3 100644
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
        aspeed-bmc-facebook-wedge400.dtb \
        aspeed-bmc-facebook-yamp.dtb \
        aspeed-bmc-facebook-yosemitev2.dtb \
+       aspeed-bmc-facebook-yosemite4.dtb \
        aspeed-bmc-ibm-bonnell.dtb \
        aspeed-bmc-ibm-everest.dtb \
        aspeed-bmc-ibm-rainier.dtb \

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file mode 100644
index 000000000000..851091a512dd

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +42 -0
@@ -0,0 +1,1102 @@
+// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022
+Facebook Inc.
+
+/dts-v1/;
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h> #include
+<dt-bindings/leds/leds-pca955x.h>
+#include <dt-bindings/i2c/i2c.h>
+
+/ {
+       model = "Facebook Yosemite 4 BMC";
+       compatible = "facebook,yosemite4-bmc", "aspeed,ast2600";
+
+       aliases {
+               serial4 = &uart5;
+               serial5 = &uart6;
+               serial6 = &uart7;
+               serial7 = &uart8;
+               serial8 = &uart9;
+
+               i2c16 = &imux16;
+               i2c17 = &imux17;
+               i2c18 = &imux18;
+               i2c19 = &imux19;
+               i2c20 = &imux20;
+               i2c21 = &imux21;
+               i2c22 = &imux22;
+               i2c23 = &imux23;
+               i2c24 = &imux24;
+               i2c25 = &imux25;
+               i2c26 = &imux26;
+               i2c27 = &imux27;
+               i2c28 = &imux28;
+               i2c29 = &imux29;
+               i2c30 = &imux30;
+               i2c31 = &imux31;
+               i2c32 = &imux32;
+               i2c33 = &imux33;
+       };
+
+       chosen {
+               stdout-path = "serial4:57600n8";

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 52

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +10 -0
+       };
+
+       memory at 80000000 {
+               device_type = "memory";
+               reg = <0x80000000 0x80000000>;
+       };
+
+       iio-hwmon {
+               compatible = "iio-hwmon";
+               io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>,

<&adc0 3>,

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 53

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +1 -0
+                               <&adc0 4>, <&adc0 5>, <&adc0 6>,

<&adc0 7>,

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +10 -0
+                               <&adc1 0>, <&adc1 1>;
+       };
+
+       spi_gpio: spi-gpio {
+               status = "okay";
+               compatible = "spi-gpio";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               gpio-sck = <&gpio0 ASPEED_GPIO(X, 3)

GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 64

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +1 -0
+               gpio-mosi = <&gpio0 ASPEED_GPIO(X, 4)

GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 65

Quoted 1 line
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +1 -0
+               gpio-miso = <&gpio0 ASPEED_GPIO(X, 5)

GPIO_ACTIVE_HIGH>;

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 67

Quoted 2 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +2 -0
+               num-chipselects = <1>;
+               cs-gpios = <&gpio0 ASPEED_GPIO(X, 0)

GPIO_ACTIVE_LOW>;

Quoted 837 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +837 -0
+
+               tpmdev at 0 {
+                       compatible = "tcg,tpm_tis-spi";
+                       spi-max-frequency = <33000000>;
+                       reg = <0>;
+               };
+       };
+};
+
+&uart1 {
+       status = "okay";
+};
+
+&uart2 {
+       status = "okay";
+};
+
+&uart3 {
+       status = "okay";
+};
+
+&uart4 {
+       status = "okay";
+};
+
+&uart5 {
+       status = "okay";
+};
+
+&uart6 {
+       status = "okay";
+};
+
+&uart7 {
+       status = "okay";
+};
+
+&uart8 {
+       status = "okay";
+};
+
+&uart9 {
+       status = "okay";
+};
+
+&wdt1 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_wdtrst1_default>;
+       aspeed,reset-type = "soc";
+       aspeed,external-signal;
+       aspeed,ext-push-pull;
+       aspeed,ext-active-high;
+       aspeed,ext-pulse-duration = <256>; };
+
+&mac2 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii3_default>;
+       use-ncsi;
+       mlx,multi-host;
+};
+
+&mac3 {
+       status = "okay";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_rmii4_default>;
+       use-ncsi;
+       mlx,multi-host;
+};
+
+&fmc {
+       status = "okay";
+       flash at 0 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc";
+               spi-rx-bus-width = <4>;
+               spi-max-frequency = <50000000>; #include
+"openbmc-flash-layout-128.dtsi"
+       };
+       flash at 1 {
+               status = "okay";
+               m25p,fast-read;
+               label = "bmc2";
+               spi-rx-bus-width = <4>;
+               spi-max-frequency = <50000000>;
+       };
+};
+
+&i2c0 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c1 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c2 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c3 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c4 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c5 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c6 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c7 {
+       status = "okay";
+       mctp-controller;
+       bus-frequency = <400000>;
+       multi-master;
+
+       mctp at 10 {
+               compatible = "mctp-i2c-controller";
+               reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
+       };
+
+       power-sensor at 40 {
+               compatible = "adi,adm1278";
+               reg = <0x40>;
+       };
+};
+
+&i2c8 {
+       status = "okay";
+       bus-frequency = <400000>;
+       i2c-mux at 70 {
+               compatible = "nxp,pca9544";
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x70>;
+
+               imux16: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux17: i2c at 1 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <1>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux18: i2c at 2 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <2>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux19: i2c at 3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <3>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+       };
+};
+
+&i2c9 {
+       status = "okay";
+       bus-frequency = <400000>;
+       i2c-mux at 71 {
+               compatible = "nxp,pca9544";
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x71>;
+
+               imux20: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux21: i2c at 1 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <1>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux22: i2c at 2 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <2>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+
+               imux23: i2c at 3 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <3>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 49 {
+                               compatible = "nxp,pca9537";
+                               reg = <0x49>;
+                       };
+
+                       eeprom at 50 {
+                               compatible = "atmel,24c128";
+                               reg = <0x50>;
+                       };
+
+                       eeprom at 51 {
+                               compatible = "atmel,24c128";
+                               reg = <0x51>;
+                       };
+
+                       eeprom at 54 {
+                               compatible = "atmel,24c128";
+                               reg = <0x54>;
+                       };
+               };
+       };
+};
+
+&i2c10 {
+       status = "okay";
+       bus-frequency = <400000>;
+       i2c-mux at 74 {
+               compatible = "nxp,pca9544";
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x74>;
+
+               imux28: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+               };
+
+               imux29: i2c at 1 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <1>;
+                       gpio at 20 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x20>;
+                       };
+
+                       gpio at 21 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x21>;
+                       };
+
+                       gpio at 22 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x22>;
+                       };
+
+                       gpio at 23 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x23>;
+                       };
+
+                       gpio at 24 {
+                               compatible = "nxp,pca9506";
+                               reg = <0x24>;
+                       };
+               };
+       };
+};
+
+&i2c11 {
+       status = "okay";
+       power-sensor at 10 {
+               compatible = "adi, adm1272";
+               reg = <0x10>;
+       };
+
+       power-sensor at 12 {
+               compatible = "adi, adm1272";
+               reg = <0x12>;
+       };
+
+       gpio at 20 {
+               compatible = "nxp,pca9555";
+               reg = <0x20>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       gpio at 21 {
+               compatible = "nxp,pca9555";
+               reg = <0x21>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       gpio at 22 {
+               compatible = "nxp,pca9555";
+               reg = <0x22>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       gpio at 23 {
+               compatible = "nxp,pca9555";
+               reg = <0x23>;
+               gpio-controller;
+               #gpio-cells = <2>;
+       };
+
+       temperature-sensor at 48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       temperature-sensor at 49 {
+               compatible = "ti,tmp75";
+               reg = <0x49>;
+       };
+
+       eeprom at 54 {
+               compatible = "atmel,24c256";
+               reg = <0x54>;
+       };
+};
+
+&i2c12 {
+       status = "okay";
+       bus-frequency = <400000>;
+
+       temperature-sensor at 48 {
+               compatible = "ti,tmp75";
+               reg = <0x48>;
+       };
+
+       eeprom at 50 {
+               compatible = "atmel,24c128";
+               reg = <0x50>;
+       };
+
+       eeprom at 54 {
+               compatible = "atmel,24c64";
+               reg = <0x54>;
+       };
+
+       rtc at 6f {
+               compatible = "nuvoton,nct3018y";
+               reg = <0x6f>;
+       };
+};
+
+&i2c13 {
+       status = "okay";
+       bus-frequency = <400000>;
+       gpio at 20 {
+               compatible = "nxp,pca9506";
+               reg = <0x20>;
+       };
+
+       gpio at 21 {
+               compatible = "nxp,pca9506";
+               reg = <0x21>;
+       };
+
+       gpio at 22 {
+               compatible = "nxp,pca9506";
+               reg = <0x22>;
+       };
+
+       gpio at 23 {
+               compatible = "nxp,pca9506";
+               reg = <0x23>;
+       };
+};
+
+&i2c14 {
+       status = "okay";
+       bus-frequency = <400000>;
+       adc at 1d {
+               compatible = "ti,adc128d818";
+               reg = <0x1d>;
+               ti,mode = /bits/ 8 <2>;
+       };
+
+       adc at 35 {
+               compatible = "ti,adc128d818";
+               reg = <0x35>;
+               ti,mode = /bits/ 8 <2>;
+       };
+
+       adc at 37 {
+               compatible = "ti,adc128d818";
+               reg = <0x37>;
+               ti,mode = /bits/ 8 <2>;
+       };
+
+       power-sensor at 40 {
+               compatible = "ti,ina233";
+               reg = <0x40>;
+       };
+
+       power-sensor at 41 {
+               compatible = "ti,ina233";
+               reg = <0x41>;
+       };
+
+       power-sensor at 42 {
+               compatible = "ti,ina233";
+               reg = <0x42>;
+       };
+
+       power-sensor at 43 {
+               compatible = "ti,ina233";
+               reg = <0x43>;
+       };
+
+       power-sensor at 44 {
+               compatible = "ti,ina233";
+               reg = <0x44>;
+       };
+
+       temperature-sensor at 4e {
+               compatible = "ti,tmp75";
+               reg = <0x4e>;
+       };
+
+       temperature-sensor at 4f {
+               compatible = "ti,tmp75";
+               reg = <0x4f>;
+       };
+
+       eeprom at 51 {
+               compatible = "atmel,24c128";
+               reg = <0x51>;
+       };
+
+       i2c-mux at 71 {
+               compatible = "nxp,pca9846";
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               idle-state = <0>;
+               i2c-mux-idle-disconnect;
+               reg = <0x71>;
+
+               imux30: i2c at 0 {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       reg = <0>;
+
+                       adc at 1f {
+                               compatible = "ti,adc128d818";
Quoted 8 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 911

Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +6 -0
+                               reg = <0x1f>;
+                               ti,mode = /bits/ 8 <2>;
+                       };
+
+                       pwm at 20{
+                               compatible = "max31790";

This is not documented. It also needs a vendor prefix.

The vendor prefix will be added in next time contribution,
and this device seems has been used in former projects.
Would you please to tell that whether I should inform the driver's author or add the binding document on my own ?

Quoted 7 lines

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts line 351

Quoted 4 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts new file +3 -0
+                               reg = <0x20>;
+                               #address-cells = <1>;
+                               #size-cells = <0>;

These 2 are for child nodes, but you don't have any. And a PWM probably never will.

I'll remove the redundant config in next time contribution, thank you for the correction.

Quoted 2 lines

Rob