Skip to contentSkip to conversation

device property: Clarify usage scope of some struct fwnode_handle members

PATCH In review Andy Shevchenko 4 participants 5 messages Sep 4, 2023 – Sep 19, 2023

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 device property: Clarify usage scope of some struct fwnode_handle members

Most of the struct fwnode_handle members are for exclusive use with device links framework. Clarify this by adding a respective comment.

---
 include/linux/fwnode.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/fwnode.h +2 -0
index 5700451b300f..2a72f55d26eb 100644
@@ -41,6 +41,8 @@ struct device;
 struct fwnode_handle {
 	struct fwnode_handle *secondary;
 	const struct fwnode_operations *ops;
+
+	/* The below is used solely by device links, don't use otherwise */
 	struct device *dev;
 	struct list_head suppliers;
 	struct list_head consumers;
Signature · 1 line
2.40.0.1.gaa8946217a0b
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andy Shevchenko

Most of the struct fwnode_handle members are for exclusive use with device links framework. Clarify this by adding a respective comment.

Yes, this is important clarification.

Quoted 19 lines
---
 include/linux/fwnode.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/fwnode.h +2 -0
index 5700451b300f..2a72f55d26eb 100644
@@ -41,6 +41,8 @@ struct device;
 struct fwnode_handle {
 	struct fwnode_handle *secondary;
 	const struct fwnode_operations *ops;
+
+	/* The below is used solely by device links, don't use otherwise */
 	struct device *dev;
 	struct list_head suppliers;
 	struct list_head consumers;
Signature · 1 line
2.40.0.1.gaa8946217a0b
Signature · 1 line
heikki
author reviewer
#3 lore raw
In reply to Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

Most of the struct fwnode_handle members are for exclusive use with device links framework. Clarify this by adding a respective comment.

Thank you, folks, for the review. Rafael, Greg, who can apply this?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw
Quoted 5 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko

Most of the struct fwnode_handle members are for exclusive use with device links framework. Clarify this by adding a respective comment.

Thank you, folks, for the review. Rafael, Greg, who can apply this?

I will, give me some time to catch up with my pending patch queue.

greg k-h