device property: Clarify usage scope of some struct fwnode_handle members
Subsystems (3)
Andy Shevchenko
reviewerPATCH 1/1 device property: Clarify usage scope of some struct fwnode_handle members
Most of the struct fwnode_handle members are for exclusive use with device links framework. Clarify this by adding a respective comment.
--- include/linux/fwnode.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/fwnode.h +2 -0
@@ -41,6 +41,8 @@ struct device;struct fwnode_handle {struct fwnode_handle *secondary;const struct fwnode_operations *ops; + +/* The below is used solely by device links, don't use otherwise */ struct device *dev;struct list_head suppliers;struct list_head consumers;
Signature · 1 line
2.40.0.1.gaa8946217a0b
Quoted 4 lines · Andy Shevchenko
Most of the struct
fwnode_handlemembers are for exclusive use with device links framework. Clarify this by adding a respective comment.Signed-off-by Andy Shevchenko <[email protected]>
Yes, this is important clarification.
Quoted 19 lines
--- include/linux/fwnode.h | 2 ++ 1 file changed, 2 insertions(+)include/linux/fwnode.h +2
-0@@ -41,6 +41,8 @@ struct device;struct fwnode_handle {struct fwnode_handle *secondary;const struct fwnode_operations *ops; + +/* The below is used solely by device links, don't use otherwise */ struct device *dev;struct list_head suppliers;struct list_head consumers;Signature · 1 line
2.40.0.1.gaa8946217a0b
Signature · 1 line
heikki
Quoted 4 lines · Andy Shevchenko
Most of the struct
fwnode_handlemembers are for exclusive use with device links framework. Clarify this by adding a respective comment.Signed-off-by Andy Shevchenko <[email protected]>
Signature · 1 line
Sakari Ailus
Andy Shevchenko
reviewerQuoted 2 lines · Andy Shevchenko
Most of the struct
fwnode_handlemembers are for exclusive use with device links framework. Clarify this by adding a respective comment.
Thank you, folks, for the review. Rafael, Greg, who can apply this?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Greg Kroah-Hartman
maintainerQuoted 5 lines · Andy Shevchenko
Quoted 2 lines · Andy Shevchenko
Most of the struct
fwnode_handlemembers are for exclusive use with device links framework. Clarify this by adding a respective comment.Thank you, folks, for the review. Rafael, Greg, who can apply this?
I will, give me some time to catch up with my pending patch queue.
greg k-h