leds: Drop BUG_ON check for LED_COLOR_ID_MULTI
PATCH 1/1 leds: Drop BUG_ON check for LED_COLOR_ID_MULTI
Commit c3f853184bed ("leds: Fix BUG_ON check for LED_COLOR_ID_MULTI that is always false") fixed a no-op BUG_ON. This turned out to cause a regression, since some in-tree device-tree files already use LED_COLOR_ID_MULTI.
Drop the BUG_ON altogether.
--- drivers/leds/led-core.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/leds/led-core.c +0 -4
@@ -479,10 +479,6 @@ int led_compose_name(struct device *dev, struct led_init_data *init_data,led_parse_fwnode_props (dev, fwnode, &props); -/* We want to label LEDs that can produce full range of colors -* as RGB, not multicolor */ -BUG_ON (props.color ==LED_COLOR_ID_MULTI ); -if (props.label) {/* * If init_data.devicename is NULL, then it indicates that
Signature · 1 line
2.41.0
Hello,
Greg tells me to pester LED maintainers to get this into Linus' tree soon, so that we can avoid stable incosistencies (see
https://lore.kernel.org/stable/2023091901-vessel-giggling-55ee@gregkh/).
Sorry about the inconvenience, this would not happen if this was not sent into stable in the first place, which is my fault, since I added the Fixes tag.
Marek
Hi!
Quoted 7 lines
Greg tells me to pester LED maintainers to get this into Linus' tree soon, so that we can avoid stable incosistencies (see
https://lore.kernel.org/stable/2023091901-vessel-giggling-55ee@gregkh/).Sorry about the inconvenience, this would not happen if this was not sent into stable in the first place, which is my fault, since I added the Fixes tag.
Actually, no, it is not your fault. It was pretty clear your patch is not "fixing serious bug" so it should not have gone into stable in the first place.
For mainline, should we perhaps keep the BUG_ON and fix the affected driver, instead?
Best regards,
Pavel
Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.
Hi!
Quoted 8 lines
Quoted 7 lines
Greg tells me to pester LED maintainers to get this into Linus' tree soon, so that we can avoid stable incosistencies (see
https://lore.kernel.org/stable/2023091901-vessel-giggling-55ee@gregkh/).Sorry about the inconvenience, this would not happen if this was not sent into stable in the first place, which is my fault, since I added the Fixes tag.
Quoted 6 lines
Actually, no, it is not your fault. It was pretty clear your patch is not "fixing serious bug" so it should not have gone into stable in the first place.
For mainline, should we perhaps keep the
BUG_ONand fix the affected driver, instead?
Aha, rereading the discussion.. yes, we want to drop the BUG_ON. Sorry for the noise.
Best regards,
Pavel
Signature · 1 line
People of Russia, stop Putin before his war on Ukraine escalates.
Lee Jones
maintainerQuoted 9 lines · Marek Behún
Hello,
Greg tells me to pester LED maintainers to get this into Linus' tree soon, so that we can avoid stable incosistencies (see
https://lore.kernel.org/stable/2023091901-vessel-giggling-55ee@gregkh/).Sorry about the inconvenience, this would not happen if this was not sent into stable in the first place, which is my fault, since I added the Fixes tag.
Starting back on upstream work now.
I'll get something out shortly.
Signature · 1 line
Lee Jones [李琼斯]
Re: (subset) [PATCH] leds: Drop BUG_ON check for LED_COLOR_ID_MULTI
In reply to Marek BehúnQuoted 8 lines · Marek Behún
Commit
c3f853184bed("leds: FixBUG_ONcheck forLED_COLOR_ID_MULTIthat is always false") fixed a no-opBUG_ON. This turned out to cause a regression, since some in-tree device-tree files already useLED_COLOR_ID_MULTI.Drop the
BUG_ONaltogether.[...]
Applied, thanks!
[1/1] leds: Drop BUG_ON check for LED_COLOR_ID_MULTI
commit: 9dc1664fab2246bc2c3e9bf2cf21518a857f9b5b
--
Lee Jones [李琼斯]