Skip to contentSkip to conversation

dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043

PATCH In review Fabio Estevam 2 participants 5 messages Sep 27, 2023 – Oct 9, 2023

Subsystems (2)
Device tree bindings USB
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v3 1/2 dt-bindings: usb: gpio-sbu-mux: Add an entry for CBDTU02043

From: Fabio Estevam <[email protected]>

Add a compatible entry for the NXP CBDTU02043 GPIO-based mux hardware used for connecting, disconnecting and switching orientation of the SBU lines in USB Type-C applications.

CBTU02043 datasheet: https://www.nxp.com/docs/en/data-sheet/CBTU02043.pdf

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Conor Dooley <[email protected]>

---
Changes since v2:
- None. Splitted the dt-bindings from the dts changes so that this series can go via the USB tree.

Changes since v1:
- None. Only collected Conor's Ack.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +1 -0
index f196beb826d8..b61dcf8b4aad 100644
@@ -19,6 +19,7 @@ properties:
   compatible:
     items:
       - enum:
+          - nxp,cbdtu02043
           - onnn,fsusb43l10x
           - pericom,pi3usb102
       - const: gpio-sbu-mux
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v3 2/2 dt-bindings: usb: gpio-sbu-mux: Make 'mode-switch' not required

From: Fabio Estevam <[email protected]>

On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is no mode-switch, only an orientation switch.

Make the 'mode-switch' property a non-required one.

Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Newly introduced.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +0 -1
index b61dcf8b4aad..d3b2b666ec2a 100644
@@ -51,7 +51,6 @@ required:
   - compatible
   - enable-gpios
   - select-gpios
-  - mode-switch
   - orientation-switch
   - port
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH v3 2/2] dt-bindings: usb: gpio-sbu-mux: Make 'mode-switch' not required

Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is no mode-switch, only an orientation switch.

Make the 'mode-switch' property a non-required one.

There seem to be very few compatibles in this file, so I guess everything uses the generic compatible. I'm not expecting you to know why it's like this, but should we add a compatible for this particular mux & only relax the requirement for it specifically?

Quoted 24 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Newly introduced.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +0 -1
index b61dcf8b4aad..d3b2b666ec2a 100644
@@ -51,7 +51,6 @@ required:
   - compatible
   - enable-gpios
   - select-gpios
-  - mode-switch
   - orientation-switch
   - port
Signature · 1 line
2.34.1
author
#3 lore raw

Re: [PATCH v3 2/2] dt-bindings: usb: gpio-sbu-mux: Make 'mode-switch' not required

Hi Conor,

Quoted 7 lines · Conor Dooley
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is no mode-switch, only an orientation switch.

Quoted 6 lines
Quoted 1 line

Make the 'mode-switch' property a non-required one.

There seem to be very few compatibles in this file, so I guess everything uses the generic compatible. I'm not expecting you to know why it's like this, but should we add a compatible for this particular mux & only relax the requirement for it specifically?

I am not sure.

Bjorn, do you have any suggestions, please?

Quoted 23 lines
Quoted 23 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Newly introduced.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +0 -2
index b61dcf8b4aad..d3b2b666ec2a 100644
@@ -51,7 +51,6 @@ required:
   - compatible
   - enable-gpios
   - select-gpios
-  - mode-switch
   - orientation-switch
   - port
 
--

2.34.1

Acked-by
#4 lore raw

Re: [PATCH v3 2/2] dt-bindings: usb: gpio-sbu-mux: Make 'mode-switch' not required

Quoted 12 lines · Fabio Estevam

Hi Conor,

Quoted 9 lines · Conor Dooley
Quoted 6 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

On a i.MX8QXP MEK board that has an NXP CBDTU02043 mux, there is no mode-switch, only an orientation switch.

Make the 'mode-switch' property a non-required one.

Quoted 8 lines
Quoted 4 lines

There seem to be very few compatibles in this file, so I guess everything uses the generic compatible. I'm not expecting you to know why it's like this, but should we add a compatible for this particular mux & only relax the requirement for it specifically?

I am not sure.

Bjorn, do you have any suggestions, please?

FWIW,

Acked-by Conor Dooley <[email protected]>

although I do think that adding more compatibles if there is gonna be divergence in capabilities is a good idea..

Cheers,
Conor.

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Signed-off-by Fabio Estevam <[email protected]>

---
Changes since v2:
- Newly introduced.

 Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml | 1 -
 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/usb/gpio-sbu-mux.yaml +0 -2
index b61dcf8b4aad..d3b2b666ec2a 100644
@@ -51,7 +51,6 @@ required:
   - compatible
   - enable-gpios
   - select-gpios
-  - mode-switch
   - orientation-switch
   - port
 
--

2.34.1