ti: fix possible memory leak in _ti_omap4_clkctrl_setup
Subsystems (2)
PATCH 1/1 ti: fix possible memory leak in _ti_omap4_clkctrl_setup
kstrndup and kstrdup_and_replace in clkctrl_get_name can perform dynamic memory allocation. So clkctrl_name needs to be freed when provider->clkdm_name is NULL.
Fixes bd46cd0b802d ("clk: ti: clkctrl: check return value of kasprintf()")
Signed-off-by Hangyu Hua <[email protected]>
--- drivers/clk/ti/clkctrl.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/ti/clkctrl.c +1 -0
@@ -591,6 +591,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node) provider->clkdm_name =kasprintf (GFP_KERNEL ,"%s_clkdm" , clkctrl_name);if (!provider->clkdm_name) { +kfree (clkctrl_name);kfree (provider);return ; }
Signature · 1 line
2.34.1
Quoted 1 line · Hangyu Hua
kstrndup and
kstrdup_and_replaceinclkctrl_get_namecan perform
kstrndup()kstrdup_and_replace()clkctrl_get_name()
Quoted 2 lines
dynamic memory allocation. So
clkctrl_nameneeds to be freed whenprovider->clkdm_nameis NULL.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 7 lines · Andy Shevchenko
Quoted 1 line · Hangyu Hua
kstrndup and
kstrdup_and_replaceinclkctrl_get_namecan perform
kstrndup()kstrdup_and_replace()clkctrl_get_name()
I see. I will send a v2 later.
Thanks,
Hangyu
Quoted 3 lines
Quoted 2 lines
dynamic memory allocation. So
clkctrl_nameneeds to be freed whenprovider->clkdm_nameis NULL.